Fix artefacts in LaserHoldfast outline due to corner overcorrections#924
Merged
florianfesti merged 2 commits intoMay 6, 2026
Merged
Conversation
* correct_corners=False to avoid overcorrections. * added small radius with size of the burn corrections to avoid negative corner artefacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some drawing artefacts done by
polygonWall()corner correction as well as by the addedburnradius in some corners.Before the hook had some larger extra lines in its start and end corners:
correct_corners=Falseto avoid overcorrections for these difficult corners.burnradius appear (due toself.burn - radiusinBoxes.corner()whileradius=0), so a radius withself.burnis added to get a proper, zero corner.Nonewas added to makepolygonWall()autoclose the path. The result has some extra points for the autoclosing then, which seem to be acceptable and not easily avoidable.After:
