ci: repo hygiene — ruff-format, delete dead automation, defang renovate#21
Conversation
Replace the black pre-commit hook with ruff-format. Editors run `ruff format`, but CI used black, and the two disagree on a few constructs (e.g. wrapping `assert X, msg`), which produced phantom diffs on every Python edit. Using one formatter (ruff) end to end removes that churn. - .pre-commit-config.yaml: drop psf/black, add the ruff-format hook. - .ruff.toml: ignore COM812 and ISC001 (they conflict with the formatter). - Reformat the 4 files where black and ruff-format differed (const.py, test_init.py, test_switch.py, webapp/app.py); the other 28 already match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
These are unmodified upstream community-management artifacts that are dead on a solo fork (Issues and Discussions are disabled, no Probot apps are installed, labels referenced don't exist): - .github/ISSUE_TEMPLATE/ (issues are disabled; links/labels point upstream) - .github/config.yml, .github/auto-comment.yml (welcome/auto-comment bots that aren't installed) - toc.yaml (a 3-year-stale third-party action holding a write token; the README TOC rarely changes and can be regenerated manually) - release-drafter.yml + config (release.yml never consumes the draft; it uses generate_release_notes instead, and the drafter left an orphan draft) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- docs.yml: only upload the Pages artifact on push (PRs can't deploy -- the deploy job is gated to push on main -- so the upload was wasted; the build still runs on PRs as a sanity check). - markdown-code-runner.yml: keep the PR drift-gate but drop the push-to-main auto-commit, which raced with toc.yaml and re-triggered every push:[main] workflow. With the PR gate, main can't drift. - renovate.json: disable automerge (no branch protection yet, so auto- landing dep bumps is unsafe) and dependencyDashboard (Issues are disabled, so the dashboard can't render). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughRelease NotesFormatter migration: Black → Ruff
Removed community automation
CI/deployment changes
Note: No breaking changes to product behavior. Pending: reconcile manifest/pyproject version numbers and enable branch protection rules once status checks are finalized. WalkthroughThis PR performs repository maintenance by removing unused GitHub issue templates and automation configurations, disables Renovate dashboard and automerge features, modifies workflow behavior (documentation artifact gating and generated-content drift detection), updates development tooling (black→ruff-format, additional Ruff lint rules), and refactors test assertions for clearer failure messages. ChangesRepository Maintenance and Quality Improvements
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
Repo hygiene: remove dead inherited automation, align the formatter with local
tooling, and defang unsafe defaults. No product code behavior changes. [proof: config]
Changes
Formatter (stops the recurring churn)
ruff formatbut CIused black; they disagreed on a few constructs, producing phantom diffs on every
Python edit. One formatter end-to-end fixes it. Ignored COM812/ISC001 (they conflict
with the formatter). Only 4 files needed reformatting. [proof: config]
Delete dead community automation / stale workflows
.github/ISSUE_TEMPLATE/(Issues are disabled; links/labels point upstream),config.yml+auto-comment.yml(welcome bots not installed),toc.yaml(3-yr-stale third-party action),
release-drafterworkflow + config (release.ymlnever consumes the draft; it left an orphan draft, now deleted).
Trim noisy / unsafe CI behavior
docs.yml: upload the Pages artifact on push only (PRs can't deploy).markdown-code-runner.yml: keep the PR drift-gate, drop the push-to-mainauto-commit (it raced with
toc.yamland re-triggered every push workflow).renovate.json: disableautomerge(no branch protection yet) and the deaddependencyDashboard(Issues disabled).Notes / deferred
toc.yamldeletion: the README TOC no longer auto-regenerates; it rarely changes andcan be run manually (folding doctoc into
scripts/update-generated-contentwas leftas a small follow-up).
manifest/pyproject1.30.1vsrelease tags) + a
CONTRIBUTING.md, and enabling required-status-checks (branchprotection) now that the trimmed check names are final.
Proof