Dbal Adapter Test Suite - close connectsions in teardown

Author: norberttech

src/adapter/etl-adapter-doctrine/tests/Flow/ETL/Adapter/Doctrine/Tests/Context/DatabaseContext.php

@@ -7,12 +7,14 @@
 use Doctrine\DBAL\Connection;
 use Doctrine\DBAL\Schema\Table;
 
-final readonly class DatabaseContext
+final class DatabaseContext
 {
+    private array $createdTables = [];
+
     public function __construct(
-        private Connection $connection,
-        private InsertQueryCounter $insertQueryCounter,
-        private SelectQueryCounter $selectQueryCounter,
+        private readonly Connection $connection,
+        private readonly InsertQueryCounter $insertQueryCounter,
+        private readonly SelectQueryCounter $selectQueryCounter,
     ) {
     }
 
@@ -30,14 +32,15 @@ public function createTable(Table $table) : void
         }
 
         $schemaManager->createTable($table);
+        $this->createdTables[] = $table->getName();
     }
 
     public function dropAllTables() : void
     {
         $schemaManager = $this->connection->createSchemaManager();
 
-        foreach ($schemaManager->listTables() as $table) {
-            $schemaManager->dropTable($table->getName());
+        foreach ($this->createdTables as $tableName) {
+            $schemaManager->dropTable($tableName);
         }
     }
 

src/adapter/etl-adapter-doctrine/tests/Flow/ETL/Adapter/Doctrine/Tests/IntegrationTestCase.php

@@ -55,6 +55,12 @@ protected function setUp() : void
     protected function tearDown() : void
     {
         $this->pgsqlDatabaseContext->dropAllTables();
+        $this->mysqlDatabaseContext->dropAllTables();
+        $this->sqliteDatabaseContext->dropAllTables();
+
+        $this->pgsqlDatabaseContext->connection()->close();
+        $this->mysqlDatabaseContext->connection()->close();
+        $this->sqliteDatabaseContext->connection()->close();
     }
 
     protected function mysqlConnectionParams() : array

src/core/etl/src/Flow/ETL/DataFrame.php

@@ -513,6 +513,10 @@ public function limit(?int $limit) : self
      */
     public function load(Loader $loader) : self
     {
+        if ($loader instanceof LoaderExtension) {
+            $this->context = $loader->onAdded($this->context);
+        }
+
         $this->pipeline = $this->context->config->optimizer()->optimize($loader, $this->pipeline);
 
         return $this;