Skip to content

Commit 2854816

Browse files
committed
DONT MERGE
1 parent 1efdd51 commit 2854816

156 files changed

Lines changed: 3498 additions & 4049 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

src/core/etl/src/Flow/ETL/Cache/Implementation/PSRSimpleCache.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ public function delete(string $key): void
3737

3838
public function get(string $key): Row|Rows|CacheIndex
3939
{
40-
// @mago-ignore analysis:mixed-assignment
4140
$serializedValue = $this->cache->get($key);
4241

4342
if (!$serializedValue) {

src/core/etl/src/Flow/ETL/Config/Cache/CacheConfigBuilder.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ public function cache(Cache $cache): self
6666
*/
6767
public function externalSortBucketsCount(int $externalSortBucketsCount): self
6868
{
69-
// @mago-ignore analysis:impossible-condition,redundant-comparison
7069
if ($externalSortBucketsCount < 1) {
7170
throw new InvalidArgumentException('External sort buckets count must be greater than 0');
7271
}

src/core/etl/src/Flow/ETL/Constraint/SortedByConstraint.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ final class SortedByConstraint implements Constraint
2323
private bool $firstRow = true;
2424

2525
/**
26-
* @var array<string, mixed>
26+
* @var array<string, null|array<array-key, mixed>|bool|float|int|object|string>
2727
*/
2828
private array $previousValues = [];
2929

@@ -46,9 +46,7 @@ public function isSatisfiedBy(Row $row): bool
4646
}
4747

4848
foreach ($this->references->all() as $reference) {
49-
// @mago-ignore analysis:mixed-assignment
5049
$currentValue = $row->valueOf($reference);
51-
// @mago-ignore analysis:mixed-assignment
5250
$previousValue = $this->previousValues[$reference->name()];
5351

5452
$direction = $reference->sort();
@@ -120,7 +118,6 @@ public function violation(Row $row): string
120118

121119
foreach ($this->references->all() as $reference) {
122120
$entry = $row->get($reference);
123-
// @mago-ignore analysis:mixed-assignment
124121
$previousValue = $this->previousValues[$reference->name()] ?? null;
125122

126123
$violations[] = sprintf(

0 commit comments

Comments
 (0)