Skip to content

Commit 29e1b50

Browse files
committed
fix: typo in flow-php/arrow-ext release workflow
1 parent 472c42e commit 29e1b50

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

shell.nix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ pkgs.mkShell {
5757
pkgs.symfony-cli
5858
pkgs.act
5959
pkgs.hyperfine
60+
pkgs.actionlint
6061
]
6162
++ pkgs.lib.optional with-blackfire pkgs.blackfire
6263
++ pkgs.lib.optionals with-wasm [

src/extension/arrow-ext/.github/workflows/release.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,8 @@ jobs:
8383
echo "::endgroup::"
8484
8585
echo "::group::Verify extension loads"
86-
php -n -d extension=/workspace/target/release/libarrow.so -r "if (!extension_loaded(\"arrow\")) { echo \"ERROR: arrow extension failed to load\n\"; exit(1); } echo \"arrow extension loaded successfully\n\";"
86+
php -n -d extension=/workspace/target/release/libarrow.so -m | grep -q arrow || { echo "ERROR: arrow extension failed to load"; exit 1; }
87+
echo "arrow extension loaded successfully"
8788
echo "::endgroup::"
8889
8990
echo "::group::Package artifact"
@@ -151,7 +152,9 @@ jobs:
151152
run: cargo build --release
152153

153154
- name: Verify extension loads
154-
run: php -n -d extension=./target/release/libarrow.dylib -r 'if (!extension_loaded("arrow")) { echo "ERROR: arrow extension failed to load\n"; exit(1); } echo "arrow extension loaded successfully\n";'
155+
run: |
156+
php -n -d extension=./target/release/libarrow.dylib -m | grep -q arrow || { echo "ERROR: arrow extension failed to load"; exit 1; }
157+
echo "arrow extension loaded successfully"
155158
156159
- name: Create ZIP archive
157160
run: |

0 commit comments

Comments
 (0)