fix: dependencies, static analysis

Author: norberttech

composer.lock

@@ -164,6 +164,27 @@ parameters:
         -
             path: src/lib/parquet/src/Flow/Parquet/Dremel/DremelShredder.php
             identifier: assign.propertyType
+        # brick/math 0.12-0.14 vs 0.15+ compatibility shim — branches differ per installed version
+        -
+            path: src/core/etl/src/Flow/Calculator/Calculator.php
+            identifier: function.alreadyNarrowedType
+            reportUnmatched: false
+        -
+            path: src/core/etl/src/Flow/Calculator/Calculator.php
+            identifier: function.impossibleType
+            reportUnmatched: false
+        -
+            path: src/core/etl/src/Flow/Calculator/Calculator.php
+            identifier: method.nonObject
+            reportUnmatched: false
+        -
+            path: src/core/etl/src/Flow/Calculator/Calculator.php
+            identifier: classConstant.notFound
+            reportUnmatched: false
+        -
+            path: src/core/etl/src/Flow/Calculator/Calculator.php
+            identifier: argument.type
+            reportUnmatched: false
 
 includes:
     - tools/phpstan/vendor/spaze/phpstan-disallowed-calls/extension.neon

phpstan.neon

@@ -9,6 +9,7 @@
 use Flow\Bridge\Symfony\FilesystemCache\Tests\Unit\Double\{FailingMvFilesystem, SpyLogger, SpyMarshaller};
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Cache\Exception\InvalidArgumentException;
+use Symfony\Component\Cache\Marshaller\DefaultMarshaller;
 
 final class FlowFilesystemCacheAdapterTest extends TestCase
 {
@@ -240,7 +241,8 @@ public function test_save_with_zero_lifetime_writes_zero_expiry_header() : void
 
     public function test_save_writes_file_with_three_line_format() : void
     {
-        $adapter = $this->context->adapter();
+        $marshaller = new DefaultMarshaller(useIgbinarySerialize: false);
+        $adapter = $this->context->adapter(marshaller: $marshaller);
         $item = $adapter->getItem('key1');
         $item->set('value1');
         $item->expiresAfter(600);

src/bridge/symfony/filesystem-cache/tests/Flow/Bridge/Symfony/FilesystemCache/Tests/Unit/FlowFilesystemCacheAdapterTest.php

@@ -38,14 +38,8 @@ public function add(int|float|string $a, int|float|string $b) : int|float
     public function divide(int|float|string $a, int|float|string $b, ?int $scale = null, ?Rounding $rounding = null) : int|float
     {
         try {
-            if ($scale === null && $rounding === null) {
-                $aDecimal = BigDecimal::of((string) $a);
-                $result = $aDecimal->dividedBy(BigDecimal::of((string) $b), $aDecimal->getScale());
-
-                if (!self::hasNonZeroFractionalPart($result)) {
-                    return $result->toInt();
-                }
-            }
+            $aDecimal = BigDecimal::of((string) $a);
+            $effectiveScale = $scale ?? $aDecimal->getScale();
 
             $useNewNaming = \defined('Brick\Math\RoundingMode::Up');
 
@@ -62,7 +56,7 @@ public function divide(int|float|string $a, int|float|string $b, ?int $scale = n
                 default => $useNewNaming ? RoundingMode::Unnecessary : RoundingMode::UNNECESSARY,
             };
 
-            $result = BigDecimal::of((string) $a)->dividedBy(BigDecimal::of((string) $b), $scale, $brickMode);
+            $result = $aDecimal->dividedBy(BigDecimal::of((string) $b), $effectiveScale, $brickMode);
 
             if (!self::hasNonZeroFractionalPart($result)) {
                 return $result->toInt();
@@ -132,10 +126,10 @@ public function subtract(int|float|string $a, int|float|string $b) : int|float
 
     private static function hasNonZeroFractionalPart(BigDecimal $result) : bool
     {
-        if (method_exists($result, 'hasNonZeroFractionalPart')) { // @phpstan-ignore function.alreadyNarrowedType
+        if (\method_exists($result, 'hasNonZeroFractionalPart')) {
             return $result->hasNonZeroFractionalPart();
         }
 
-        return !$result->getFractionalPart()->isZero(); // @phpstan-ignore method.nonObject
+        return !$result->getFractionalPart()->isZero();
     }
 }

src/core/etl/src/Flow/Calculator/Calculator.php

@@ -127,14 +127,16 @@ public function group(Rows $rows, FlowContext $context) : void
                 $valuesHash = $this->hash($values);
 
                 if (!\array_key_exists($valuesHash, $this->groupedTable)) {
-                    $this->groupedTable[$valuesHash] = [
-                        'values' => $values,
-                        'aggregators' => [],
-                    ];
+                    $aggregators = [];
 
                     foreach ($this->aggregations as $aggregator) {
-                        $this->groupedTable[$valuesHash]['aggregators'][] = clone $aggregator;
+                        $aggregators[] = clone $aggregator;
                     }
+
+                    $this->groupedTable[$valuesHash] = [
+                        'values' => $values,
+                        'aggregators' => $aggregators,
+                    ];
                 }
 
                 foreach ($this->groupedTable[$valuesHash]['aggregators'] as $aggregator) {

src/core/etl/src/Flow/ETL/GroupBy.php

@@ -40,7 +40,7 @@ public function __construct(
             ));
         }
 
-        $this->threshold = (int) ($ratio * PHP_INT_MAX);
+        $this->threshold = $ratio >= 1.0 ? PHP_INT_MAX : (int) ($ratio * PHP_INT_MAX);
     }
 
     public function __toString() : string