refactor: unify symfony bundles architecture

Author: norberttech

mago.toml

@@ -21,7 +21,7 @@ includes = [
     # Symfony
     "src/bridge/symfony/filesystem-bundle/src/Flow/Bridge/Symfony/FilesystemBundle/FlowFilesystemBundle.php",
     "src/bridge/symfony/postgresql-bundle/src/Flow/Bridge/Symfony/PostgreSqlBundle/FlowPostgreSqlBundle.php",
-    "src/bridge/symfony/telemetry-bundle/src/Flow/Bridge/Symfony/TelemetryBundle/DependencyInjection/Configuration.php",
+    "src/bridge/symfony/telemetry-bundle/src/Flow/Bridge/Symfony/TelemetryBundle/FlowTelemetryBundle.php",
 ]
 excludes = [
     "src/**/vendor/**",

phpstan.neon

@@ -144,10 +144,10 @@ parameters:
             message: '#Dom\\(CharacterData|HTMLDocument|HTMLElement|Element)#i'
             identifier: class.notFound
         -
-            path: src/bridge/symfony/telemetry-bundle/src/Flow/Bridge/Symfony/TelemetryBundle/DependencyInjection/FlowTelemetryExtension.php
+            path: src/bridge/symfony/telemetry-bundle/src/Flow/Bridge/Symfony/TelemetryBundle/FlowTelemetryBundle.php
             identifier: offsetAccess.nonOffsetAccessible
         -
-            path: src/bridge/symfony/telemetry-bundle/src/Flow/Bridge/Symfony/TelemetryBundle/DependencyInjection/FlowTelemetryExtension.php
+            path: src/bridge/symfony/telemetry-bundle/src/Flow/Bridge/Symfony/TelemetryBundle/FlowTelemetryBundle.php
             identifier: cast.string
         -
             path: src/bridge/symfony/filesystem-cache/src/Flow/Bridge/Symfony/FilesystemCache/FlowFilesystemCacheAdapter.php

src/bridge/symfony/filesystem-bundle/src/Flow/Bridge/Symfony/FilesystemBundle/Command/FstabResolver.php

@@ -96,6 +96,8 @@ private static function normalizePath(string $path): string
             $normalized[] = $part;
         }
 
-        return ($isAbsolute ? '/' : '') . implode('/', array_map(static fn (mixed $s): string => (string) $s, $normalized));
+        return (
+            ($isAbsolute ? '/' : '') . implode('/', array_map(static fn(mixed $s): string => (string) $s, $normalized))
+        );
     }
 }

src/bridge/symfony/filesystem-bundle/src/Flow/Bridge/Symfony/FilesystemBundle/DependencyInjection/Compiler/BuildFstabsPass.php

@@ -94,11 +94,7 @@ public function process(ContainerBuilder $container): void
             $telemetryRaw = $fstabConfig['telemetry'] ?? [];
             $telemetryArray = is_array($telemetryRaw) ? $telemetryRaw : [];
 
-            $telemetryReference = $this->buildTelemetryConfigReference(
-                $container,
-                $fstabNameStr,
-                $telemetryArray,
-            );
+            $telemetryReference = $this->buildTelemetryConfigReference($container, $fstabNameStr, $telemetryArray);
 
             $definition = new Definition(FilesystemTable::class);
             $definition->setFactory([FstabBuilder::class, 'build']);
@@ -192,7 +188,12 @@ private function collectAvailableTypes(ContainerBuilder $container): array
         foreach ($container->findTaggedServiceIds(RegisterFilesystemFactoriesPass::TAG) as $serviceId => $tags) {
             // @mago-expect analysis:mixed-assignment
             foreach ($tags as $tag) {
-                if (is_array($tag) && array_key_exists('type', $tag) && is_string($tag['type']) && $tag['type'] !== '') {
+                if (
+                    is_array($tag)
+                    && array_key_exists('type', $tag)
+                    && is_string($tag['type'])
+                    && $tag['type'] !== ''
+                ) {
                     $types[$tag['type']] = $serviceId;
                 }
             }

src/bridge/symfony/filesystem-bundle/src/Flow/Bridge/Symfony/FilesystemBundle/DependencyInjection/Compiler/RegisterFilesystemFactoriesPass.php

@@ -32,7 +32,12 @@ public function process(ContainerBuilder $container): void
         foreach ($container->findTaggedServiceIds(self::TAG) as $serviceId => $tags) {
             // @mago-expect analysis:mixed-assignment
             foreach ($tags as $tag) {
-                if (!is_array($tag) || !array_key_exists('type', $tag) || !is_string($tag['type']) || $tag['type'] === '') {
+                if (
+                    !is_array($tag)
+                    || !array_key_exists('type', $tag)
+                    || !is_string($tag['type'])
+                    || $tag['type'] === ''
+                ) {
                     throw new LogicException(sprintf(
                         'Service "%s" is tagged with "%s" but is missing a non-empty "type" attribute.',
                         $serviceId,

src/bridge/symfony/filesystem-bundle/tests/Flow/Bridge/Symfony/FilesystemBundle/Tests/Integration/CachePoolRegistrationTest.php

@@ -74,7 +74,9 @@ public function test_cache_pool_with_marshaller_service_id_injects_marshaller():
 
         static::assertSame(
             $container->get('test.marshaller'),
-            (new ReflectionObject($adapter))->getProperty('marshaller')->getValue($adapter),
+            (new ReflectionObject($adapter))
+                ->getProperty('marshaller')
+                ->getValue($adapter),
         );
     }
 

src/bridge/symfony/postgresql-bundle/src/Flow/Bridge/Symfony/PostgreSqlBundle/Command/DiffCommand.php

@@ -67,7 +67,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             return Command::FAILURE;
         }
 
-        $directory = $configuration->migrationsDirectory . '/' . (string) $version . ($name !== null ? '_' . $name : '');
+        $directory =
+            $configuration->migrationsDirectory . '/' . (string) $version . ($name !== null ? '_' . $name : '');
         $realDirectory = realpath($directory) ?: $directory;
         $migrationPath = $realDirectory . '/' . $configuration->migrationFileName;
         $rollbackPath = $realDirectory . '/' . $configuration->rollbackFileName;

src/bridge/symfony/postgresql-bundle/src/Flow/Bridge/Symfony/PostgreSqlBundle/Command/GenerateCommand.php

@@ -54,7 +54,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         $version = $generator->generateDataMigration($name);
 
-        $directory = $configuration->migrationsDirectory . '/' . (string) $version . ($name !== null ? '_' . $name : '');
+        $directory =
+            $configuration->migrationsDirectory . '/' . (string) $version . ($name !== null ? '_' . $name : '');
         $realDirectory = realpath($directory) ?: $directory;
 
         $io->success(sprintf('Generated migration: %s', $version));

src/bridge/symfony/postgresql-cache/src/Flow/Bridge/Symfony/PostgreSQLCache/FlowPostgreSqlCacheAdapter.php

@@ -232,7 +232,10 @@ protected function doFetch(array $ids): iterable
 
             $rowData = is_string($row[$this->dataCol] ?? null)
                 ? $row[$this->dataCol]
-                : throw CacheException::unexpectedRowShape($this->dataCol, get_debug_type($row[$this->dataCol] ?? null));
+                : throw CacheException::unexpectedRowShape(
+                    $this->dataCol,
+                    get_debug_type($row[$this->dataCol] ?? null),
+                );
 
             yield $rowId => $this->marshaller->unmarshall($rowData);
         }

src/bridge/symfony/postgresql-messenger/src/Flow/Bridge/Symfony/PostgreSQLMessenger/Connection.php

@@ -117,9 +117,11 @@ public function get(): ?array
 
             $rowId = is_int($row['id'] ?? null)
                 ? (int) $row['id']
-                : (is_string($row['id'] ?? null)
-                    ? $row['id']
-                    : throw TransportException::unexpectedRowShape('id', get_debug_type($row['id'] ?? null)));
+                : (
+                    is_string($row['id'] ?? null)
+                        ? $row['id']
+                        : throw TransportException::unexpectedRowShape('id', get_debug_type($row['id'] ?? null))
+                );
 
             $client->execute(
                 update()
@@ -207,9 +209,11 @@ public function send(string $body, array $headers, int $delay = 0): string
 
         $rowId = is_int($row['id'] ?? null)
             ? $row['id']
-            : (is_string($row['id'] ?? null)
-                ? $row['id']
-                : throw TransportException::unexpectedRowShape('id', get_debug_type($row['id'] ?? null)));
+            : (
+                is_string($row['id'] ?? null)
+                    ? $row['id']
+                    : throw TransportException::unexpectedRowShape('id', get_debug_type($row['id'] ?? null))
+            );
 
         return (string) $rowId;
     }