Skip to content

Commit 5328aa3

Browse files
committed
refactor: cover phpunit postgresql bridge with mago
1 parent 226ea6c commit 5328aa3

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

Justfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ analyze-mago *args:
7979
src/bridge/filesystem/async-aws \
8080
src/bridge/filesystem/azure \
8181
src/bridge/monolog/http \
82-
src/bridge/monolog/telemetry
82+
src/bridge/monolog/telemetry \
83+
src/bridge/phpunit/postgresql
8384

8485
# Auto-fix code style (Mago format + lint --fix) and GitHub Actions findings (zizmor --fix).
8586
fix:

src/bridge/phpunit/postgresql/src/Flow/Bridge/PHPUnit/PostgreSQL/Subscriber/TestPreparationStartedSubscriber.php

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,21 +37,24 @@ private static function hasSkipAttribute(Test $test): bool
3737

3838
$reflectionClass = new ReflectionClass($test->className());
3939

40-
if ($reflectionClass->getAttributes(SkipTransactionRollback::class)) {
40+
if ($reflectionClass->getAttributes(SkipTransactionRollback::class) !== []) {
4141
return true;
4242
}
4343

4444
if (
4545
$reflectionClass->hasMethod($test->methodName())
46-
&& $reflectionClass->getMethod($test->methodName())->getAttributes(SkipTransactionRollback::class)
46+
&& $reflectionClass->getMethod($test->methodName())->getAttributes(SkipTransactionRollback::class) !== []
4747
) {
4848
return true;
4949
}
5050

51-
while (($reflectionClass = $reflectionClass->getParentClass()) && $reflectionClass->name !== TestCase::class) {
52-
if ($reflectionClass->getAttributes(SkipTransactionRollback::class)) {
51+
$parent = $reflectionClass->getParentClass();
52+
53+
while ($parent !== false && $parent->name !== TestCase::class) {
54+
if ($parent->getAttributes(SkipTransactionRollback::class) !== []) {
5355
return true;
5456
}
57+
$parent = $parent->getParentClass();
5558
}
5659

5760
return false;

0 commit comments

Comments
 (0)