Rework rename_transliterate to use Symfony String

Author: stloyd

src/core/etl/src/Flow/ETL/DSL/functions.php

@@ -360,12 +360,6 @@ function rename_replace(string $search, string $replace) : Transformer\Rename\Re
     return new Transformer\Rename\RenameReplaceEntryStrategy($search, $replace);
 }
 
-#[DocumentationDSL(module: Module::CORE, type: DSLType::TRANSFORMER)]
-function rename_transliterate() : Transformer\Rename\RenameTransliterateEntryStrategy
-{
-    return new Transformer\Rename\RenameTransliterateEntryStrategy();
-}
-
 #[DocumentationDSL(module: Module::CORE, type: DSLType::ENTRY)]
 function bool_entry(string $name, ?bool $value, ?Schema\Metadata $metadata = null) : Entry\BooleanEntry
 {

src/core/etl/src/Flow/ETL/Transformer/Rename/RenameCaseEntryStrategy.php

@@ -4,25 +4,42 @@
 
 namespace Flow\ETL\Transformer\Rename;
 
+use function Symfony\Component\String\u;
 use Flow\ETL\{FlowContext, Row, Row\Entry};
+use Symfony\Component\String\Slugger\AsciiSlugger;
 
-final readonly class RenameCaseEntryStrategy implements RenameEntryStrategy
+final class RenameCaseEntryStrategy implements RenameEntryStrategy
 {
+    private ?AsciiSlugger $slugger = null;
+
     public function __construct(
-        private Style $style,
+        private readonly Style $style,
     ) {
     }
 
     public function rename(Row $row, Entry $entry, FlowContext $context) : Row
     {
         return match ($this->style) {
+            Style::ASCII => $row->rename($entry->name(), u($entry->name())->ascii()->toString()),
+            Style::CAMEL => $row->rename($entry->name(), u($entry->name())->camel()->toString()),
             Style::LOWER => $row->rename($entry->name(), \mb_strtolower($entry->name())),
+            Style::SLUG => $row->rename($entry->name(), $this->slug($entry->name())),
+            Style::TITLE => $row->rename($entry->name(), u($entry->name())->title()->toString()),
             Style::UPPER => $row->rename($entry->name(), \mb_strtoupper($entry->name())),
             Style::UCFIRST => $row->rename($entry->name(), $this->ucFirst($entry->name())),
             Style::UCWORDS => $row->rename($entry->name(), $this->ucWords($entry->name())),
         };
     }
 
+    private function slug(string $string) : string
+    {
+        if (null === $this->slugger) {
+            $this->slugger = new AsciiSlugger();
+        }
+
+        return $this->slugger->slug($string)->toString();
+    }
+
     private function ucFirst(string $string) : string
     {
         // Available from PHP 8.4+

src/core/etl/src/Flow/ETL/Transformer/Rename/RenameTransliterateEntryStrategy.php

@@ -6,7 +6,11 @@
 
 enum Style : string
 {
+    case ASCII = 'ASCII';
+    case CAMEL = 'CAMEL';
     case LOWER = 'LOWER';
+    case SLUG = 'SLUG';
+    case TITLE = 'TITLE';
     case UCFIRST = 'UCFIRST';
     case UCWORDS = 'UCWORDS';
     case UPPER = 'UPPER';

src/core/etl/src/Flow/ETL/Transformer/Rename/Style.php

@@ -5,7 +5,7 @@
 namespace Flow\ETL\Tests\Integration\DataFrame;
 
 use function Flow\ETL\DSL\{bool_entry, df, from_rows, int_entry, json_entry, ref, str_entry};
-use function Flow\ETL\DSL\{rename_replace, rename_style, rename_transliterate, row, rows};
+use function Flow\ETL\DSL\{rename_replace, rename_style, row, rows};
 use Flow\ETL\{Function\StyleConverter\StringStyles,
     Transformer\Rename\Style};
 use Flow\ETL\Tests\FlowIntegrationTestCase;
@@ -83,6 +83,60 @@ public function test_rename_all_lower_case_i18n() : void
         );
     }
 
+    public function test_rename_all_to_ascii() : void
+    {
+        $rows = rows(row(int_entry('ÓSMY', 8)), row(int_entry('DZIEWIĄTY', 9)));
+
+        $ds = df()
+            ->read(from_rows($rows))
+            ->renameEach(rename_style(Style::ASCII))
+            ->renameEach(rename_style(Style::LOWER))
+            ->getEachAsArray();
+
+        self::assertEquals(
+            [
+                ['osmy' => 8],
+                ['dziewiaty' => 9],
+            ],
+            \iterator_to_array($ds)
+        );
+    }
+
+    public function test_rename_all_to_camel() : void
+    {
+        $rows = rows(row(int_entry('ósmy i dziewiąty', 89)));
+
+        $ds = df()
+            ->read(from_rows($rows))
+            ->renameEach(rename_style(Style::CAMEL))
+            ->getEachAsArray();
+
+        self::assertEquals(
+            [
+                ['Ósmy i dziewiąty' => 89],
+            ],
+            \iterator_to_array($ds)
+        );
+    }
+
+    public function test_rename_all_to_slug() : void
+    {
+        $rows = rows(row(int_entry('ÓSMY I DZIEWIĄTY', 89)));
+
+        $ds = df()
+            ->read(from_rows($rows))
+            ->renameEach(rename_style(Style::SLUG))
+            ->renameEach(rename_style(Style::LOWER))
+            ->getEachAsArray();
+
+        self::assertEquals(
+            [
+                ['osmy-i-dziewiaty' => 89],
+            ],
+            \iterator_to_array($ds)
+        );
+    }
+
     public function test_rename_all_to_snake_case() : void
     {
         $rows = rows(row(int_entry('id', 1), str_entry('UserName', 'name'), bool_entry('isActive', true)), row(int_entry('id', 2), str_entry('UserName', 'name'), bool_entry('isActive', false)));
@@ -102,20 +156,18 @@ public function test_rename_all_to_snake_case() : void
         );
     }
 
-    public function test_rename_all_transliterate() : void
+    public function test_rename_all_to_title() : void
     {
-        $rows = rows(row(int_entry('ÓSMY', 8)), row(int_entry('DZIEWIĄTY', 9)));
+        $rows = rows(row(int_entry('ósmy i dziewiąty', 89)));
 
         $ds = df()
             ->read(from_rows($rows))
-            ->renameEach(rename_transliterate())
-            ->renameEach(rename_style(Style::LOWER))
+            ->renameEach(rename_style(Style::TITLE))
             ->getEachAsArray();
 
         self::assertEquals(
             [
-                ['osmy' => 8],
-                ['dziewiaty' => 9],
+                ['Ósmy i dziewiąty' => 89],
             ],
             \iterator_to_array($ds)
         );