Skip to content

Commit 616d02f

Browse files
committed
Mark CSV failing tests on windows as skipped
1 parent 3485abf commit 616d02f

2 files changed

Lines changed: 14 additions & 1 deletion

File tree

src/adapter/etl-adapter-csv/tests/Flow/ETL/Adapter/CSV/Tests/Integration/CSVExtractorTest.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,12 @@
1111
use Flow\ETL\{Config, Row, Rows, Tests\FlowTestCase};
1212
use Flow\ETL\Extractor\Signal;
1313
use Flow\Filesystem\Path;
14+
use Flow\Filesystem\Tests\OperatingSystem;
1415

1516
final class CSVExtractorTest extends FlowTestCase
1617
{
18+
use OperatingSystem;
19+
1720
public function test_bom_removal_utf16_be() : void
1821
{
1922
$extractor = from_csv(
@@ -414,6 +417,10 @@ public function test_extracting_csv_with_more_than_1000_characters_per_line_with
414417

415418
public function test_extracting_csv_with_multiline_strings() : void
416419
{
420+
if ($this->isWindows()) {
421+
$this->markTestAsSkipped("This test is failing on windows due to different new line characters.");
422+
}
423+
417424
$extractor = from_csv(
418425
__DIR__ . '/../Fixtures/multiline_strings.csv'
419426
);

src/adapter/etl-adapter-csv/tests/Flow/ETL/Adapter/CSV/Tests/Integration/CSVLineReaderTest.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,13 @@
77
use Flow\ETL\Adapter\CSV\CSVLineReader;
88
use Flow\ETL\Tests\FlowTestCase;
99
use Flow\Filesystem\Path;
10-
10+
use Flow\Filesystem\Tests\OperatingSystem;
1111
use Flow\Filesystem\Stream\NativeLocalSourceStream;
1212

1313
final class CSVLineReaderTest extends FlowTestCase
1414
{
15+
use OperatingSystem;
16+
1517
public function test_memory_usage_with_large_multiline_csv() : void
1618
{
1719
$path = __DIR__ . '/../Fixtures/large_multiline_csv.csv';
@@ -50,6 +52,10 @@ public function test_reading_csv_with_custom_character_limit() : void
5052

5153
public function test_reading_csv_with_different_enclosures() : void
5254
{
55+
if ($this->isWindows()) {
56+
$this->markTestAsSkipped("This test is failing on windows due to different new line characters.");
57+
}
58+
5359
$path = __DIR__ . '/../Fixtures/single_quotes_csv.csv';
5460
$stream = NativeLocalSourceStream::open(Path::realpath($path));
5561

0 commit comments

Comments
 (0)