fix: failing static analysis

Author: norberttech

.github/workflows/job-tests.yml

@@ -43,6 +43,7 @@ jobs:
       localstack:
         image: localstack/localstack:latest
         env:
+          LOCALSTACK_AUTH_TOKEN: ${{ secrets.LOCALSTACK_AUTH_TOKEN }}
           SERVICES: s3
           AWS_ACCESS_KEY_ID: test
           AWS_SECRET_ACCESS_KEY: test

phpstan.neon

@@ -138,6 +138,12 @@ parameters:
         -
             path: src/bridge/symfony/telemetry-bundle/src/Flow/Bridge/Symfony/TelemetryBundle/Instrumentation/Doctrine/DBAL/TracingMiddleware.php
             identifier: return.type
+        -
+            path: src/lib/parquet/src/Flow/Parquet/Dremel/DremelShredder.php
+            identifier: argument.type
+        -
+            path: src/lib/parquet/src/Flow/Parquet/Dremel/DremelShredder.php
+            identifier: assign.propertyType
 
 includes:
     - tools/phpstan/vendor/spaze/phpstan-disallowed-calls/extension.neon

src/adapter/etl-adapter-elasticsearch/src/Flow/ETL/Adapter/Elasticsearch/ElasticsearchPHP/ElasticsearchExtractor.php

@@ -116,7 +116,7 @@ public function extract(FlowContext $context) : \Generator
                     break;
                 }
 
-                if ($nextPageParams->asArray()['from'] + $nextPageParams->asArray()['size'] > $results->total()) {
+                if ($nextPageParams->asArray()['from'] + $nextPageParams->asArray()['size'] > $results->total()) { // @phpstan-ignore binaryOp.invalid
                     $nextPageParams = $nextPageParams->set('size', $results->total() - $fetched);
                 }
 

src/adapter/etl-adapter-postgresql/tests/Flow/ETL/Adapter/PostgreSql/Tests/Integration/PostgreSqlLoaderAllTypesIntegrationTest.php

@@ -115,12 +115,12 @@ enum_entry('col_enum', BackedStringEnum::one),
         self::assertEqualsWithDelta(3.14159, $row['col_float'], 0.00001);
         self::assertTrue($row['col_boolean']);
         self::assertSame('2024-01-15', $row['col_date'] instanceof \DateTimeInterface ? $row['col_date']->format('Y-m-d') : $row['col_date']);
-        self::assertStringStartsWith('2024-01-15', $row['col_datetime'] instanceof \DateTimeInterface ? $row['col_datetime']->format('Y-m-d H:i:s') : $row['col_datetime']);
+        self::assertStringStartsWith('2024-01-15', $row['col_datetime'] instanceof \DateTimeInterface ? $row['col_datetime']->format('Y-m-d H:i:s') : $row['col_datetime']); // @phpstan-ignore argument.type
         self::assertSame('10:30:15', $row['col_time'] instanceof \DateInterval ? \sprintf('%02d:%02d:%02d', $row['col_time']->h, $row['col_time']->i, $row['col_time']->s) : $row['col_time']);
         self::assertSame($uuid, $row['col_uuid']);
         self::assertEquals(['key' => 'value', 'number' => 123], \is_string($row['col_json']) ? \json_decode($row['col_json'], true) : $row['col_json']);
-        self::assertStringContainsString('<root><item>test</item></root>', $row['col_xml']);
-        self::assertStringContainsString('<item id="elem">element</item>', $row['col_xml_element']);
+        self::assertStringContainsString('<root><item>test</item></root>', $row['col_xml']); // @phpstan-ignore argument.type
+        self::assertStringContainsString('<item id="elem">element</item>', $row['col_xml_element']); // @phpstan-ignore argument.type
         self::assertSame('<p>HTML content</p>', $row['col_html']);
         self::assertSame('<span>element</span>', $row['col_html_element']);
         self::assertSame('one', $row['col_enum']);

src/core/etl/src/Flow/ETL/GroupBy.php

@@ -71,7 +71,7 @@ public function group(Rows $rows, FlowContext $context) : void
                 }
             }
 
-            $this->pivotColumns = \array_values(\array_filter(\array_unique($this->pivotColumns)));
+            $this->pivotColumns = \array_values(\array_filter(\array_unique($this->pivotColumns))); // @phpstan-ignore argument.type
 
             foreach ($rows as $row) {
                 $values = [];

src/core/etl/src/Flow/ETL/Rows.php

@@ -602,7 +602,7 @@ public function partitionBy(string|Reference $reference, string|Reference ...$re
                 $partitions[$ref->name()][] = Partition::valueFromRow($ref, $row);
             }
 
-            $partitions[$ref->name()] = \array_values(\array_unique($partitions[$ref->name()]));
+            $partitions[$ref->name()] = \array_values(\array_unique($partitions[$ref->name()])); // @phpstan-ignore argument.type
         }
 
         /** @var array<Rows> $partitionedRows */

src/core/etl/tests/Flow/ETL/Tests/Integration/DataFrame/BatchByTest.php

@@ -69,7 +69,7 @@ public function test_batch_by_preserves_referential_integrity() : void
             ]))
             ->batchBy('order_id')
             ->run(callback: static function ($rows) use (&$batches) : void {
-                $orderIds = \array_unique(\array_column($rows->toArray(), 'order_id'));
+                $orderIds = \array_unique(\array_column($rows->toArray(), 'order_id')); // @phpstan-ignore argument.type
                 $batches[] = $orderIds;
             });
 

src/lib/azure-sdk/src/Flow/Azure/SDK/AuthorizationFactory/SharedKeyFactory.php

@@ -121,7 +121,8 @@ private function computeSignature(array $headers, string $url, array $queryParam
         $lowercaseHeaders = array_change_key_case($headers);
 
         foreach ($includedHeaders as $header) {
-            $stringToSign[] = \array_key_exists($header, $lowercaseHeaders) ? $lowercaseHeaders[$header] : null;
+            $headerValue = \array_key_exists($header, $lowercaseHeaders) ? $lowercaseHeaders[$header] : null;
+            $stringToSign[] = \is_string($headerValue) ? $headerValue : '';
         }
 
         if (count($canonicalizedHeaders) > 0) {

src/lib/azure-sdk/src/Flow/Azure/SDK/BlobService.php

@@ -445,7 +445,7 @@ public function listBlobs(ListBlobOptions $options = new ListBlobOptions()) : \G
             }
         }
 
-        if ($normalized['NextMarker'] !== null) {
+        if (\is_string($normalized['NextMarker'])) {
             yield from $this->listBlobs($options->withMarker($normalized['NextMarker']));
         }
     }

src/tools/documentation/src/Flow/Documentation/Manifest.php

@@ -31,6 +31,8 @@ static function (mixed $package) : Package {
                 $package['name'] = type_string()->assert($package['name']);
                 $package['path'] = type_string()->assert($package['path']);
 
+                $package['type'] = type_string()->assert($package['type']);
+
                 return new Package($package['name'], $package['path'], Type::from($package['type']));
             },
             $data['packages']