fix: codecov configuration

allow to upload partial coverages from different workflows using flags

Author: norberttech

.codecov.yaml

@@ -1,5 +1,14 @@
+codecov:
+  notify:
+    after_n_builds: 5
+
 comment:
   layout: "condensed_header, diff, components"
+  after_n_builds: 5
+
+flag_management:
+  default_rules:
+    carryforward: true
 
 component_management:
   individual_components:

.github/workflows/job-arrow-extension.yml

@@ -82,3 +82,11 @@ jobs:
 
       - name: Run Parquet Integration Tests with Arrow
         run: composer test:lib:parquet
+
+      - name: Upload to Codecov
+        if: ${{ !cancelled() && matrix.php == '8.3' && matrix.os == 'ubuntu-latest' }}
+        uses: codecov/codecov-action@v5
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          directory: ./var/phpunit/coverage/clover
+          flags: arrow-extension

.github/workflows/job-extension-tests.yml

@@ -1,5 +1,8 @@
 on:
   workflow_call:
+    secrets:
+      CODECOV_TOKEN:
+        required: false
 
 jobs:
   extension-tests:
@@ -44,4 +47,12 @@ jobs:
         run: "composer test:lib:parquet -- --group zstd-extension"
 
       - name: "Test Snappy"
-        run: "composer test:lib:parquet -- --group snappy-extension"
+        run: "composer test:lib:parquet -- --group snappy-extension"
+
+      - name: Upload to Codecov
+        if: ${{ !cancelled() && matrix.php-version == '8.3' }}
+        uses: codecov/codecov-action@v5
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          directory: ./var/phpunit/coverage/clover
+          flags: extension-tests

.github/workflows/test-suite.yml

@@ -40,6 +40,7 @@ jobs:
 
   extension-tests:
     uses: ./.github/workflows/job-extension-tests.yml
+    secrets: inherit
 
   pg-query-extension:
     uses: ./.github/workflows/job-pg-query-extension.yml

src/lib/parquet/tests/Flow/Parquet/Tests/Unit/Engine/PhpParquetEngineTest.php

@@ -0,0 +1,42 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Flow\Parquet\Tests\Unit\Engine;
+
+use Flow\Parquet\Engine\PhpParquetEngine;
+use Flow\Parquet\Exception\RuntimeException;
+use PHPUnit\Framework\TestCase;
+
+final class PhpParquetEngineTest extends TestCase
+{
+    public function test_close_write_throws_when_writer_not_open() : void
+    {
+        $engine = new PhpParquetEngine();
+
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessage('Writer is not open');
+
+        $engine->closeWrite();
+    }
+
+    public function test_write_batch_throws_when_writer_not_open() : void
+    {
+        $engine = new PhpParquetEngine();
+
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessage('Writer is not open');
+
+        $engine->writeBatch([['col' => 'value']]);
+    }
+
+    public function test_write_row_throws_when_writer_not_open() : void
+    {
+        $engine = new PhpParquetEngine();
+
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessage('Writer is not open');
+
+        $engine->writeRow(['col' => 'value']);
+    }
+}

src/lib/parquet/tests/Flow/Parquet/Tests/Unit/ReaderTest.php

@@ -0,0 +1,62 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Flow\Parquet\Tests\Unit;
+
+use function Flow\Filesystem\DSL\path_real;
+use Flow\Filesystem\Stream\NativeLocalSourceStream;
+use Flow\Parquet\Engine\{ArrowParquetEngine, PhpParquetEngine};
+use Flow\Parquet\Exception\RuntimeException;
+use Flow\Parquet\Reader;
+
+use PHPUnit\Framework\TestCase;
+
+final class ReaderTest extends TestCase
+{
+    public function test_arrow_factory_creates_reader_with_arrow_engine() : void
+    {
+        if (!\extension_loaded('arrow')) {
+            $this->expectException(RuntimeException::class);
+            Reader::arrow();
+
+            return;
+        }
+
+        $reader = Reader::arrow();
+
+        $reflection = new \ReflectionClass($reader);
+        $engine = $reflection->getProperty('engine')->getValue($reader);
+
+        self::assertInstanceOf(ArrowParquetEngine::class, $engine);
+    }
+
+    public function test_php_factory_creates_reader_with_php_engine() : void
+    {
+        $reader = Reader::php();
+
+        $reflection = new \ReflectionClass($reader);
+        $engine = $reflection->getProperty('engine')->getValue($reader);
+
+        self::assertInstanceOf(PhpParquetEngine::class, $engine);
+    }
+
+    public function test_read_returns_parquet_file() : void
+    {
+        $reader = Reader::php();
+
+        $parquetFile = $reader->read(__DIR__ . '/../Integration/IO/Fixtures/primitives.parquet');
+
+        self::assertGreaterThan(0, $parquetFile->metadata()->rowsNumber());
+    }
+
+    public function test_read_stream_returns_parquet_file() : void
+    {
+        $reader = Reader::php();
+        $stream = NativeLocalSourceStream::open(path_real(__DIR__ . '/../Integration/IO/Fixtures/primitives.parquet'));
+
+        $parquetFile = $reader->readStream($stream);
+
+        self::assertGreaterThan(0, $parquetFile->metadata()->rowsNumber());
+    }
+}

src/lib/parquet/tests/Flow/Parquet/Tests/Unit/WriterTest.php

@@ -0,0 +1,34 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Flow\Parquet\Tests\Unit;
+
+use Flow\Parquet\Engine\PhpParquetEngine;
+use Flow\Parquet\Exception\RuntimeException;
+use Flow\Parquet\Writer;
+use PHPUnit\Framework\TestCase;
+
+final class WriterTest extends TestCase
+{
+    public function test_arrow_factory_throws_when_extension_not_loaded() : void
+    {
+        if (\extension_loaded('arrow')) {
+            self::markTestSkipped('This test requires the arrow extension to NOT be loaded');
+        }
+
+        $this->expectException(RuntimeException::class);
+
+        Writer::arrow();
+    }
+
+    public function test_php_factory_creates_writer_with_php_engine() : void
+    {
+        $writer = Writer::php();
+
+        $reflection = new \ReflectionClass($writer);
+        $engine = $reflection->getProperty('engine')->getValue($writer);
+
+        self::assertInstanceOf(PhpParquetEngine::class, $engine);
+    }
+}

web/landing/tests/Flow/Website/Tests/Functional/EndToEndTestCase.php

@@ -124,19 +124,19 @@ protected static function getKernelClass() : string
      */
     protected static function navigateWithRetry(string $url, int $maxRetries = 3) : Client
     {
+        $client = static::createE2EClient();
         $lastException = null;
 
         for ($attempt = 1; $attempt <= $maxRetries; $attempt++) {
             try {
-                $client = static::createE2EClient();
                 $client->request('GET', $url);
 
                 return $client;
             } catch (WebDriverException $e) {
                 $lastException = $e;
 
-                if ($attempt === $maxRetries) {
-                    throw $e;
+                if ($attempt < $maxRetries) {
+                    $client->restart();
                 }
             }
         }