Removed tests that are touching FS from Path unit tests

Author: norberttech

src/lib/filesystem/tests/Flow/Filesystem/Tests/Unit/Path/UnixPathTest.php

@@ -5,7 +5,7 @@
 namespace Flow\Filesystem\Tests\Unit\Path;
 
 use function Flow\Filesystem\DSL\{partition};
-use Flow\Filesystem\Exception\{InvalidArgumentException, RuntimeException};
+use Flow\Filesystem\Exception\{InvalidArgumentException};
 use Flow\Filesystem\Path\{Options, UnixPath};
 use Flow\Filesystem\Tests\Unit\PathTestCase;
 
@@ -195,17 +195,6 @@ public function test_fnmatch_with_hidden_files() : void
         self::assertTrue($pattern->matches($hidden));
     }
 
-    public function test_home_path_resolution() : void
-    {
-        if (!\is_string($homeEnv = \getenv('HOME'))) {
-            self::markTestSkipped('HOME environment variable not available');
-        }
-
-        $path = new UnixPath('~/test.txt');
-        self::assertStringStartsWith($homeEnv, $path->path());
-        self::assertStringEndsWith('/test.txt', $path->path());
-    }
-
     public function test_is_equal() : void
     {
         $path1 = new UnixPath('/path/to/file.txt');
@@ -432,54 +421,6 @@ public function test_randomize_without_extension() : void
         self::assertNotEquals($path->path(), $randomized->path());
     }
 
-    public function test_realpath_home_resolution_error_no_posix() : void
-    {
-        if (\function_exists('posix_getpwuid') && \function_exists('posix_getuid')) {
-            self::markTestSkipped('POSIX functions are available');
-        }
-
-        $originalHome = \getenv('HOME');
-        \putenv('HOME=');
-
-        try {
-            $this->expectException(RuntimeException::class);
-            $this->expectExceptionMessage('Resolving homedir is not yet supported at OS');
-
-            UnixPath::realpath('~/test.txt');
-        } finally {
-            if ($originalHome !== false) {
-                \putenv('HOME=' . $originalHome);
-            }
-        }
-    }
-
-    public function test_realpath_home_resolution_with_posix() : void
-    {
-        if (!\function_exists('posix_getpwuid') || !\function_exists('posix_getuid')) {
-            self::markTestSkipped('POSIX functions not available');
-        }
-
-        $originalHome = \getenv('HOME');
-        \putenv('HOME=');
-
-        try {
-            $userData = \posix_getpwuid(\posix_getuid());
-
-            if (\is_array($userData) && \array_key_exists('dir', $userData) && \is_string($userData['dir'])) {
-                $path = UnixPath::realpath('~/test.txt');
-                // Due to implementation details, this might resolve to /test.txt
-                // when HOME is not set properly
-                self::assertStringEndsWith('/test.txt', $path->path());
-            } else {
-                self::markTestSkipped('Unable to get user directory from POSIX');
-            }
-        } finally {
-            if ($originalHome !== false) {
-                \putenv('HOME=' . $originalHome);
-            }
-        }
-    }
-
     public function test_realpath_multiple_parent_navigation() : void
     {
         $path = UnixPath::realpath('/a/b/c/../../d/../e/file.txt');

src/lib/filesystem/tests/Flow/Filesystem/Tests/Unit/Path/WindowsPathTest.php

@@ -5,7 +5,7 @@
 namespace Flow\Filesystem\Tests\Unit\Path;
 
 use function Flow\Filesystem\DSL\{partition};
-use Flow\Filesystem\Exception\{InvalidArgumentException, RuntimeException};
+use Flow\Filesystem\Exception\{InvalidArgumentException};
 use Flow\Filesystem\Path\{Options, WindowsPath};
 use Flow\Filesystem\Tests\Unit\PathTestCase;
 
@@ -492,36 +492,6 @@ public function test_randomize_without_extension() : void
         self::assertNotEquals($path->path(), $randomized->path());
     }
 
-    public function test_realpath_home_resolution_error() : void
-    {
-        $originalUserProfile = \getenv('USERPROFILE');
-        $originalHomeDrive = \getenv('HOMEDRIVE');
-        $originalHomePath = \getenv('HOMEPATH');
-
-        \putenv('USERPROFILE=');
-        \putenv('HOMEDRIVE=');
-        \putenv('HOMEPATH=');
-
-        try {
-            $this->expectException(RuntimeException::class);
-            $this->expectExceptionMessage('Cannot resolve home directory on Windows');
-
-            WindowsPath::realpath('~/test.txt');
-        } finally {
-            if ($originalUserProfile !== false) {
-                \putenv('USERPROFILE=' . $originalUserProfile);
-            }
-
-            if ($originalHomeDrive !== false) {
-                \putenv('HOMEDRIVE=' . $originalHomeDrive);
-            }
-
-            if ($originalHomePath !== false) {
-                \putenv('HOMEPATH=' . $originalHomePath);
-            }
-        }
-    }
-
     public function test_realpath_with_absolute_path() : void
     {
         $path = WindowsPath::realpath('C:/absolute/path/file.txt');
@@ -535,12 +505,6 @@ public function test_realpath_with_non_file_scheme() : void
         self::assertEquals('s3://bucket/key.txt', $path->uri());
     }
 
-    public function test_realpath_with_unc_path() : void
-    {
-        $path = WindowsPath::realpath('\\\\server\\share\\file.txt');
-        self::assertEquals('/server/share/file.txt', $path->path());
-    }
-
     public function test_root_directory_name_with_drive() : void
     {
         $path = new WindowsPath('C:/folder/file.txt');
@@ -571,28 +535,28 @@ public function test_root_partition_edge_case() : void
         self::assertEquals('file://group=a/file.txt', $partitioned->uri());
     }
 
-    public function test_set_extension_with_root_file() : void
+    public function test_set_extension_edge_case() : void
     {
-        $path = new WindowsPath('/file');
+        $path = new WindowsPath('file');
         $newPath = $path->setExtension('txt');
 
         self::assertEquals('//file.txt', $newPath->path());
     }
 
-    public function test_set_extension_without_existing_extension() : void
+    public function test_set_extension_with_root_file() : void
     {
-        $path = new WindowsPath('/path/to/file');
+        $path = new WindowsPath('/file');
         $newPath = $path->setExtension('txt');
 
-        self::assertEquals('/path/to/file.txt', $newPath->path());
+        self::assertEquals('//file.txt', $newPath->path());
     }
 
-    public function test_set_extension_edge_case() : void
+    public function test_set_extension_without_existing_extension() : void
     {
-        $path = new WindowsPath('file');
+        $path = new WindowsPath('/path/to/file');
         $newPath = $path->setExtension('txt');
 
-        self::assertEquals('//file.txt', $newPath->path());
+        self::assertEquals('/path/to/file.txt', $newPath->path());
     }
 
     public function test_skip_directories() : void