Prevent fatal error when extracted columns don't match headers amount

Author: stloyd

src/adapter/etl-adapter-google-sheet/tests/Flow/ETL/Adapter/GoogleSheet/Tests/GoogleSheetsContext.php

@@ -0,0 +1,47 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Flow\ETL\Adapter\GoogleSheet\Tests;
+
+use Google\Client as GoogleClient;
+use Google\Service\Sheets;
+use GuzzleHttp\{Client as HttpClient, HandlerStack};
+use GuzzleHttp\Handler\MockHandler;
+use GuzzleHttp\Psr7\Response;
+
+final readonly class GoogleSheetsContext
+{
+    private GoogleClient $client;
+
+    public function __construct()
+    {
+        $this->client = new GoogleClient();
+    }
+
+    public function sheets(string $fixtureFile) : Sheets
+    {
+        $this->client->setHttpClient($this->createHttpClient($fixtureFile));
+
+        return new Sheets($this->client);
+    }
+
+    private function createHttpClient(string $fixtureFile) : HttpClient
+    {
+        return new HttpClient(
+            [
+                'handler' => HandlerStack::create(
+                    new MockHandler(
+                        [
+                            new Response(
+                                200,
+                                ['Content-Type' => 'application/json'],
+                                file_get_contents($fixtureFile) ?: throw new \RuntimeException('Failed to read file: ' . $fixtureFile)
+                            ),
+                        ]
+                    )
+                ),
+            ]
+        );
+    }
+}

src/adapter/etl-adapter-google-sheet/tests/Flow/ETL/Adapter/GoogleSheet/Tests/Integration/GoogleSheetExtractorTest.php

@@ -5,24 +5,23 @@
 namespace Flow\ETL\Adapter\GoogleSheet\Tests\Integration;
 
 use function Flow\ETL\DSL\{config, flow_context};
-use Flow\ETL\Adapter\GoogleSheet\{Columns, GoogleSheetExtractor};
+use Flow\ETL\Adapter\GoogleSheet\{Columns, GoogleSheetExtractor, Tests\GoogleSheetsContext};
 use Flow\ETL\Exception\InvalidArgumentException;
 use Flow\ETL\Tests\FlowTestCase;
-use Google\Client as GoogleClient;
-use Google\Service\Sheets;
-use GuzzleHttp\{Client, HandlerStack};
-use GuzzleHttp\Handler\MockHandler;
-use GuzzleHttp\Psr7\{Response};
 
 final class GoogleSheetExtractorTest extends FlowTestCase
 {
-    public function test_extract_with_cut_extra_columns() : void
+    private GoogleSheetsContext $context;
+
+    protected function setUp() : void
     {
-        $client = new GoogleClient();
-        $client->setHttpClient($this->createHttpClient());
+        $this->context = new GoogleSheetsContext();
+    }
 
+    public function test_extract_with_cut_extra_columns() : void
+    {
         $extractor = new GoogleSheetExtractor(
-            new Sheets($client),
+            $this->context->sheets(__DIR__ . '/../Fixtures/extra-columns.json'),
             '1234567890',
             new Columns('Sheet', 'A', 'Z'),
         );
@@ -36,11 +35,8 @@ public function test_extract_with_cut_extra_columns() : void
 
     public function test_extract_without_cut_extra_columns() : void
     {
-        $client = new GoogleClient();
-        $client->setHttpClient($this->createHttpClient());
-
         $extractor = new GoogleSheetExtractor(
-            new Sheets($client),
+            $this->context->sheet(__DIR__ . '/../Fixtures/extra-columns.json'),
             '1234567890',
             new Columns('Sheet', 'A', 'Z'),
         );
@@ -55,23 +51,4 @@ public function test_extract_without_cut_extra_columns() : void
             self::assertNotNull($row);
         }
     }
-
-    private function createHttpClient() : Client
-    {
-        return new Client(
-            [
-                'handler' => HandlerStack::create(
-                    new MockHandler(
-                        [
-                            new Response(
-                                200,
-                                ['Content-Type' => 'application/json'],
-                                file_get_contents(__DIR__ . '/../Fixtures/extra-columns.json') ?: throw new \RuntimeException('Failed to read file')
-                            ),
-                        ]
-                    )
-                ),
-            ]
-        );
-    }
 }