Rework RenameEachEntryTransformer to a single instance on multiple strategies

Author: stloyd

src/core/etl/src/Flow/ETL/DataFrame.php

@@ -714,9 +714,7 @@ public function renameAllUpperCaseWord() : self
 
     public function renameEach(RenameEntryStrategy ...$strategies) : self
     {
-        foreach ($strategies as $strategy) {
-            $this->pipeline->add(new RenameEachEntryTransformer($strategy));
-        }
+        $this->pipeline->add(new RenameEachEntryTransformer(...$strategies));
 
         return $this;
     }

src/core/etl/src/Flow/ETL/Transformer/RenameEachEntryTransformer.php

@@ -4,20 +4,36 @@
 
 namespace Flow\ETL\Transformer;
 
-use Flow\ETL\{FlowContext, Row, Rows, Transformer, Transformer\Rename\RenameEntryStrategy};
+use Flow\ETL\{Exception\InvalidArgumentException,
+    FlowContext,
+    Row,
+    Rows,
+    Transformer,
+    Transformer\Rename\RenameEntryStrategy};
 
 final readonly class RenameEachEntryTransformer implements Transformer
 {
-    public function __construct(
-        private RenameEntryStrategy $strategy,
-    ) {
+    /**
+     * @var array<RenameEntryStrategy>
+     */
+    private array $strategies;
+
+    public function __construct(RenameEntryStrategy ...$strategies)
+    {
+        if ([] === $strategies) {
+            throw new InvalidArgumentException('At least one strategy must be provided.');
+        }
+
+        $this->strategies = $strategies;
     }
 
     public function transform(Rows $rows, FlowContext $context) : Rows
     {
         return $rows->map(function (Row $row) use ($context) : Row {
-            foreach ($row->entries()->all() as $entry) {
-                $row = $this->strategy->rename($row, $entry, $context);
+            foreach ($this->strategies as $strategy) {
+                foreach ($row->entries()->all() as $entry) {
+                    $row = $strategy->rename($row, $entry, $context);
+                }
             }
 
             return $row;

src/core/etl/tests/Flow/ETL/Tests/Unit/Transformer/RenameEachEntryTransformerTest.php

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Flow\ETL\Tests\Unit\Transformer;
+
+use Flow\ETL\{Exception\InvalidArgumentException, Tests\FlowTestCase, Transformer\RenameEachEntryTransformer};
+
+final class RenameEachEntryTransformerTest extends FlowTestCase
+{
+    public function test_renaming_fails_without_any_strategy() : void
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('At least one strategy must be provided.');
+
+        new RenameEachEntryTransformer();
+    }
+}