Add a new HTMLElementEntry & related stuff#1972
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #1972 +/- ##
==========================================
- Coverage 79.09% 78.94% -0.16%
==========================================
Files 839 841 +2
Lines 24952 25056 +104
==========================================
+ Hits 19736 19780 +44
- Misses 5216 5276 +60
🚀 New features to boost your workflow:
|
4207405 to
2ac6bf8
Compare
2ac6bf8 to
78718d4
Compare
78718d4 to
fa246f4
Compare
4473f1c to
7913fa5
Compare
|
Before this can be merged please make the assertions in |
b70a697 to
1c172c1
Compare
|
One last missing thing is scalar function that would let to extract values from Element, similar to those:
Without them there is no way to interact with Element unless we cast it to string which is also not perfect. |
| } | ||
|
|
||
| #[DataProvider('cast_data_provider')] | ||
| public function test_cast(mixed $value, mixed $expected, ?string $exceptionClass = null) : void |
There was a problem hiding this comment.
it would be good to add few examples of castin HTMLElement and HTMLDocument to string in StringTypeTest
1c172c1 to
4a4b74c
Compare
1934786 to
d31d8db
Compare
|
Nice!! 🚀 |
Resolves: #1967
Note this requires #1960 to be merged first.Change Log
Added
Fixed
Changed
Removed
Deprecated
Security