Stabilise tests

* Upload test artifacts on failure for all DBs
* Upgrade test containers to 1.21.3
* Disable MultipleExternalWorkerAcquireServiceTaskTest#testAcquireJobsInTheSameTimeWithNoRetries since it seems like on Oracle both of the threads are acquiring jobs properly
* Set fix time in IntermediateTimerEventTest#testCatchingTimerEvent before running the test
* Use plus 1 second instead of millisecond in CmmnTimerTaskTest
* Use different channel keys for each test in KafkaChannelDefinitionProcessorTest
* Add toString on the AcquiredExternalWorkerJobImpl
* Use awaitility for Camel MultiInstanceTest
* Make sure that times in CMMN TaskCollectionResourceTest have seconds otherwise tests are failing due to an invalid assertion
* Stabilise tests by checking for the async and timer jobs in one transaction
  It happens that if there is a timer the first check is done in one transaction and returns nothing.
  However, in the meantime the timer was moved to async, which would mean that the timers count would return empty as well
  and thus stop the execution.
  However, not everything has been executed.
* Adjust the Process Engine MultiInstanceTest to only run the async jobs, since we are testing the creation of a timer job when something fails
* Remove SpringEventRegistryChangeDetectorTest since we already have EventRegistryAutoConfigurationTest for testing the same thing
* Disable change detection in the tests since we have multiple application contexts that could be running in the test suite and they could be causing problems between each other

Author: filiphr

.github/workflows/db2.yml

@@ -44,6 +44,7 @@ jobs:
           distribution: 'zulu'
           java-version: 17
       - name: Test
+        id: test
         # use db2 for the host here because we have specified a container for the job.
         # If we were running the job on the VM this would be localhost
         # '>-' is a special YAML syntax and means that new lines would be replaced with spaces
@@ -61,3 +62,9 @@ jobs:
           -Dspring.datasource.username=db2inst1
           -Dspring.datasource.password=flowable
           -Dmaven.test.redirectTestOutputToFile=false
+      - name: Upload test artifacts
+        uses: actions/upload-artifact@v4
+        if: ${{ failure() && steps.test.conclusion == 'failure' }}
+        with:
+          name: surefire-test-reports-db2-${{ matrix.db2 }}
+          path: '**/target/surefire-reports/*'

.github/workflows/mariadb.yml

@@ -42,6 +42,7 @@ jobs:
           distribution: 'zulu'
           java-version: 17
       - name: Test
+        id: test
         # use localhost for the host here because we have specified a vm for the job.
         # '>-' is a special YAML syntax and means that new lines would be replaced with spaces
         # and new lines from the end would be removed
@@ -58,3 +59,9 @@ jobs:
           -Dspring.datasource.username=flowable
           -Dspring.datasource.password=flowable
           -Dmaven.test.redirectTestOutputToFile=false
+      - name: Upload test artifacts
+        uses: actions/upload-artifact@v4
+        if: ${{ failure() && steps.test.conclusion == 'failure' }}
+        with:
+          name: surefire-test-reports-mariadb-${{ matrix.mariadb }}
+          path: '**/target/surefire-reports/*'

.github/workflows/mysql.yml

@@ -42,6 +42,7 @@ jobs:
           distribution: 'zulu'
           java-version: 17
       - name: Test
+        id: test
         # use localhost for the host here because we have specified a vm for the job.
         # '>-' is a special YAML syntax and means that new lines would be replaced with spaces
         # and new lines from the end would be removed
@@ -58,3 +59,9 @@ jobs:
           -Dspring.datasource.username=flowable
           -Dspring.datasource.password=flowable
           -Dmaven.test.redirectTestOutputToFile=false
+      - name: Upload test artifacts
+        uses: actions/upload-artifact@v4
+        if: ${{ failure() && steps.test.conclusion == 'failure' }}
+        with:
+          name: surefire-test-reports-mysql-${{ matrix.mysql }}
+          path: '**/target/surefire-reports/*'

.github/workflows/oracle.yml

@@ -81,5 +81,5 @@ jobs:
         uses: actions/upload-artifact@v4
         if: ${{ failure() && steps.test.conclusion == 'failure' }}
         with:
-          name: surefire-test-reports-${{ matrix.oracle }}
+          name: surefire-test-reports-oracle-${{ matrix.oracle }}
           path: '**/target/surefire-reports/*'

.github/workflows/postgres.yml

@@ -37,6 +37,7 @@ jobs:
           distribution: 'zulu'
           java-version: 17
       - name: Test
+        id: test
         # use postgres for the host here because we have specified a container for the job.
         # If we were running the job on the VM this would be localhost
         # '>-' is a special YAML syntax and means that new lines would be replaced with spaces
@@ -54,3 +55,9 @@ jobs:
           -Dspring.datasource.username=flowable
           -Dspring.datasource.password=flowable
           -Dmaven.test.redirectTestOutputToFile=false
+      - name: Upload test artifacts
+        uses: actions/upload-artifact@v4
+        if: ${{ failure() && steps.test.conclusion == 'failure' }}
+        with:
+          name: surefire-test-reports-postgres-${{ matrix.postgres }}
+          path: '**/target/surefire-reports/*'

modules/flowable-camel/pom.xml

@@ -115,6 +115,11 @@
       <artifactId>nashorn-core</artifactId>
       <scope>test</scope>
     </dependency>
+      <dependency>
+          <groupId>org.awaitility</groupId>
+          <artifactId>awaitility</artifactId>
+          <scope>test</scope>
+      </dependency>
 
   </dependencies>
 

modules/flowable-camel/src/test/java/org/flowable/camel/examples/multiinstance/MultiInstanceTest.java

@@ -14,7 +14,9 @@
 package org.flowable.camel.examples.multiinstance;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.awaitility.Awaitility.await;
 
+import java.time.Duration;
 import java.util.List;
 
 import org.apache.camel.CamelContext;
@@ -53,7 +55,7 @@ public void configure() throws Exception {
 
     @Test
     @Deployment(resources = { "process/multiinstanceReceive.bpmn20.xml" })
-    public void testRunProcess() throws Exception {
+    public void testRunProcess() {
         ProcessInstance processInstance = runtimeService.startProcessInstanceByKey("miProcessExample");
         List<Job> jobList = managementService.createJobQuery().list();
         assertThat(jobList).hasSize(5);
@@ -64,13 +66,9 @@ public void testRunProcess() throws Exception {
                 .count()).isEqualTo(5);
 
         waitForJobExecutorToProcessAllJobs(3000, 500);
-        int counter = 0;
-        long processInstanceCount = 1;
-        while (processInstanceCount == 1 && counter < 20) {
-            Thread.sleep(500);
-            processInstanceCount = runtimeService.createProcessInstanceQuery().processInstanceId(processInstance.getId()).count();
-            counter++;
-        }
-        assertThat(runtimeService.createProcessInstanceQuery().processInstanceId(processInstance.getId()).count()).isZero();
+        await("Receive from Camel")
+                .atMost(Duration.ofSeconds(30))
+                .pollInterval(Duration.ofMillis(500))
+                .untilAsserted(() -> assertThat(runtimeService.createProcessInstanceQuery().processInstanceId(processInstance.getId()).list()).isEmpty());
     }
 }

modules/flowable-cmmn-engine-configurator/src/test/java/org/flowable/cmmn/test/AbstractProcessEngineIntegrationTest.java

@@ -14,7 +14,6 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-import java.util.Date;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -107,12 +106,6 @@ public void cleanup() {
         }
     }
 
-    protected Date setCmmnClockFixedToCurrentTime() {
-        Date date = new Date();
-        cmmnEngineConfiguration.getClock().setCurrentTime(date);
-        return date;
-    }
-
     protected void assertCaseInstanceEnded(CaseInstance caseInstance) {
         long count = cmmnRuntimeService.createPlanItemInstanceQuery().caseInstanceId(caseInstance.getId()).count();
         assertThat(count).as(createCaseInstanceEndedErrorMessage(caseInstance, count)).isZero();

modules/flowable-cmmn-engine-configurator/src/test/java/org/flowable/cmmn/test/CmmnTimerTaskTest.java

@@ -15,6 +15,8 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
+import java.time.Instant;
+import java.time.temporal.ChronoUnit;
 import java.util.Date;
 import java.util.List;
 
@@ -40,7 +42,8 @@ public class CmmnTimerTaskTest extends AbstractProcessEngineIntegrationTest {
     @Test
     @CmmnDeployment(resources = "org/flowable/cmmn/test/timerInStage.cmmn")
     public void testCmmnTimerTask() {
-        Date startTime = setCmmnClockFixedToCurrentTime();
+        Instant startTime = Instant.now();
+        cmmnEngineConfiguration.getClock().setCurrentTime(Date.from(startTime));
         CaseInstance caseInstance = cmmnRuntimeService.createCaseInstanceBuilder().caseDefinitionKey("testTimerInStage").start();
 
         assertThat(cmmnRuntimeService.createPlanItemInstanceQuery().caseInstanceId(caseInstance.getId()).planItemInstanceState(PlanItemInstanceState.ACTIVE)
@@ -61,7 +64,7 @@ public void testCmmnTimerTask() {
         timerJobs = processEngineManagementService.createTimerJobQuery().scopeId(caseInstance.getId()).scopeType(ScopeTypes.CMMN).executable().list();
         assertThat(timerJobs).isEmpty();
 
-        processEngine.getProcessEngineConfiguration().getClock().setCurrentTime(new Date(startTime.getTime() + (3 * 60 * 60 * 1000 + 1)));
+        processEngine.getProcessEngineConfiguration().getClock().setCurrentTime(Date.from(startTime.plus(3, ChronoUnit.HOURS).plusSeconds(1)));
 
         timerJobs = processEngineManagementService.createTimerJobQuery().scopeId(caseInstance.getId()).scopeType(ScopeTypes.CMMN).executable().list();
         assertThat(timerJobs).hasSize(1);
@@ -73,7 +76,7 @@ public void testCmmnTimerTask() {
                 .hasMessage("time limit of 7000 was exceeded");
 
         // Timer fires after 3 hours, so setting it to 3 hours + 1 second
-        cmmnEngineConfiguration.getClock().setCurrentTime(new Date(startTime.getTime() + (3 * 60 * 60 * 1000 + 1)));
+        cmmnEngineConfiguration.getClock().setCurrentTime(Date.from(startTime.plus(3, ChronoUnit.HOURS).plusSeconds(1)));
 
         timerJobs = cmmnManagementService.createTimerJobQuery().caseInstanceId(caseInstance.getId()).executable().list();
         assertThat(timerJobs)

modules/flowable-cmmn-rest/src/test/java/org/flowable/cmmn/rest/service/api/runtime/TaskCollectionResourceTest.java

@@ -135,14 +135,17 @@ public void testGetTasks() throws Exception {
         org.flowable.cmmn.api.repository.CmmnDeployment deployment = null;
         try {
             Calendar adhocTaskCreate = Calendar.getInstance();
+            adhocTaskCreate.set(Calendar.SECOND, 14);
             adhocTaskCreate.set(Calendar.MILLISECOND, 0);
 
             Calendar processTaskCreate = Calendar.getInstance();
             processTaskCreate.add(Calendar.HOUR, 2);
+            processTaskCreate.set(Calendar.SECOND, 15);
             processTaskCreate.set(Calendar.MILLISECOND, 0);
 
             Calendar inBetweenTaskCreation = Calendar.getInstance();
             inBetweenTaskCreation.add(Calendar.HOUR, 1);
+            inBetweenTaskCreation.set(Calendar.SECOND, 21);
 
             cmmnEngineConfiguration.getClock().setCurrentTime(adhocTaskCreate.getTime());
             Task adhocTask = taskService.newTask();
@@ -362,7 +365,6 @@ public void testGetTasks() throws Exception {
             url = CmmnRestUrls.createRelativeResourceUrl(CmmnRestUrls.URL_TASK_COLLECTION) + "?dueDate=" + getIsoDateStringWithoutSeconds(
                     adhocTaskCreate.getTime());
             assertResultsPresentInDataResponse(url);
-            assertResultsPresentInDataResponse(url);
             url = CmmnRestUrls.createRelativeResourceUrl(CmmnRestUrls.URL_TASK_COLLECTION) + "?dueDate=" + getIsoDateStringWithMS(adhocTaskCreate.getTime());
             assertResultsPresentInDataResponse(url, adhocTask.getId());