Skip to content

refactor: include all ws and exec data in json#237

Merged
jahvon merged 3 commits intomainfrom
marshal
Jun 20, 2025
Merged

refactor: include all ws and exec data in json#237
jahvon merged 3 commits intomainfrom
marshal

Conversation

@jahvon
Copy link
Copy Markdown
Member

@jahvon jahvon commented Jun 20, 2025

Refactoring and Serialization Enhancements:

  • Introduced enrichedExecutable and enrichedWorkspace structs to encapsulate additional metadata (e.g., FullDescription, Namespace, Path) for better YAML/JSON serialization.

  • Added custom MarshalJSON and UnmarshalJSON methods for Executable and RequestExecutableType to handle timeout serialization/deserialization as strings, ensuring compatibility with JSON formats (types/executable/executable.go).

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 65 lines in your changes missing coverage. Please review.

Project coverage is 21.97%. Comparing base (b944b8c) to head (a8ed45e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
types/executable/executable.go 35.13% 48 Missing ⚠️
types/workspace/workspace.go 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   22.07%   21.97%   -0.11%     
==========================================
  Files          84       84              
  Lines        6958     7027      +69     
==========================================
+ Hits         1536     1544       +8     
- Misses       5145     5206      +61     
  Partials      277      277              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jahvon jahvon merged commit 87de595 into main Jun 20, 2025
8 checks passed
@jahvon jahvon deleted the marshal branch June 20, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant