Skip to content

fix: evaluate conditionals right before execution#316

Merged
jahvon merged 3 commits intomainfrom
fix-conditional
Oct 2, 2025
Merged

fix: evaluate conditionals right before execution#316
jahvon merged 3 commits intomainfrom
fix-conditional

Conversation

@jahvon
Copy link
Copy Markdown
Member

@jahvon jahvon commented Oct 2, 2025

Fixes an issue where setting cache values during a serial or parallel execution would not provide those values to conditional state. This changes where conditional functions are run so that it's closer to the execution time.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 49.57265% with 59 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/runner/parallel/parallel.go 30.00% 27 Missing and 1 partial ⚠️
internal/runner/serial/serial.go 30.00% 27 Missing and 1 partial ⚠️
internal/runner/engine/engine.go 91.89% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@jahvon jahvon linked an issue Oct 2, 2025 that may be closed by this pull request
@jahvon jahvon marked this pull request as ready for review October 2, 2025 17:53
@jahvon jahvon merged commit e51df0c into main Oct 2, 2025
14 checks passed
@jahvon jahvon deleted the fix-conditional branch October 2, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data-driven executions example does not work

1 participant