Skip to content

Added explicit nullable type to prevent deprecation warnings under PHP >= 8.4 #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vixe76 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added explicit nullable type to prevent deprecation warnings under PHP >= 8.4 #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1857389
Added explicit nullable type for nullable parameters
vixe76 Feb 24, 2026
ad24f49
Added explicit nullable type for nullable parameters
vixe76 Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Classes/S3Storage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ public function getStreamByResourcePath($relativePath)
* @param callable|null $callback Function called after each iteration
* @return \Generator<StorageObject>
*/
public function getObjects(callable $callback = null)
public function getObjects(?callable $callback = null)
{
foreach ($this->resourceManager->getCollectionsByStorage($this) as $collection) {
yield from $this->getObjectsByCollection($collection, $callback);
Expand All @@ -360,7 +360,7 @@ public function getObjects(callable $callback = null)
* @return \Generator<StorageObject>
* @api
*/
public function getObjectsByCollection(CollectionInterface $collection, callable $callback = null)
public function getObjectsByCollection(CollectionInterface $collection, ?callable $callback = null)
{
$iteration = 0;
$iterator = $this->resourceRepository->findByCollectionNameIterator($collection->getName());
Expand Down
4 changes: 2 additions & 2 deletions Classes/S3Target.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ public function getAcl()
* @throws \Neos\Flow\Exception
* @throws \Exception
*/
public function publishCollection(CollectionInterface $collection, callable $callback = null)
public function publishCollection(CollectionInterface $collection, ?callable $callback = null)
{
$storage = $collection->getStorage();

Expand Down Expand Up @@ -307,7 +307,7 @@ public function publishCollection(CollectionInterface $collection, callable $cal
* @param array $potentiallyObsoleteObjects
* @param callable|null $callback
*/
private function publishCollectionFromS3Storage(CollectionInterface $collection, S3Storage $storage, array &$potentiallyObsoleteObjects, callable $callback = null): void
private function publishCollectionFromS3Storage(CollectionInterface $collection, S3Storage $storage, array &$potentiallyObsoleteObjects, ?callable $callback = null): void
{
foreach ($collection->getObjects($callback) as $object) {
/** @var StorageObject $object */
Expand Down