Correcting hardcode messages

#7

Author: ziagham

src/FlowPack/Packager.cs

@@ -40,7 +40,7 @@ public bool Build()
         string pluginTempPath = Path.Combine(Path.GetTempPath(), Guid.NewGuid() + ".plugin");
         string pluginMetadataTempPath = Path.Combine(Path.GetTempPath(), Guid.NewGuid() + ".json");
 
-        var metadata = PluginReflector.ExtractPluginMetadata(tempOutput);
+        var metadata = PluginReflector.ExtractPluginMetadata(tempOutput, _options.Verbose);
         if (metadata == null)
         {
             Console.WriteLine("No valid plugin metadata found.");

src/FlowPack/PluginReflector.cs

@@ -7,7 +7,7 @@ public static class PluginReflector
 {
     private const string PluginSearchPattern = "*.dll";
 
-    public static PluginMetadata? ExtractPluginMetadata(string pluginDirectory)
+    public static PluginMetadata? ExtractPluginMetadata(string pluginDirectory, bool verbose)
     {
         var interfaceType = typeof(IPlugin);
         foreach (var dllPath in Directory.GetFiles(pluginDirectory, PluginSearchPattern))
@@ -20,7 +20,8 @@ public static class PluginReflector
             }
             catch (Exception ex)
             {
-                Console.Error.WriteLine(ex.Message);
+                if (verbose)
+                    Console.Error.WriteLine(ex.Message);
             }
             finally
             {
@@ -29,53 +30,6 @@ public static class PluginReflector
         }
 
         return null;
-
-
-        //foreach (var dllPath in Directory.GetFiles(pluginDirectory, "*.dll"))
-        //{
-        //    try
-        //    {
-        //        var assembly = Assembly.LoadFrom(dllPath);
-
-        //        foreach (var type in assembly.GetTypes())
-        //        {
-        //            if (!type.IsClass || type.IsAbstract || type.IsInterface)
-        //                continue;
-
-        //            if (!interfaceType.IsAssignableFrom(type))
-        //                continue;
-
-        //            var instance = Activator.CreateInstance(type);
-        //            if (instance == null)
-        //                continue;
-
-        //            var metadata = new PluginMetadata
-        //            {
-        //                Id = GetPropertyValue<Guid>(type, instance, nameof(PluginMetadata.Id)),
-        //                Type = GetPropertyValue<string>(type, instance, nameof(PluginMetadata.Type)),
-        //                Version = GetPropertyValue<string>(type, instance, nameof(PluginMetadata.Version)),
-        //                CompanyName = GetPropertyValue<string>(type, instance, nameof(PluginMetadata.CompanyName)),
-        //                Description = GetPropertyValue<string?>(type, instance, nameof(PluginMetadata.Description)),
-        //                License = GetPropertyValue<string?>(type, instance, nameof(PluginMetadata.License)),
-        //                LicenseUrl = GetPropertyValue<string?>(type, instance, nameof(PluginMetadata.LicenseUrl)),
-        //                Icon = GetPropertyValue<string?>(type, instance, nameof(PluginMetadata.Icon)),
-        //                ProjectUrl = GetPropertyValue<string?>(type, instance, nameof(PluginMetadata.ProjectUrl)),
-        //                RepositoryUrl = GetPropertyValue<string?>(type, instance, nameof(PluginMetadata.RepositoryUrl)),
-        //                Copyright = GetPropertyValue<string?>(type, instance, nameof(PluginMetadata.Copyright)),
-        //                Authors = GetPropertyValue<List<string>>(type, instance, nameof(PluginMetadata.Authors)) ?? new(),
-        //                Tags = GetPropertyValue<List<string>>(type, instance, nameof(PluginMetadata.Tags)) ?? new()
-        //            };
-
-        //            return metadata;
-        //        }
-        //    }
-        //    catch (Exception ex)
-        //    {
-        //        Console.Error.WriteLine($"Failed to read metadata from {dllPath}: {ex.Message}");
-        //    }
-        //}
-
-        //return null;
     }
 
     private static PluginMetadata CreatePluginMetadata(IPlugin plugin)
@@ -98,15 +52,6 @@ private static PluginMetadata CreatePluginMetadata(IPlugin plugin)
         };
     }
 
-    private static T? GetPropertyValue<T>(Type type, object instance, string propertyName)
-    {
-        var prop = type.GetProperty(propertyName);
-        if (prop == null || !typeof(T).IsAssignableFrom(prop.PropertyType))
-            return default;
-
-        return (T?)prop.GetValue(instance);
-    }
-
     public static string SaveMetadataToFile(PluginMetadata metadata, string outputDirectory)
     {
         var json = JsonSerializer.Serialize(metadata, new JsonSerializerOptions { WriteIndented = true });

src/FlowPack/TransientPluginLoader.cs

@@ -26,7 +26,7 @@ public void Load()
             var pluginType = LoadPluginType(pluginAssembly);
 
             if (pluginType == null)
-                throw new Exception($"Plugin_Loader_NoPluginFound: '{_pluginLocation}'");
+                throw new Exception($"No plugin type found: '{_pluginLocation}'");
 
             _pluginInstance = CreatePluginInstance(pluginType);
         }
@@ -36,7 +36,7 @@ private void ValidatePluginFile(string pluginLocation)
     {
         if (!File.Exists(pluginLocation))
         {
-            throw new Exception($"Plugin_Loader_FileNotFound: {pluginLocation}");
+            throw new Exception($"Plugin file not found: {pluginLocation}");
         }
     }
 
@@ -52,7 +52,7 @@ private IPlugin CreatePluginInstance(Type pluginType)
     {
         if (Activator.CreateInstance(pluginType) is not IPlugin instance)
         {
-            throw new Exception($"Plugin_Loader_FailedToCreateInstance '{pluginType.FullName}'");
+            throw new Exception($"Failed to create plugin instance of type '{pluginType.FullName}'.");
         }
         return instance;
     }