Skip to content

Add CloudFront signer package#211

Open
yotamishak wants to merge 1 commit into
floydspace:mainfrom
yotamishak:add-cloudfront-signer
Open

Add CloudFront signer package#211
yotamishak wants to merge 1 commit into
floydspace:mainfrom
yotamishak:add-cloudfront-signer

Conversation

@yotamishak
Copy link
Copy Markdown

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 21, 2026

🦋 Changeset detected

Latest commit: 395b3f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@effect-aws/cloudfront-signer Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AsafBenjaminov
Copy link
Copy Markdown

lgtm

@floydspace
Copy link
Copy Markdown
Owner

Hi @yotamishak thanks for contribution, I will carefully review it this week.

Copy link
Copy Markdown
Owner

@floydspace floydspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yotamishak
checked the code, and I have a change request for you:
could you pls make the more general @effect-aws/cloudfront package which will contain signer module, similar how it is done in dslq. The idea is to have aws service specific package with different utilities, this one will be a new cloudfront package
That is my oppinioated preferrence how to organize code, but I think it makes sense. I done want to make too many specific packages, in spite aws itself does

@floydspace
Copy link
Copy Markdown
Owner

and pls rebase, I updated the lock file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants