Add CloudFront signer package#211
Conversation
🦋 Changeset detectedLatest commit: 395b3f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
lgtm |
|
Hi @yotamishak thanks for contribution, I will carefully review it this week. |
floydspace
left a comment
There was a problem hiding this comment.
Hey @yotamishak
checked the code, and I have a change request for you:
could you pls make the more general @effect-aws/cloudfront package which will contain signer module, similar how it is done in dslq. The idea is to have aws service specific package with different utilities, this one will be a new cloudfront package
That is my oppinioated preferrence how to organize code, but I think it makes sense. I done want to make too many specific packages, in spite aws itself does
|
and pls rebase, I updated the lock file |
No description provided.