Skip to content

Add buffer_limit_size and buffer_overflow_method#68

Merged
Watson1978 merged 2 commits into
masterfrom
buffer_size_limit
Jun 12, 2025
Merged

Add buffer_limit_size and buffer_overflow_method#68
Watson1978 merged 2 commits into
masterfrom
buffer_size_limit

Conversation

@okkez

@okkez okkez commented Mar 18, 2019

Copy link
Copy Markdown
Member

Adds a size limit for concatenation.
If a concatenated record will overflow, the concatenate behavior will follow the `buffer_overflow_method'.

By default, it will continue to behave as before.

@cristianpetrula

Copy link
Copy Markdown

Any updates for this feature?

@emil2k

emil2k commented Jun 7, 2023

Copy link
Copy Markdown

@okkez Would it be possible to merge and release this feature? This is useful to us to avoid event too large errors when flushing to CloudWatch.

@okkez

okkez commented Jun 8, 2023

Copy link
Copy Markdown
Member Author

@kenhys Can you take a look?

@ashie ashie self-assigned this Jun 8, 2023
@whitepiratebaku

Copy link
Copy Markdown

Hello, it would be nice to have this feature released. Basicly we use concat plugin to concatenate containerd logs with partial_key/partial_value but what happens sometimes we may get very large logs which can trigger BufferChunkOverflowError error and lead to OOM/crash of fluentd. @okkez do you happen to know any workaround for now? to avoid large log lines hit fluentd output plugin/buffer so we avoid BufferChunkOverflowError

@daipom daipom assigned daipom and unassigned ashie Apr 16, 2025
@daipom daipom moved this to To-Do in Fluentd Kanban Apr 16, 2025
@Watson1978 Watson1978 self-requested a review May 7, 2025 02:56
@Watson1978

Copy link
Copy Markdown
Contributor

@okkez Can you please fix the conflict?

@daipom

daipom commented May 7, 2025

Copy link
Copy Markdown
Contributor

I will try.

Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
@Watson1978 Watson1978 force-pushed the buffer_size_limit branch from 1021e19 to fef55ac Compare May 8, 2025 06:49
@Watson1978

Watson1978 commented May 8, 2025

Copy link
Copy Markdown
Contributor

I solved the confilict and fixed up the commits.
And I backed up the original PR in Watson1978#1

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

@Watson1978 Watson1978 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@Watson1978 Watson1978 merged commit 5a6932f into master Jun 12, 2025
24 checks passed
@Watson1978 Watson1978 deleted the buffer_size_limit branch June 12, 2025 01:57
@daipom

daipom commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

Thanks @Watson1978!

@daipom daipom changed the title Add buffer_size_limit and buffer_overflow_method Add buffer_limit_size and buffer_overflow_method Jun 12, 2025
@daipom daipom moved this from To-Do to Done in Fluentd Kanban Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants