Skip to content

Fix lint errors #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenhys merged 2 commits into from
Jun 24, 2026
+3 −3
Merged

Fix lint errors #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5142f59
Disable rubocop's Naming/PredicateMethod check
Watson1978 Jun 24, 2026
c260664
Use FileUtils.touch instead to fix rubocop error
Watson1978 Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/plugin/test_cache_strategy.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def fetch_namespace_metadata(_namespace_name)
def log
logger = {}

def logger.on_trace
def logger.on_trace # rubocop:disable Naming/PredicateMethod
true
end

Expand Down
4 changes: 2 additions & 2 deletions test/plugin/test_filter_kubernetes_metadata.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ def create_driver(conf = '')
expected_cert_path = File.join(dir, Plugin::KubernetesMetadataFilter::K8_POD_CA_CERT)
expected_token_path = File.join(dir, Plugin::KubernetesMetadataFilter::K8_POD_TOKEN)

File.open(expected_cert_path, 'w')
File.open(expected_token_path, 'w')
FileUtils.touch(expected_cert_path)
FileUtils.touch(expected_token_path)

d = create_driver("
watch false
Expand Down