out_es: Add documentation for index record accessor#1163
Conversation
Signed-off-by: Victor Cabezas <vcabezas@tuenti.com>
… record accessor support Signed-off-by: Victor Cabezas <vcabezas@tuenti.com>
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
@esmerel can you review this PR, still waiting on code PR fluent/fluent-bit#7716 where I nudged the code owner and a review? |
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
Fixing changes I accidentally overwrote. Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
|
I accidentally overwrote while fixing the conflict and then fixed the changes - @eschabell, there's an example at the end that needs a newer code sample. |
Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
Warning Review limit reached
More reviews will be available in 7 minutes and 19 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR documents a new ChangesElasticsearch target_index Parameter Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@Wiston999 fixed conflicts. |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
pipeline/outputs/elasticsearch.md (1)
443-451: ⚡ Quick winConsider adding YAML format example for consistency.
Throughout this document, configuration examples are shown in both YAML and classic .conf formats using tabs (see lines 112-149, 177-212, 222-255, etc.). The
Target_indexsection only shows the classic .conf format. As per coding guidelines, providing both formats helps users working with either configuration style.📋 Suggested dual-format example
+{% tabs %} +{% tab title="fluent-bit.yaml" %} + +```yaml +pipeline: + + outputs: + - name: es + match: '*' + # ... + index: fallback + target_index: fluent-$destination_index + # ... +``` + +{% endtab %} +{% tab title="fluent-bit.conf" %} + ```text [OUTPUT] Name es Match * # ... Index fallback Target_index fluent-$destination_index # ... ``` + +{% endtab %} +{% endtabs %}Based on learnings, YAML examples use lowercase keys (e.g.,
target_index) while classic .conf examples use Title_Case (e.g.,Target_index).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pipeline/outputs/elasticsearch.md` around lines 443 - 451, The examples for the Elasticsearch output only include the fluent-bit .conf style (Target_index) and should also include the YAML-style example for consistency; add a YAML block under the pipeline.outputs section showing the equivalent keys (e.g., name: es, match: '*', index: fallback, target_index: fluent-$destination_index) alongside the existing [OUTPUT] block so readers see both formats and the lowercase YAML key mapping to Title_Case (.conf) (reference symbols: pipeline.outputs, name es, Target_index, target_index).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pipeline/outputs/elasticsearch.md`:
- Line 453: Replace the incorrect field name `destination__index` with the
correct `destination_index` in the documentation sentence so it matches the
other occurrences (e.g., the single-underscore `destination_index` used
elsewhere); update the text that currently reads "For records that do not have
the field `destination__index`, the value of `Index` (`fallback`) will be used."
to use `destination_index` instead.
---
Nitpick comments:
In `@pipeline/outputs/elasticsearch.md`:
- Around line 443-451: The examples for the Elasticsearch output only include
the fluent-bit .conf style (Target_index) and should also include the YAML-style
example for consistency; add a YAML block under the pipeline.outputs section
showing the equivalent keys (e.g., name: es, match: '*', index: fallback,
target_index: fluent-$destination_index) alongside the existing [OUTPUT] block
so readers see both formats and the lowercase YAML key mapping to Title_Case
(.conf) (reference symbols: pipeline.outputs, name es, Target_index,
target_index).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4cb5c45e-09e6-478e-b18e-1cf83ddbafb8
📒 Files selected for processing (1)
pipeline/outputs/elasticsearch.md
Signed-off-by: Eric D. Schabell <eric@schabell.org>
Applies to fluent#1163 Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
@Wiston999 cleaned up this older contribution to get past all the vale checks. |
Applies to fluent#1163 Signed-off-by: Eric D. Schabell <eric@schabell.org>
eschabell
left a comment
There was a problem hiding this comment.
@Wiston999 waiting on code PR merging.
Summary by CodeRabbit
target_indexparameter for Elasticsearch output, enabling dynamic selection of destination indexes from record accessor fields with fallback to the defaultindexsetting when fields are absent.