in_someip: Initial input plugin documentation.#1569
Conversation
Adds the documentation for the new in_someip plugin: fluent/fluent-bit#9570 Signed-off-by: Anthony Payne <anthony.payne@gm.com>
Updated in_someip documentation to include example yaml configuration. Signed-off-by: Anthony Payne <anthony.payne@gm.com>
|
@esmerel can you review for style, this is waiting on code PR fluent/fluent-bit#9570 before we merge this and is tagged so. |
esmerel
left a comment
There was a problem hiding this comment.
Updated (mostly) for style and consistency. It's not exactly how I want it because the web editor doesn't handle suggested changes with code ticks well.
Co-authored-by: Lynette Miles <6818907+esmerel@users.noreply.github.com> Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds a new documentation page for the SOME/IP input plugin describing its purpose, supported configuration keys ( ChangesSOME/IP Plugin Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Lynette Miles <6818907+esmerel@users.noreply.github.com> Signed-off-by: Eric D. Schabell <eric@schabell.org>
Co-authored-by: Lynette Miles <6818907+esmerel@users.noreply.github.com> Signed-off-by: Eric D. Schabell <eric@schabell.org>
Co-authored-by: Lynette Miles <6818907+esmerel@users.noreply.github.com> Signed-off-by: Eric D. Schabell <eric@schabell.org>
Co-authored-by: Lynette Miles <6818907+esmerel@users.noreply.github.com> Signed-off-by: Eric D. Schabell <eric@schabell.org>
Co-authored-by: Lynette Miles <6818907+esmerel@users.noreply.github.com> Signed-off-by: Eric D. Schabell <eric@schabell.org>
Co-authored-by: Lynette Miles <6818907+esmerel@users.noreply.github.com> Signed-off-by: Eric D. Schabell <eric@schabell.org>
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pipeline/inputs/someip.md`:
- Line 14: The RPC description contains a duplicated phrase "should be a should
be" in the sentence about the request payload; edit the text in the RPC
description (the line describing RPC format) to remove the duplicate so it reads
clearly (e.g., "The request payload should be base64 encoded") — update the
sentence in the SOME/IP RPC description to eliminate the repeated words.
- Around line 11-15: Update the fluent-bit.yaml example and parameter table:
replace repeated Title_Case mapping keys `Event` and `RPC` with lowercase
`event` and `rpc`, represent multiple events as a YAML list under a single
`event:` key (instead of duplicating the key), and correct the RPC description
typo in the parameters table from “should be a should be base64 encoded” to
“should be base64 encoded”; look for the fluent-bit example and the table
entries referencing `Event`/`RPC` in the someip.md content to apply these
changes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
Actionable comments posted: 0 |
- Change all bash code fence identifiers to shell - Fix unclosed code fence in command line section - Lowercase YAML config keys in example and parameter table - Convert duplicate YAML event keys to a proper list - Add missing closing code fence for fluent-bit.yaml tab - Add missing endtab tag for fluent-bit.yaml tab - Add missing closing code fence for fluent-bit.conf tab - Fix mismatched closing quote in RPC parameter description - Remove trailing space after someip_test_service command - Remove extra trailing blank lines at end of file Applies to fluent#1569 Signed-off-by: Eric D. Schabell <eric@schabell.org>
- Change all bash code fence identifiers to shell - Fix unclosed code fence in command line section - Add missing closing code fence for fluent-bit.yaml tab - Add missing endtab tag for fluent-bit.yaml tab - Add missing closing code fence for fluent-bit.conf tab - Lowercase YAML config keys in example and parameter table - Convert duplicate YAML event keys to a proper YAML list - Fix mismatched closing quote in rpc parameter description - Replace RPCs with RPC entries to avoid vale spelling flag - Fix headings to sentence case - Fixing vale compliance errors - Remove first-person we usage in Testing section - Remove trailing spaces extra trailing blank lines at end of file Applies to fluent#1569 Signed-off-by: Eric D. Schabell <eric@schabell.org>
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pipeline/inputs/someip.md`:
- Line 74: Replace the insecure URL string "http://fluentbit.io" with
"https://fluentbit.io" in the markdown text so the Fluent Bit docs link uses
HTTPS (look for the literal "http://fluentbit.io" occurrence in the
pipeline/inputs/someip.md content and update it to "https://fluentbit.io").
- Around line 13-14: Update the two parameter descriptions for `event` and `rpc`
to use the hyphenated form "comma-separated" (i.e., change instances of "comma
separated list" to "comma-separated list") so both lines read consistently;
specifically edit the `event` description containing "service_ID, event_ID,
event_group_ID_1, event_group_ID_2, ..." and the `rpc` description containing
"service_ID, service_instance, method_ID, request_payload" to use
"comma-separated" in the phrasing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
@anthonypayne-GM a bunch of fixes for docs compliance and vale issues done! |
- Change "comma separated list" to "comma-separated list" in event and rpc descriptions - Fix insecure http://fluentbit.io link to https://fluentbit.io Applies to fluent#1569 Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
Actionable comments posted: 0 |
eschabell
left a comment
There was a problem hiding this comment.
@anthonypayne-GM just waiting now on the code PR merging.
Adds the documentation for the new in_someip plugin:
fluent/fluent-bit#9570
Summary by CodeRabbit