docs: installation: downloads: linux: raspbian: use signed-by for Bullseye apt source#2589
Conversation
|
Warning Review limit reached
More reviews will be available in 20 minutes and 39 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the Raspberry Pi Fluent Bit installation guide to use modern GPG key management practices. The GPG key is now installed into a dedicated keyring file using ChangesRaspberry Pi Installation Guide Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@installation/downloads/linux/raspbian-raspberry-pi.md`:
- Line 26: The apt source lines for Bookworm and Buster are missing the
signed-by directive pointing to the installed GPG keyring; update the echo
commands that create /etc/apt/sources.list.d/fluent-bit.list for Bookworm (the
echo at the Bookworm source) and Buster (the echo at the Buster source) to
include [signed-by=/usr/share/keyrings/fluentbit-keyring.gpg] immediately after
"deb" so they match the Bullseye entry and allow APT to locate
/usr/share/keyrings/fluentbit-keyring.gpg for signature verification.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8e316b3a-4623-4ce1-903a-8b617499e011
📒 Files selected for processing (1)
installation/downloads/linux/raspbian-raspberry-pi.md
…lseye apt source - Replace apt-key add with gpg --dearmor | sudo tee to store key in /usr/share/keyrings - Add signed-by=/usr/share/keyrings/fluentbit-keyring.gpg to Raspbian 10 (Buster) apt source entry - Add signed-by=/usr/share/keyrings/fluentbit-keyring.gpg to Raspbian 11 (Bullseye) apt source entry - Add signed-by=/usr/share/keyrings/fluentbit-keyring.gpg to Raspbian 12 (Bookworm) apt source entry - Wrap Bookworm, Bullseye, and Buster codenames in backticks in section headings Replaces fluent#1147 Signed-off-by: Eric D. Schabell <eric@schabell.org>
201b3e9 to
4507ad0
Compare
|
@cosmo0920 and @patrick-stephens would you look at this replacement docs PR for the old one? |
Replaces #1147
Summary by CodeRabbit