Skip to content

docs: installation: downloads: linux: raspbian: use signed-by for Bullseye apt source#2589

Open
eschabell wants to merge 1 commit into
fluent:masterfrom
eschabell:erics_install_linux_raspbian_signed_by_fix
Open

docs: installation: downloads: linux: raspbian: use signed-by for Bullseye apt source#2589
eschabell wants to merge 1 commit into
fluent:masterfrom
eschabell:erics_install_linux_raspbian_signed_by_fix

Conversation

@eschabell
Copy link
Copy Markdown
Collaborator

@eschabell eschabell commented May 27, 2026

  • Replace apt-key add with gpg --dearmor | sudo tee to store key in /usr/share/keyrings
  • Add signed-by=/usr/share/keyrings/fluentbit-keyring.gpg to Raspbian 11 (Bullseye) apt source entry
  • Wrap Bookworm, Bullseye, and Buster codenames in backticks in section headings

Replaces #1147

Summary by CodeRabbit

  • Documentation
    • Updated Raspberry Pi installation guide with improved GPG key setup procedures
    • Added separate installation instructions for Raspbian 12, 11, and 10 versions
    • Enhanced clarity for APT repository configuration

Review Change Stack

@eschabell eschabell self-assigned this May 27, 2026
@eschabell eschabell requested a review from a team as a code owner May 27, 2026 19:19
@eschabell eschabell added waiting-on-review Waiting on a review from mainteners 5.0.6 labels May 27, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Warning

Review limit reached

@eschabell, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 20 minutes and 39 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c7aa9559-410f-453d-800e-e69c0f1cb7c7

📥 Commits

Reviewing files that changed from the base of the PR and between 201b3e9 and 4507ad0.

📒 Files selected for processing (1)
  • installation/downloads/linux/raspbian-raspberry-pi.md
📝 Walkthrough

Walkthrough

This PR updates the Raspberry Pi Fluent Bit installation guide to use modern GPG key management practices. The GPG key is now installed into a dedicated keyring file using gpg --dearmor, and the APT sources configuration is reorganized with separate subsections for each Raspbian version, including a signed-by directive for Bullseye.

Changes

Raspberry Pi Installation Guide Updates

Layer / File(s) Summary
GPG key installation and APT sources configuration
installation/downloads/linux/raspbian-raspberry-pi.md
GPG key installation is updated from apt-key to gpg --dearmor with output to a dedicated /usr/share/keyrings/fluentbit-keyring.gpg keyring file. APT sources list is reorganized with separate subsections for Raspbian 12 (Bookworm), 11 (Bullseye), and 10 (Buster), and a signed-by= directive is added for Bullseye repositories.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested reviewers

  • cosmo0920
  • patrick-stephens

Poem

🐰 A keyring update, secure and fine,
GPG dearmor'd, one file to align,
Raspbian versions, now each has its place,
Signed repositories, a modern embrace!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: updating the Raspbian installation guide to use signed-by for Bullseye apt source, which directly aligns with the primary objective of adding signed-by=/usr/share/keyrings/fluentbit-keyring.gpg to the Raspbian 11 (Bullseye) apt source entry.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@installation/downloads/linux/raspbian-raspberry-pi.md`:
- Line 26: The apt source lines for Bookworm and Buster are missing the
signed-by directive pointing to the installed GPG keyring; update the echo
commands that create /etc/apt/sources.list.d/fluent-bit.list for Bookworm (the
echo at the Bookworm source) and Buster (the echo at the Buster source) to
include [signed-by=/usr/share/keyrings/fluentbit-keyring.gpg] immediately after
"deb" so they match the Bullseye entry and allow APT to locate
/usr/share/keyrings/fluentbit-keyring.gpg for signature verification.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8e316b3a-4623-4ce1-903a-8b617499e011

📥 Commits

Reviewing files that changed from the base of the PR and between 5231934 and 201b3e9.

📒 Files selected for processing (1)
  • installation/downloads/linux/raspbian-raspberry-pi.md

Comment thread installation/downloads/linux/raspbian-raspberry-pi.md Outdated
…lseye apt source

  - Replace apt-key add with gpg --dearmor | sudo tee to store key in /usr/share/keyrings
  - Add signed-by=/usr/share/keyrings/fluentbit-keyring.gpg to Raspbian 10 (Buster) apt source entry
  - Add signed-by=/usr/share/keyrings/fluentbit-keyring.gpg to Raspbian 11 (Bullseye) apt source entry
  - Add signed-by=/usr/share/keyrings/fluentbit-keyring.gpg to Raspbian 12 (Bookworm) apt source entry
  - Wrap Bookworm, Bullseye, and Buster codenames in backticks in section headings

  Replaces fluent#1147

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell eschabell force-pushed the erics_install_linux_raspbian_signed_by_fix branch from 201b3e9 to 4507ad0 Compare May 27, 2026 19:26
@eschabell
Copy link
Copy Markdown
Collaborator Author

@cosmo0920 and @patrick-stephens would you look at this replacement docs PR for the old one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.0.6 waiting-on-review Waiting on a review from mainteners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant