input: add pause/resume callbacks#10616
Open
edsiper wants to merge 3 commits into
Open
Conversation
Previously, the in_tcp input plugin did not respond to engine pause or resume signals—meaning it continued to accept and handle connections even when the engine had paused the plugin (e.g: it should stop ingesting data). This patch implements the missing pause and resume callbacks. When the plugin is paused, all active client connections are forcefully closed, and new incoming connections are rejected. The plugin tracks its paused state to ensure correct behavior until it is resumed. Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Previously, the in_http input plugin did not respond to engine pause or resume signals—meaning it continued to accept and handle connections even when the engine had paused the plugin (e.g: it should stop ingesting data). This patch implements the missing pause and resume callbacks. When the plugin is paused, all active client connections are forcefully closed, and new incoming connections are rejected. The plugin tracks its paused state to ensure correct behavior until it is resumed. Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Previously, the in_opentelemetry input plugin did not respond to engine pause or resume signals—meaning it continued to accept and handle connections even when the engine had paused the plugin (e.g: it should stop ingesting data). This patch implements the missing pause and resume callbacks. When the plugin is paused, all active client connections are forcefully closed, and new incoming connections are rejected. The plugin tracks its paused state to ensure correct behavior until it is resumed. Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
edsiper
requested review from
fujimotos,
koleini and
leonardo-albertovich
as code owners
edsiper
changed the title
Member
Author
|
note: this PR needs to be based on top of #10790 (new downstream pause/resume functionality) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch implements the missing pause and resume callbacks for in_tcp, in_http and in_opentelemetry plugins. When the plugin is paused, all active client connections are forcefully closed, and new incoming connections are rejected. The
plugin tracks its paused state to ensure correct behavior until it is resumed.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.