scripts: enable working runtime tests#11724
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughTwo configuration changes: a shell script's default test exclusion list removes two modules, and a GitHub Actions workflow updates the CI helper checkout to reference a different repository and branch. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c86abe0 to
31424a8
Compare
76edf7c to
f006d83
Compare
2ebb0e7 to
cd068ee
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/unit-tests.yaml:
- Around line 116-117: In the unit-test workflow jobs that currently reference
the personal fork (the repository: mabrarov/fluent-bit-ci and ref:
feat/enable_tests entries in the unit-test job), revert those two fields to the
official CI repository and branch used elsewhere (e.g., repository:
fluent/fluent-bit-ci and the stable ref previously used) so both Linux and macOS
unit-test jobs match the other workflows (pr-perf-test.yaml and
call-run-integration-test.yaml); update the repository and ref values in the
unit-test job definitions to remove the personal fork and feature branch.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 434bfef2-66e6-4d3f-a46e-8e3cb76877ee
📒 Files selected for processing (2)
.github/workflows/unit-tests.yamlrun_code_analysis.sh
🚧 Files skipped from review as they are similar to previous changes (1)
- run_code_analysis.sh
|
We need to use shorter than 80 characters commit messages: |
45c6c4e to
d71ec74
Compare
… script Signed-off-by: Marat Abrarov <abrarov@gmail.com>
Signed-off-by: Marat Abrarov <abrarov@gmail.com>
… tests Signed-off-by: Marat Abrarov <abrarov@gmail.com>
Signed-off-by: Marat Abrarov <abrarov@gmail.com>
There was a problem hiding this comment.
♻️ Duplicate comments (1)
.github/workflows/unit-tests.yaml (1)
116-117:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winRevert CI helper checkout to the project-owned
fluent-bit-cirepo/refLine 116 and Line 173 still pin CI helper scripts to a personal fork branch (
mabrarov/fluent-bit-ci@feat/enable_tests). This is mutable and can break or unexpectedly alter CI behavior formaster. Please switch both jobs back to the org-owned/stable CI helper reference before merge.Suggested change
- uses: actions/checkout@v6 with: - repository: mabrarov/fluent-bit-ci - ref: feat/enable_tests + repository: fluent/fluent-bit-ci + ref: main path: ci @@ - uses: actions/checkout@v6 with: - repository: mabrarov/fluent-bit-ci - ref: feat/enable_tests + repository: fluent/fluent-bit-ci + ref: main path: ciAlso applies to: 173-174
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/unit-tests.yaml around lines 116 - 117, The CI workflow still checks out the helper actions from a personal fork (repository: mabrarov/fluent-bit-ci, ref: feat/enable_tests) at the two places using those keys; update both occurrences (the repository: and ref: entries around the checkout steps at the two job blocks) to point back to the org-owned stable helper (e.g., repository: fluent-bit/fluent-bit-ci and the stable ref or tag used across the project) so both jobs use the official CI helper repo/ref before merging.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In @.github/workflows/unit-tests.yaml:
- Around line 116-117: The CI workflow still checks out the helper actions from
a personal fork (repository: mabrarov/fluent-bit-ci, ref: feat/enable_tests) at
the two places using those keys; update both occurrences (the repository: and
ref: entries around the checkout steps at the two job blocks) to point back to
the org-owned stable helper (e.g., repository: fluent-bit/fluent-bit-ci and the
stable ref or tag used across the project) so both jobs use the official CI
helper repo/ref before merging.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: eaf394f9-85a3-451f-8180-af078f5657e2
📒 Files selected for processing (2)
.github/workflows/unit-tests.yamlrun_code_analysis.sh
🚧 Files skipped from review as they are similar to previous changes (1)
- run_code_analysis.sh
patrick-stephens
left a comment
There was a problem hiding this comment.
Seems a good idea to do more.
Summary
Fixed support of runtime tests in HTTP client. Refer to #11686 (comment).This change was already done / merged into master branch in #11710 and was removed from this PR.Enabled runtime tests for Elasticsearch and Forward output plugins in dev script.
The enabled tests were successfully executed on CI within e37d1f3 temporary commit using fluent/fluent-bit-ci#153 - refer to https://github.com/fluent/fluent-bit/actions/runs/25181471509?pr=11724.
Testing
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit
Bug Fixes
Tests
Chores