Skip to content

Commit 3a85f1f

Browse files
committed
Merge branch 'master' into json-resumable-parser
2 parents 9fad78d + 729eb32 commit 3a85f1f

5 files changed

Lines changed: 22 additions & 6 deletions

File tree

.github/workflows/test-ruby-head.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
strategy:
1515
fail-fast: false
1616
matrix:
17-
os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
17+
os: ['ubuntu-latest', 'macos-latest', 'windows-latest', 'windows-11-arm']
1818
ruby-version: ['head']
1919
env:
2020
RUBYOPT: "--disable-frozen_string_literal"

.github/workflows/test.yml

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,26 @@ concurrency:
2020
permissions: read-all
2121

2222
jobs:
23+
ruby-versions:
24+
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
25+
with:
26+
engine: cruby
27+
min_version: 3.2
2328
test:
29+
needs: ruby-versions
2430
runs-on: ${{ matrix.os }}
2531
continue-on-error: false
2632
strategy:
2733
fail-fast: false
2834
matrix:
29-
os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
30-
ruby-version: ['4.0', '3.4', '3.3', '3.2']
35+
os: ['ubuntu-latest', 'macos-latest', 'windows-latest', 'windows-11-arm']
36+
ruby-version: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
37+
exclude:
38+
- ruby-version: head
39+
- os: 'windows-11-arm'
40+
ruby-version: '3.3'
41+
- os: 'windows-11-arm'
42+
ruby-version: '3.2'
3143
env:
3244
RUBYOPT: "--disable-frozen_string_literal"
3345
name: Ruby ${{ matrix.ruby-version }} on ${{ matrix.os }}
@@ -46,11 +58,14 @@ jobs:
4658
run: bundle exec rake test TESTOPTS="-v --report-slow-tests --no-show-detail-immediately"
4759

4860
test-windows-service:
61+
needs: ruby-versions
4962
runs-on: windows-latest
5063
strategy:
5164
fail-fast: false
5265
matrix:
53-
ruby-version: ['4.0', '3.4', '3.3', '3.2']
66+
ruby-version: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
67+
exclude:
68+
- ruby-version: head
5469
name: Windows service (Ruby ${{ matrix.ruby-version }})
5570
steps:
5671
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

lib/fluent/engine.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ def reload_config(conf, supervisor: false)
186186

187187
ret.all_plugins.each do |plugin|
188188
if plugin.respond_to?(:reloadable_plugin?) && !plugin.reloadable_plugin?
189-
raise Fluent::ConfigError, "Unreloadable plugin plugin: #{Fluent::Plugin.lookup_type_from_class(plugin.class)}, plugin_id: #{plugin.plugin_id}, class_name: #{plugin.class})"
189+
raise Fluent::ConfigError, "Unreloadable plugin: #{Fluent::Plugin.lookup_type_from_class(plugin.class)}, plugin_id: #{plugin.plugin_id}, class_name: #{plugin.class})"
190190
end
191191
end
192192

test/command/test_ctl.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ def test_commands(data)
4646
"reload" => ["reload", "USR2"])
4747
def test_commands_with_winsvcname(data)
4848
omit "Only for Windows" unless Fluent.windows?
49+
omit "Need ffi 1.17.3 or later but blocked by https://github.com/chef/ffi-win32-extensions/issues/14" if Gem::Version.new(FFI::VERSION) < Gem::Version.new("1.17.3")
4950

5051
command, event_suffix = data
5152
event_name = "testfluentdwinsvc"

test/test_engine.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ def multi_workers_ready?; true; end
194194
e = assert_raise(Fluent::ConfigError) do
195195
engine.reload_config(new_conf)
196196
end
197-
assert e.message.match?('Unreloadable plugin plugin: dummy_engine_class_var_test')
197+
assert e.message.match?('Unreloadable plugin: dummy_engine_class_var_test')
198198

199199
assert_kind_of DummyEngineTestInput, engine.root_agent.inputs[0]
200200
assert_kind_of DummyEngineTestOutput, engine.root_agent.outputs[0]

0 commit comments

Comments
 (0)