Skip to content

Commit 729eb32

Browse files
authored
engine: remove duplicated word in unreloadable plugin error message (#5388)
**Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: The ConfigError raised on reload read "Unreloadable plugin plugin: ..." — removed the duplicated "plugin". **Docs Changes**: N/A **Release Note**: * engine: remove duplicated word in unreloadable plugin error message --------- Signed-off-by: Seonghyun Hong <s3onghyun.hong@gmail.com>
1 parent 3b34a7b commit 729eb32

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

lib/fluent/engine.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ def reload_config(conf, supervisor: false)
186186

187187
ret.all_plugins.each do |plugin|
188188
if plugin.respond_to?(:reloadable_plugin?) && !plugin.reloadable_plugin?
189-
raise Fluent::ConfigError, "Unreloadable plugin plugin: #{Fluent::Plugin.lookup_type_from_class(plugin.class)}, plugin_id: #{plugin.plugin_id}, class_name: #{plugin.class})"
189+
raise Fluent::ConfigError, "Unreloadable plugin: #{Fluent::Plugin.lookup_type_from_class(plugin.class)}, plugin_id: #{plugin.plugin_id}, class_name: #{plugin.class})"
190190
end
191191
end
192192

test/test_engine.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ def multi_workers_ready?; true; end
194194
e = assert_raise(Fluent::ConfigError) do
195195
engine.reload_config(new_conf)
196196
end
197-
assert e.message.match?('Unreloadable plugin plugin: dummy_engine_class_var_test')
197+
assert e.message.match?('Unreloadable plugin: dummy_engine_class_var_test')
198198

199199
assert_kind_of DummyEngineTestInput, engine.root_agent.inputs[0]
200200
assert_kind_of DummyEngineTestOutput, engine.root_agent.outputs[0]

0 commit comments

Comments
 (0)