From 9488a00f0572bf9d3ad0ebc086b1cffc80b440a3 Mon Sep 17 00:00:00 2001 From: SEONGHYUN HONG Date: Fri, 19 Jun 2026 10:44:11 +0900 Subject: [PATCH] engine: remove duplicated word in unreloadable plugin error message (#5388) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: The ConfigError raised on reload read "Unreloadable plugin plugin: ..." — removed the duplicated "plugin". **Docs Changes**: N/A **Release Note**: * engine: remove duplicated word in unreloadable plugin error message --------- Signed-off-by: Seonghyun Hong Signed-off-by: github-actions[bot] --- lib/fluent/engine.rb | 2 +- test/test_engine.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/fluent/engine.rb b/lib/fluent/engine.rb index 3bbd19a693..905f7a1295 100644 --- a/lib/fluent/engine.rb +++ b/lib/fluent/engine.rb @@ -186,7 +186,7 @@ def reload_config(conf, supervisor: false) ret.all_plugins.each do |plugin| if plugin.respond_to?(:reloadable_plugin?) && !plugin.reloadable_plugin? - raise Fluent::ConfigError, "Unreloadable plugin plugin: #{Fluent::Plugin.lookup_type_from_class(plugin.class)}, plugin_id: #{plugin.plugin_id}, class_name: #{plugin.class})" + raise Fluent::ConfigError, "Unreloadable plugin: #{Fluent::Plugin.lookup_type_from_class(plugin.class)}, plugin_id: #{plugin.plugin_id}, class_name: #{plugin.class})" end end diff --git a/test/test_engine.rb b/test/test_engine.rb index a28135341c..5b9bf1cffd 100644 --- a/test/test_engine.rb +++ b/test/test_engine.rb @@ -194,7 +194,7 @@ def multi_workers_ready?; true; end e = assert_raise(Fluent::ConfigError) do engine.reload_config(new_conf) end - assert e.message.match?('Unreloadable plugin plugin: dummy_engine_class_var_test') + assert e.message.match?('Unreloadable plugin: dummy_engine_class_var_test') assert_kind_of DummyEngineTestInput, engine.root_agent.inputs[0] assert_kind_of DummyEngineTestOutput, engine.root_agent.outputs[0]