Add startupProbe to fluentd#446
Open
jhanbo wants to merge 5 commits into
Open
Conversation
Signed-off-by: Johnny <johnny.hanbo@gmail.com>
Co-authored-by: Marco Franssen <marco.franssen@gmail.com> Signed-off-by: jhanbo <johnny.hanbo@gmail.com>
|
would be great to have this PR merged @marcofranssen any work needed on this one? |
stevehipwell
requested review from
patrick-stephens and
stevehipwell
as code owners
Contributor
|
Please can you rebase on the latest versions so we can bring in the updated CI? |
Contributor
|
I think this is a duplicate of #695 ? |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Contributor
|
DCO is a hard requirement unfortunately so please resolve. |
stevehipwell
requested changes
Jun 2, 2026
stevehipwell
left a comment
stevehipwell
left a comment
Collaborator
There was a problem hiding this comment.
Would this not be better as an opt in feature rather than having a default and no way of disabling it? You're also missing a CHANGELOG entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I would like to be able to configure startupProbe as well.
Thanks,
Johnny