Merge pull request #53 from rikrak/ShouldBeJsonSerializableReviewFix

Follow-up on #52

Author: jnyrup

Src/FluentAssertions.Json/ObjectAssertionsExtensions.cs

@@ -12,7 +12,7 @@ namespace FluentAssertions.Json
     public static class ObjectAssertionsExtensions
     {
         /// <summary>
-        /// Asserts that an object can be serialized and deserialized using the JSON serializer and that it stills retains
+        /// Asserts that an object can be serialized and deserialized using the JSON serializer and that it still retains
         /// the values of all members.
         /// </summary>
         /// <param name="assertions"></param>

Tests/FluentAssertions.Json.Specs/Models/AddressDto.cs

@@ -1,4 +1,7 @@
-namespace FluentAssertions.Json.Specs.Models
+using System;
+using Newtonsoft.Json;
+
+namespace FluentAssertions.Json.Specs.Models
 {
     // ReSharper disable UnusedMember.Global
 
@@ -8,6 +11,12 @@ public class AddressDto
         public string AddressLine2{ get; set; }
         public string AddressLine3{ get; set; }
     }
+
+    public class DerivedFromAddressDto:AddressDto
+    {
+        [JsonIgnore]
+        public DateTime LastUpdated{ get; set; }
+    }
     // ReSharper restore UnusedMember.Global
 
 }

Tests/FluentAssertions.Json.Specs/ShouldBeJsonSerializableTests.cs

@@ -108,9 +108,7 @@ public void Should_fail_when_instance_is_null()
             // assert
             act.Should()
                 .Throw<Xunit.Sdk.XunitException>(because:"This is consistent with BeBinarySerializable() and BeDataContractSerializable()")
-                .Which.Message
-                    .Should().Contain("value is null")
-                        .And.Contain("Please provide a value for the assertion");
+                .WithMessage("*value is null*Please provide a value for the assertion*");
         }
 
         [Fact]
@@ -127,9 +125,20 @@ public void Should_fail_when_subject_is_not_same_type_as_the_specified_generic_t
                 .Which.Message
                     .Should().Contain("is not assignable to")
                         .And.Contain(nameof(SimplePocoWithPrimitiveTypes));
-                ;
         }
 
+        [Fact]
+        public void Should_fail_when_derived_type_is_not_serializable_when_presented_as_base_class()
+        {
+            // arrange
+            AddressDto target = _fixture.Create<DerivedFromAddressDto>();
+
+            // act
+            Action act = () => target.Should().BeJsonSerializable();
+
+            // assert
+            act.Should().Throw<Xunit.Sdk.XunitException>("The derived class is not serializable due to a JsonIgnore attribute");
+        }
     }
 
 }