Fix 9 programming bugs found in xo's deep functional test

thefallentree · thefallentree · commit 1fb4be8a541c · 2026-07-24T21:23:44.000-07:00
Round-two deep functional test (AGENTS.md §10.7), registration, sect
join, a real fight-to-death and reincarnation, shop purchase,
quit/save/reconnect cycles.

1. d/menpai/wuliang/npc/zuo.lpc: unterminated string in the sect
   leader's own dialogue mapping -- a hard compile error that made the
   whole sect-join mechanism inert. Fixed the missing closing quote.
2. system/skill/misc/{yuanyang-dao,taizu-quan}.lpc: same unterminated-
   string typo, two more combat-skill files.
3. system/skill/basic/kongshou.lpc: a comment swallowed a function
   signature (`int is_native_skill()` merged into the preceding
   comment line), breaking the base unarmed-combat skill -- spammed a
   compile error to players on every combat round. Fixed.
4. d/city/yangzhou/{waifang,woshi}.lpc: inherit DOOR_ROOM (an
   undefined macro -- confirmed via grep, no other room in this
   archive uses it) -&gt; inherit ROOM, matching every one of the 65
   sibling rooms in the same directory (§6.1 shape).
5. d/city/yangzhou/npc/cloth/cloth.lpc + d/menpai/wuliang/npc/obj/
   choushan.lpc: missing #include &lt;armor.h&gt; (§6.1), plus cloth.lpc's
   set("value",); arg-count error fixed to set("value", 0).
6. cmds/verb/drop.lpc: obj-&gt;move() can legitimately self-destruct obj
   as a side effect (a bound weapon shattering when dropped) -- added
   an objectp() guard before further use, reproduced live as *Bad
   argument 1 to EFUN call_other() without the guard.
7. d/place/death/npc/chacha.lpc: 2 of 3 reincarnation destinations
   (d/map/zhongyuan/nanmen, d/city/lanzhou/guangchang) pointed at
   directories that don't exist anywhere in this trimmed archive
   (confirmed) -- silently stranded reincarnated players in the death
   realm forever. Repointed both to the one confirmed-live destination
   already used elsewhere in the same function (§7.18-shaped fix).
8. cmds/skill/study.lpc: an operator-precedence bug plus an
   "improvve_jibie" typo, fixed proactively though not currently
   reachable with live data.

Independently hit a third occurrence of AGENTS.md §10.8's driver-fatal
crash class during this session -- this time a raw SIGSEGV rather than
the prior FATAL ref-count-0 assertion, during the driver's periodic
reset() sweep. Not fixed (driver-level). Left two content/design
observations untouched per the scope filter: the sect's "mirror spar"
isn't damage-capped (killed a fresh disciple in one hit), and the
whole sect zone has no in-game walking path from the city in this
archive.
diff --git a/libs/xo/NOTES.md b/libs/xo/NOTES.md
diff --git a/libs/xo/work/cmds/skill/study.lpc b/libs/xo/work/cmds/skill/study.lpc
@@ -124,8 +124,8 @@ int get_gain(object me, object ob, mapping book) {
         write("这本书的一切都都已尽被你须知，你已经无法从中学到新东西了。\n");
         return 1;
       }
-      if (bonus = book["bonus_jibie"] > 0)
-        me->improvve_jibie(book["name"], bonus);
+      if ((bonus = book["bonus_jibie"]) > 0)
+        me->improve_jibie(book["name"], bonus);
       else if (bonus <= 0) {
         if (me->query("age") < 15)  // to avoid selecting gifts
           me->improve_jibie(book["name"], random(15));
diff --git a/libs/xo/work/cmds/verb/drop.lpc b/libs/xo/work/cmds/verb/drop.lpc
@@ -55,6 +55,11 @@ int do_drop(object me, object obj) {
     return notify_fail(stringp(no_drop) ? no_drop : "这样东西不能随意丢弃。\n");
 
   if (obj->move(environment(me))) {
+    // obj->move() can legitimately destruct obj as a side effect (e.g.
+    // a bound/soulbound weapon shattering when dropped outside its
+    // valid owner context -- see d/menpai/wuliang/npc/obj/sword.lpc's
+    // own move() override) -- guard before touching it further.
+    if (!objectp(obj)) return 1;
     if (obj->is_character())
       message_vision("$N将$n从背上放了下来，躺在地上。\n", me, obj);
     else {
diff --git a/libs/xo/work/d/city/yangzhou/npc/cloth/cloth.lpc b/libs/xo/work/d/city/yangzhou/npc/cloth/cloth.lpc
@@ -1,6 +1,7 @@
 //
 //by trill 04/06/97
 
+#include <armor.h>
 inherit CLOTH;
 
 void create() {
@@ -11,7 +12,7 @@ void create() {
   else {
     set("long", "");
     set("unit", "套");
-    set("value",);
+    set("value", 0);
     set("material", "cloth");
     set("armor_prop/armor", 2);
   }
diff --git a/libs/xo/work/d/city/yangzhou/waifang.lpc b/libs/xo/work/d/city/yangzhou/waifang.lpc
@@ -1,7 +1,7 @@
 //waifang.c
 
 #include <room.h>
-inherit DOOR_ROOM;
+inherit ROOM;
 
 
 void create() {
diff --git a/libs/xo/work/d/city/yangzhou/woshi.lpc b/libs/xo/work/d/city/yangzhou/woshi.lpc
@@ -1,7 +1,7 @@
 //woshi.c
 
 #include <room.h>
-inherit DOOR_ROOM;
+inherit ROOM;
 
 
 void create() {
diff --git a/libs/xo/work/d/menpai/wuliang/npc/obj/choushan.lpc b/libs/xo/work/d/menpai/wuliang/npc/obj/choushan.lpc
@@ -1,5 +1,6 @@
 // fighting_suit.c
 
+#include <armor.h>
 inherit CLOTH;
 
 void create() {
diff --git a/libs/xo/work/d/menpai/wuliang/npc/zuo.lpc b/libs/xo/work/d/menpai/wuliang/npc/zuo.lpc
@@ -66,7 +66,7 @@ void create()
     set("inquiry", ([
 //      "悟剑居" : "嗯，那是本门的武功所在，如今你可以进悟剑居参修了。",
         "此地" : "这里便是无量剑派。",
-        "姓名" : "嗯，你既知我姓左，怎会不知在下便是无量东宗掌门人左子穆？,
+        "姓名" : "嗯，你既知我姓左，怎会不知在下便是无量东宗掌门人左子穆？",
 //      "武功":   str,
 		"玉壁": (: about_yubi :),
         "指点武功" : (: change_master :),
diff --git a/libs/xo/work/d/place/death/npc/chacha.lpc b/libs/xo/work/d/place/death/npc/chacha.lpc
@@ -88,10 +88,19 @@ void death_stage(object ob, int stage) {
         ob->move("/d/city/yangzhou/kuixing_ge");
         break;
       case 1:
-        ob->move("/d/map/zhongyuan/nanmen");
+        // was "/d/map/zhongyuan/nanmen" -- that path doesn't exist in
+        // this trimmed "mini" archive, so move() silently failed
+        // (F_MOVE: destination doesn't exist) and permanently stranded
+        // the reincarnated player in the death realm (no live map
+        // connection back). Repointed to the one confirmed-live
+        // destination already used elsewhere in this same function,
+        // matching AGENTS.md #7.18's fix pattern.
+        ob->move("/d/city/yangzhou/kuixing_ge");
         break;
       case 2:
-        ob->move("/d/city/lanzhou/guangchang");
+        // was "/d/city/lanzhou/guangchang" -- same stranding bug as
+        // case 1 above ("lanzhou" doesn't exist in this archive either).
+        ob->move("/d/city/yangzhou/kuixing_ge");
         break;
     }
   }
diff --git a/libs/xo/work/data/login/q/qinfengding.o b/libs/xo/work/data/login/q/qinfengding.o
@@ -0,0 +1,2 @@
+#/clone/user/login.lpc
+dbase (["email":"qinfengding@example.com","password":"$6$Of/bkkeoQSZaAyXA$PYm1MhJ2oufZmKXM1ExJ72Jrzx4QugPJQ9TIdCxB2Wj5y1bTh0dU3VC4MAgDm4hRAzoEuAnKbGFOHGT0mTfZr.","id":"qinfengding","body":"/clone/user/user","name":"秦风丁",])
diff --git a/libs/xo/work/data/login/q/qinfengwu.o b/libs/xo/work/data/login/q/qinfengwu.o
@@ -0,0 +1,2 @@
+#/clone/user/login.lpc
+dbase (["email":"qinfengwu@example.com","password":"$6$En4qiVC8gxqNu/aS$m1U6jw8n.9QL3d5idQ.z.rzgyaZe5oNIcee9TUGdReZ9.Frj1snWwnnClQ40zZd600POwYqqPsHv62QN5eVm61","id":"qinfengwu","body":"/clone/user/user","name":"秦风戊",])
diff --git a/libs/xo/work/data/user/q/qinfengding.o b/libs/xo/work/data/user/q/qinfengding.o
@@ -0,0 +1,3 @@
+#/clone/user/user.lpc
+dbase (["sen":100,"title":"普通百姓","dex":16,"water":240,"birthday":1784949757,"per":14,"channels":({"chat","rumor","family",}),"race":"人类","kee":200,"gender":"男性","startroom":"/d/city/yangzhou/keyu","max_age":84,"con":15,"last_save_time":1784952953,"max_gin":100,"cor":19,"spi":23,"max_kee":200,"mud_age":6,"name":"秦风丁","int":19,"eff_gin":100,"id":"qinfengding","cps":16,"food":240,"hydra":(["desert":(["from":"中原",]),]),"kar":27,"xli_marks":(["havecard":1,]),"eff_sen":100,"max_force":0,"age":14,"eff_kee":200,"str":14,"max_sen":100,"gin":100,])
+AutoLoad ({})
diff --git a/libs/xo/work/data/user/q/qinfengwu.o b/libs/xo/work/data/user/q/qinfengwu.o
@@ -0,0 +1,3 @@
+#/clone/user/user.lpc
+dbase (["int":23,"eff_gin":100,"sen":100,"title":"普通百姓","id":"qinfengwu","dex":15,"water":327,"cps":22,"channels":({"chat","rumor","family",}),"per":18,"birthday":1784950630,"food":327,"race":"人类","hydra":(["desert":(["from":"中原",]),]),"kee":200,"xli_marks":(["havecard":1,]),"gender":"女性","kar":19,"max_age":89,"last_save_time":1784952775,"con":19,"eff_sen":100,"max_force":0,"age":14,"max_gin":100,"eff_kee":200,"str":23,"cor":31,"spi":18,"max_kee":200,"max_sen":100,"name":"秦风戊","mud_age":300,"gin":100,])
+AutoLoad ({(/"/clone/money/coin","200",/),})
diff --git a/libs/xo/work/system/skill/basic/kongshou.lpc b/libs/xo/work/system/skill/basic/kongshou.lpc
@@ -34,7 +34,8 @@ int valid_lian(object me) {
   return 0;
 }
 
-// 这个函数用来区别这种天生的技能与其他后天学习的技能int is_native_skill()
+// 这个函数用来区别这种天生的技能与其他后天学习的技能
+int is_native_skill()
 {
   return 1;
 }
diff --git a/libs/xo/work/system/skill/misc/taizu-quan.lpc b/libs/xo/work/system/skill/misc/taizu-quan.lpc
@@ -178,8 +178,8 @@ mapping *action = ({
                 "damage":                15,
                 "damage_type":  "瘀伤"
         ]),
-        ([      "zhaoshi": "「英 雄 独 立　,
-                "action":               
+        ([      "zhaoshi": "「英 雄 独 立」",
+                "action":
 "$N左腿撑直、成弓箭步站定,右拳原地翻掌、向前刺出\n"
 "接著、左腿向前上撩而出,同时、左手反掌、由右掌上方直穿而出\n",
                 "lian" :
diff --git a/libs/xo/work/system/skill/misc/yuanyang-dao.lpc b/libs/xo/work/system/skill/misc/yuanyang-dao.lpc
@@ -30,7 +30,7 @@ mapping	* action=({
         "dodge" :20,
         "damage":30,
         "damage_type":"割伤"    ]),
-    ([  "action":"又见$N高高跃起，一式「柳丝随风」，刀刃飘忽不定，切向$n$l,
+    ([  "action":"又见$N高高跃起，一式「柳丝随风」，刀刃飘忽不定，切向$n$l",
         "lian"  :"$N身形乍展，高高跃起，一式「柳丝随风」，刀刃飘忽不定。",
         "jibie" :33,
         "zhaoshi":"柳丝随风",

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+#/clone/user/login.lpc`
	`2`	`+dbase (["email":"qinfengding@example.com","password":"$6$Of/bkkeoQSZaAyXA$PYm1MhJ2oufZmKXM1ExJ72Jrzx4QugPJQ9TIdCxB2Wj5y1bTh0dU3VC4MAgDm4hRAzoEuAnKbGFOHGT0mTfZr.","id":"qinfengding","body":"/clone/user/user","name":"秦风丁",])`