Commit 387cc04
Fix 4 bugs found in jinyongqunxiazhuan2008_std's deep functional test
Same engine-level shapes as sibling jinyongqunxiazhuan2008 (byte-identical
pre-fix), all live-reproduced independently on this lib:
- adm/daemons/chinesed.lpc: §7.7 -- unguarded restore() on corrupted
seed data crashed dict to raw 0, breaking every xue/cha call.
- adm/daemons/combatd.lpc, cmds/std/kill.lpc, cmds/skill/{bai,
apprentice}.lpc: §7.11 -- missing /log/nosave/ directory crashed
killer_reward() uncaught mid-die(), a real death softlock. Fixed
with assure_file().
- cmds/skill/{bai,apprentice}.lpc: a misplaced parenthesis passed a
boolean into query() instead of a string key, permanently disabling
a defection-counter branch; also added a stringp() guard before
atoi() on the same read.
- adm/simul_efun/message.lpc: §7.12 -- tell_room()'s 2-arg form passed
bare int 0 as exclude. Live-reproduced via a direct user_dump(1) call
throwing inside the net-dead branch, silently disabling the entire
net-dead force-quit safety net (29 call sites across 16 files use the
vulnerable form).
The death/reincarnation startroom-write discriminator from the sibling's
retracted false positive was applied explicitly to d/city/wumiao.lpc and
d/death/gate.lpc here too (both target rooms carry valid_startroom,
consistent with intentional design) plus a sweep of 28 other
set("startroom"...) sites -- no further instances of the real bug found.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VyQCUoTo1Z93Py9aVFHQi11 parent 8fa1d90 commit 387cc04
10 files changed
Lines changed: 393 additions & 8 deletions
File tree
- libs/jinyongqunxiazhuan2008_std
- work
- adm
- daemons
- simul_efun
- cmds
- skill
- std
- data
- login/s
- user
- f
- s
Large diffs are not rendered by default.
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
| 28 | + | |
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
717 | 717 | | |
718 | 718 | | |
719 | 719 | | |
| 720 | + | |
720 | 721 | | |
721 | 722 | | |
722 | 723 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| |||
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| 65 | + | |
65 | 66 | | |
66 | 67 | | |
67 | 68 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| 65 | + | |
65 | 66 | | |
66 | 67 | | |
67 | 68 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
| 37 | + | |
37 | 38 | | |
38 | 39 | | |
| 40 | + | |
39 | 41 | | |
40 | 42 | | |
41 | 43 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
0 commit comments