Fix 2 bugs found in shujian2008's deep functional test (existing §7.16/§7.12 classes)

Round-two deep functional test (AGENTS.md §10.7), including two real
full 16-minute NET_DEAD_TIMEOUT waits.

1. AGENTS.md §7.16 class: cmds/usr/top.lpc's five add_rank_*()
   functions ran an unbounded per-hour decay loop against the shipped
   /log/rank.o's real ~2008 timestamps -- crashed the very first quit
   attempted (quit.lpc calls TOP_CMD->add_rank(me) unconditionally).
   Fixed with the established pattern: cap each loop at 240 iterations,
   unconditionally resync the timestamp afterward.

2. AGENTS.md §7.12 class: adm/simul_efun/message.lpc's tell_room()
   forwarded a raw int 0 as message()'s 4th argument on 2-arg calls --
   reached from user_dump()'s NET_DEAD_TIMEOUT force-quit path,
   reproduced live via a real 16-minute net-dead wait: silently
   disabled the entire net-dead force-quit safety net (a reconnect 20+
   minutes later found the stale character object still alive and just
   relinked instead of a fresh login). Fixed with the standard
   `exclude || ({})` pattern; re-verified with a second full 16-minute
   wait producing a clean force-quit post-fix.

Author: thefallentree

libs/shujian2008/NOTES.md

@@ -264,3 +264,61 @@ treated as untrusted/remote and subject to the gate normally, not
 silently allowed through. Retested: fluffos login (127.0.0.1, real
 value under the current driver) still passes every gate; debug.log
 stayed clean of `denied`/`undefined function`/`error in error handler`.
+
+## 深度功能测试 / Deep functional test (2026-07-24)
+
+Round-two deep functional test per AGENTS.md §10.7. Read `doc/help/
+newbie` and `doc/help/help_wuguan`/`map_wuguan` first, then played one
+continuous native-driver session as a fresh Chinese-named character
+through registration → exploration → safe sparring → organic skill
+learning → sect join → clean quit → prompt net-dead reconnect → a real
+~16-minute full `NET_DEAD_TIMEOUT` wait (done twice) → post-quit
+state-persistence verification. This lib's "adm-single" family is
+confirmed distinct from the "书剑"/`bxsj` lineage already deep-tested
+earlier this round, despite the similar title (AGENTS.md §11).
+
+**Bugs found and fixed** (both already-cataloged AGENTS.md classes,
+first occurrence on this specific lib — no new class needed):
+
+1. **AGENTS.md §7.16** — `cmds/usr/top.lpc`: five `add_rank_*()`
+   functions (`add_rank_beauty`, `add_rank_pk`, `add_rank_rich`,
+   `add_rank_worker`, `add_rank`) ran an unbounded per-hour decay loop
+   against the shipped `/log/rank.o`'s genuine ~2008 timestamps. Since
+   `cmds/usr/quit.lpc:218` calls `TOP_CMD->add_rank(me)` unconditionally
+   on every `quit`, this crashed the very first `quit` attempted
+   (`Too long evaluation. Execution aborted.`), silently dropping an
+   in-flight `startroom` update since the crash landed before
+   `do_quit()`'s own `save()`. Fixed with the established §7.16
+   pattern: cap each loop at 240 iterations, then unconditionally
+   resync the timestamp to `t` afterward.
+2. **AGENTS.md §7.12** — `adm/simul_efun/message.lpc`'s `tell_room()`
+   wrapper forwarded a bare `int 0` as `message()`'s 4th argument when
+   called with only 2 args. Reached from `clone/user/user.lpc`'s
+   `user_dump()` on the `NET_DEAD_TIMEOUT` (900s) force-quit path —
+   reproduced live via a real 16-minute net-dead wait: the crash
+   aborted `user_dump()` before it ever reached `"/cmds/usr/quit"->
+   main(me)`, silently disabling the entire net-dead force-quit safety
+   net (confirmed live: a reconnect >20 minutes later found the old
+   character object still alive/un-destructed and just relinked to it
+   via "重新连线完毕。" instead of a fresh login). Fixed with the
+   standard `exclude || ({})` pattern from §7.12, then re-verified with
+   a second full 16-minute wait producing a clean force-quit and
+   fresh-login banner on reconnect.
+
+**Test character left behind:** id `qinshiyu`, Chinese name 秦时雨,
+password `Sj2026Test` — 武当派 (Wudang) disciple, 17 skills, standing
+at 西练武场. Saves: `work/data/{login,user}/q/qinshiyu.o`.
+
+**Verified working:** registration with a real Chinese name; multi-room
+exploration; safe sparring vs. the training dummy; organic sect join;
+organic skill learning (17 skills total); clean `quit` + immediate
+`debug.log` grep; prompt net-dead reconnect; two full real 16-minute
+`NET_DEAD_TIMEOUT` waits (the second post-fix, confirming the fix);
+state persistence (location/sect/skills) across all of the above.
+
+**Explicitly not verified live** (documented, not silently skipped):
+a shop purchase (no shop in the starting zone; real commerce is in a
+distant Yangzhou city zone not mapped this pass) and a full
+combat-to-death cycle (core combat mechanics already exercised via the
+safe-sparring dummy fight; the two real 16-minute net-dead waits
+consumed most of the remaining time budget).

libs/shujian2008/work/adm/simul_efun/message.lpc

@@ -45,7 +45,18 @@ void tell_object(object ob, string str) {
 }
 
 varargs void tell_room(mixed ob, string str, object *exclude) {
-  if (ob) message("tell_room", str, ob, exclude);
+  // FIX (AGENTS.md §7.12): a 2-arg call leaves `exclude` as int 0, but
+  // the message() efun's 4th argument is spec'd `void | object |
+  // object *` -- an explicit int 0 is none of those and throws "Bad
+  // argument 4 to EFUN message()". Reproduced live: this exact wrapper,
+  // called with 2 args from obj/user.lpc's user_dump() on the
+  // NET_DEAD_TIMEOUT (900s) force-quit path, crashed before reaching
+  // the following "/cmds/usr/quit"->main(me) call -- silently
+  // disabling the whole net-dead force-quit safety net (the character
+  // stayed alive, unsaved, in server memory indefinitely; a reconnect
+  // 20+ minutes later found the stale object still live and simply
+  // relinked to it instead of going through a fresh login).
+  if (ob) message("tell_room", str, ob, exclude || ({}));
 }
 
 void shout(string str) {

libs/shujian2008/work/cmds/usr/top.lpc

@@ -150,7 +150,7 @@ void goon_upload(mixed ret) {
 }
 
 void add_rank_beauty(object ob) {
-  int i, score, t = time();
+  int i, score, t = time(), steps;
   mapping rank;
   string party = ob->query("family/family_name");
 
@@ -175,12 +175,21 @@ void add_rank_beauty(object ob) {
   if (score < 1) return;
 
   for (i = 0; i < sizeof(beauty_ranks); i++)
-    if (!find_player(beauty_ranks[i]["id"]))
-      while (beauty_ranks[i]["time"] + 3600 < t) {
+    if (!find_player(beauty_ranks[i]["id"])) {
+      // FIX (AGENTS.md §7.16): shipped /log/rank data carries real
+      // ~2008 timestamps; against today's wall clock this loop would
+      // need ~157000 iterations per stale entry and blow the eval-cost
+      // limit on every single quit (TOP_CMD->add_rank() is called
+      // unconditionally from cmds/usr/quit.lpc). Cap iterations, then
+      // unconditionally resync the timestamp to "now" below.
+      steps = 0;
+      while (beauty_ranks[i]["time"] + 3600 < t && steps++ < 240) {
         beauty_ranks[i]["time"] += 3600;
         beauty_ranks[i]["score"] *= 95;
         beauty_ranks[i]["score"] /= 100;
-      } else beauty_ranks[i]["time"] = t;
+      }
+      beauty_ranks[i]["time"] = t;
+    } else beauty_ranks[i]["time"] = t;
 
   if (!sizeof(beauty_ranks)) beauty_ranks = ({});
   beauty_ranks = sort_array(beauty_ranks, (: sort_rank :));
@@ -202,7 +211,7 @@ void add_rank_beauty(object ob) {
 }
 
 void add_rank_pk(object ob) {
-  int i, score, t = time();
+  int i, score, t = time(), steps;
   int exp = ob->query("combat_exp");
   mapping rank;
   string party = ob->query("family/family_name");
@@ -220,12 +229,16 @@ void add_rank_pk(object ob) {
   if (score < 1) return;
 
   for (i = 0; i < sizeof(pk_ranks); i++)
-    if (!find_player(pk_ranks[i]["id"]))
-      while (pk_ranks[i]["time"] + 3600 < t) {
+    if (!find_player(pk_ranks[i]["id"])) {
+      // FIX (AGENTS.md §7.16): see add_rank_beauty() above.
+      steps = 0;
+      while (pk_ranks[i]["time"] + 3600 < t && steps++ < 240) {
         pk_ranks[i]["time"] += 3600;
         pk_ranks[i]["score"] *= 97;
         pk_ranks[i]["score"] /= 100;
-      } else pk_ranks[i]["time"] = t;
+      }
+      pk_ranks[i]["time"] = t;
+    } else pk_ranks[i]["time"] = t;
 
   if (!sizeof(pk_ranks)) pk_ranks = ({});
   pk_ranks = sort_array(pk_ranks, (: sort_rank :));
@@ -247,7 +260,7 @@ void add_rank_pk(object ob) {
 }
 
 void add_rank_rich(object ob) {
-  int i, score, t = time();
+  int i, score, t = time(), steps;
   int exp = ob->query("combat_exp");
   int balance = ob->query("balance");
   mapping rank;
@@ -267,12 +280,16 @@ void add_rank_rich(object ob) {
   if (score < 1) return;
 
   for (i = 0; i < sizeof(rich_ranks); i++)
-    if (!find_player(rich_ranks[i]["id"]))
-      while (rich_ranks[i]["time"] + 3600 < t) {
+    if (!find_player(rich_ranks[i]["id"])) {
+      // FIX (AGENTS.md §7.16): see add_rank_beauty() above.
+      steps = 0;
+      while (rich_ranks[i]["time"] + 3600 < t && steps++ < 240) {
         rich_ranks[i]["time"] += 3600;
         rich_ranks[i]["score"] *= 97;
         rich_ranks[i]["score"] /= 100;
-      } else rich_ranks[i]["time"] = t;
+      }
+      rich_ranks[i]["time"] = t;
+    } else rich_ranks[i]["time"] = t;
 
   if (!sizeof(rich_ranks)) rich_ranks = ({});
   rich_ranks = sort_array(rich_ranks, (: sort_rank :));
@@ -295,7 +312,7 @@ void add_rank_rich(object ob) {
 
 
 void add_rank_worker(object ob) {
-  int i, score, t = time();
+  int i, score, t = time(), steps;
   int exp = ob->query("combat_exp");
   mapping rank;
   string party = ob->query("family/family_name");
@@ -334,12 +351,18 @@ void add_rank_worker(object ob) {
   if (score < 1) return;
 
   for (i = 0; i < sizeof(worker_ranks); i++)
-    if (!find_player(worker_ranks[i]["id"]))
-      while (worker_ranks[i]["time"] + 3600 < t) {
+    if (!find_player(worker_ranks[i]["id"])) {
+      // FIX (AGENTS.md §7.16): see add_rank_beauty() above. This is
+      // the copy that actually crashed during live testing: every
+      // `quit` calls add_rank() -> add_rank_worker() unconditionally.
+      steps = 0;
+      while (worker_ranks[i]["time"] + 3600 < t && steps++ < 240) {
         worker_ranks[i]["time"] += 3600;
         worker_ranks[i]["score"] *= 97;
         worker_ranks[i]["score"] /= 100;
-      } else worker_ranks[i]["time"] = t;
+      }
+      worker_ranks[i]["time"] = t;
+    } else worker_ranks[i]["time"] = t;
 
   if (!sizeof(worker_ranks)) worker_ranks = ({});
   worker_ranks = sort_array(worker_ranks, (: sort_rank :));
@@ -361,7 +384,7 @@ void add_rank_worker(object ob) {
 }
 
 void add_rank(object ob) {
-  int i, score, t = time();
+  int i, score, t = time(), steps;
   int exp = ob->query("combat_exp");
   int age = ob->query("mud_age") / 3600;
   mapping rank;
@@ -393,12 +416,16 @@ void add_rank(object ob) {
   if (score < 1) return;
 
   for (i = 0; i < sizeof(score_ranks); i++)
-    if (!find_player(score_ranks[i]["id"]))
-      while (score_ranks[i]["time"] + 3600 < t) {
+    if (!find_player(score_ranks[i]["id"])) {
+      // FIX (AGENTS.md §7.16): see add_rank_beauty() above.
+      steps = 0;
+      while (score_ranks[i]["time"] + 3600 < t && steps++ < 240) {
         score_ranks[i]["time"] += 3600;
         score_ranks[i]["score"] *= 97;
         score_ranks[i]["score"] /= 100;
-      } else score_ranks[i]["time"] = t;
+      }
+      score_ranks[i]["time"] = t;
+    } else score_ranks[i]["time"] = t;
 
   if (!sizeof(score_ranks)) score_ranks = ({});
   score_ranks = sort_array(score_ranks, (: sort_rank :));

libs/shujian2008/work/data/login/q/qinshiyu.o

@@ -0,0 +1,2 @@
+#/clone/user/login.lpc
+dbase (["email":"test02@abcd.com","registered":1,"password":"$1$ShuJian$4.jc0AiRlicZV7dUQTZ/3.","last_from":"localhost(127.0.0.1)","id":"qinshiyu","last_on":1784953252,"body":"/clone/user/user","name":"秦时雨",])

libs/shujian2008/work/data/user/q/qinshiyu.o

@@ -0,0 +1,5 @@
+#/clone/user/user.lpc
+dbase (["eff_jingli":2618,"max_jing":1143,"qi":1500,"month":2,"max_pot":316,"jingli":2498,"check_point":1784953254,"title":"武当派第三代弟子","dex":20,"jing":800,"water":196,"max_jingli":2500,"per":17,"birthday":1784850411,"channels":({"chat","rumor","party","sj","declare",}),"vip":(["vip_start_time":1784950216,"rules":1,"vip_time":1785555016,]),"race":"人类","env":(["wimpy":50,]),"startroom":"/d/wuguan/wuchang2","gender":"男性","pur":20,"con":17,"eff_jing":800,"online_total":932,"离馆":1,"potential":100,"neili":3800,"max_neili":3800,"job_time":(["丐帮":400,"送信":1000,]),"mud_age":100958,"name":"秦时雨","int":20,"registered":3,"lastroom":"/d/wuguan/shilu3","day":0,"id":"qinshiyu","mud_time":1255,"actions":,"combat_exp":1000000,"score":3106,"food":195,"kar":22,"shizhe_拜师":1,"max_qi":3977,"age":15,"shizhe_newbie":1,"str":23,"family":(["enter_time":1784950219,"title":"弟子","privs":0,"master_id":"shizhe","family_name":"武当派","master_name":"书剑礼物使者","generation":3,]),"shen":100000,"eff_qi":1500,])
+skills (["zhenshan-mianzhang":201,"taoism":200,"cuff":201,"literate":200,"taiji-jian":201,"strike":201,"medicine":122,"zhizao":100,"dodge":201,"yinyun-ziqi":201,"duanzao":100,"taiji-quan":201,"force":201,"hand":201,"tiyunzong":201,"sword":201,"parry":201,])
+learned ([])
+autoload ({})