Fix "can't do command after register" report + 2 more bugs in hymud

Root-caused the live player report from earlier this session ("Hymud
after register can't do command", the ?. symptom): AGENTS.md §7.10 --
adm/single/master.lpc's log_error() gated "is this just a compile
warning" on strsrch(message, "Warning") (capital W), but this driver's
own diagnostics always emit lowercase "warning: ". Every routine compile
warning (chiefly harmless unused-local-variable warnings, common here)
got broadcast to whichever player was online as a raw "?." -- clustering
around registration/first-login because that's when the most newbie-zone
files get lazily compiled for the first time. Same class already found
on lineage siblings shenzhou/beimeixiakexing2001; simply never ported
here. Verified live: zero "?." across half a dozen subsequent
connect/reconnect cycles.

Also fixed, surfaced once the warning-suppression bug stopped masking
them:
- §7.35: 6 NPC files passed an object where is_killing() takes a
  string, a silent no-op via -> that meant these NPCs' "revealed"
  ambush logic never worked.
- §7.36: feature/clean_up.lpc's interactive()-only occupancy check
  could destroy a room a net-dead player was still standing in; added
  userp() plus defense-in-depth environment() guards in clone/user/
  user.lpc's net-dead/idle handlers.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VyQCUoTo1Z93Py9aVFHQi1

Author: thefallentree

libs/hymud/NOTES.md

@@ -171,7 +171,22 @@ void log_error(string file, string message)
     if (name) home = user_path(name);
     else home = LOG_DIR;
 
-    if (strsrch(message, "Warning") < 0)
+    // AGENTS.md §7.10: the driver's own compile diagnostics use a
+    // LOWERCASE "warning: " prefix (see fluffos compiler.cc), not the
+    // "Warning" this check was originally written against (an old
+    // MudOS-era convention). The case mismatch meant this branch never
+    // recognized a warning as a warning, so every routine compile
+    // warning (e.g. "unused local variable", extremely common in this
+    // lib) was broadcast to whichever player happened to be online at
+    // the time a file got lazily compiled -- as a raw "?." to ordinary
+    // players (get_config(__DEFAULT_ERROR_MESSAGE__)) or a scary fake
+    // "编译时段错误" to wizards. This is what live players were
+    // reporting as "some commands stop working after registration": a
+    // burst of newbie-zone files (jing.lpc, hua.lpc, qian.lpc, look.lpc,
+    // ...) get compiled for the first time right after landing in
+    // 世界之树, each with its own unused-variable warnings, each firing
+    // a spurious "?." that looks exactly like a failed command.
+    if (strsrch(message, "Warning") < 0 && strsrch(message, "warning") < 0)
     {
         if (this_player(1))
         {

libs/hymud/work/adm/single/master.lpc

@@ -161,7 +161,7 @@ int do_go(string arg)
         mapping exit;
         if( !mapp(exit = environment()->query("exits")) || undefinedp(exit[arg]) )
                 return 0;
-        if (is_killing(this_player()))
+        if (is_killing(this_player()->query("id")))
                 if (random(10)<=2) {
                         message_vision(YEL "$N见势不好，转身要走，被$n"+YEL+"一把拦在面前。想走？没那么容易！\n"NOR, this_player(), this_object());
                         return 1;
@@ -175,7 +175,7 @@ int do_kill(string arg)
    if (id(arg))
   {
     set("kill_ob",1);
-    if (!is_killing(this_player()))
+    if (!is_killing(this_player()->query("id")))
     message_vision("$N"+CYN+"恶狠狠地瞪了$n一眼：想和我打？你活腻了？\n" NOR,this_object(),this_player());
     set("eff_qi",query("max_qi"));
     set("eff_jing",query("max_jing"));

libs/hymud/work/clone/demogorgon.lpc

@@ -161,7 +161,7 @@ int do_go(string arg)
         mapping exit;
         if( !mapp(exit = environment()->query("exits")) || undefinedp(exit[arg]) )
                 return 0;
-        if (is_killing(this_player()))
+        if (is_killing(this_player()->query("id")))
                 if (random(10)<=2) {
                         message_vision(YEL "$N见势不好，转身要走，被$n"+YEL+"一把拦在面前。想走？没那么容易！\n"NOR, this_player(), this_object());
                         return 1;
@@ -175,7 +175,7 @@ int do_kill(string arg)
    if (id(arg))
   {
     set("kill_ob",1);
-    if (!is_killing(this_player()))
+    if (!is_killing(this_player()->query("id")))
     message_vision("$N"+CYN+"恶狠狠地瞪了$n一眼：想和我打？你活腻了？\n" NOR,this_object(),this_player());
     set("eff_qi",query("max_qi"));
     set("eff_jing",query("max_jing"));

libs/hymud/work/clone/npc/demogorgon.lpc

@@ -75,8 +75,12 @@ private void user_dump(int type)
 {
 	switch(type) {
 		case DUMP_NET_DEAD:
-			tell_room( environment(), query("name") + "断线超过 "
-				+ NET_DEAD_TIMEOUT/60 + " 分钟，自动退出这个世界。\n");
+			// AGENTS.md §7.36 defense in depth: don't let a corrupted
+			// (destructed-out-from-under-us) environment() block the
+			// actual save/quit below.
+			if( objectp(environment()) )
+				tell_room( environment(), query("name") + "断线超过 "
+					+ NET_DEAD_TIMEOUT/60 + " 分钟，自动退出这个世界。\n");
                         "/cmds/usr/quitgame"->main(this_object());
 //			command("quitgame");
 			break;
@@ -86,8 +90,10 @@ private void user_dump(int type)
                          {
 			tell_object( this_object(), "对不起，您已经发呆超过 "
 				+ IDLE_TIMEOUT/60 + " 分钟了，请下次再来。\n");
-			tell_room( environment(), "一阵风吹来，将发呆中的" + query("name")
-				+ "化为一堆飞灰，消失了。\n", ({this_object()}));
+			// AGENTS.md §7.36 defense in depth, same as DUMP_NET_DEAD above.
+			if( objectp(environment()) )
+				tell_room( environment(), "一阵风吹来，将发呆中的" + query("name")
+					+ "化为一堆飞灰，消失了。\n", ({this_object()}));
                         "/cmds/usr/quitgame"->main(this_object());
 //			command("quitgame");
                         }
@@ -123,6 +129,8 @@ call_out("user_dump", 1, DUMP_NET_DEAD);
 }else		call_out("user_dump", NET_DEAD_TIMEOUT, DUMP_NET_DEAD);
 if (this_object())
 {
+	    // AGENTS.md §7.36 defense in depth, same as user_dump() above.
+	    if( objectp(environment()) )
 	    tell_room(environment(), query("name") + "断线了。", this_object());
 	    CHANNEL_D->do_channel(this_object(), "sys", "断线了。");
 }

libs/hymud/work/clone/user/user.lpc

@@ -53,7 +53,7 @@ string ask_me(object who)
 	object *ob;
 
 	if( query("revealed") ) {
-		if( is_killing(who) ) return "你既然知道了我的身分，今日休想活命！\n";
+		if( is_killing(who->query("id")) ) return "你既然知道了我的身分，今日休想活命！\n";
 		else {
 			kill_ob(who);
 			who->fight_ob(this_object());

libs/hymud/work/d/city/npc/guidao.lpc

@@ -50,7 +50,7 @@ int ask_me(object who)
 	object *ob;
 
 	if( query("revealed") ) {
-        if( is_killing(who) ) return notify_fail("你既然知道了我的身分，今日休想活命！\n");
+        if( is_killing(who->query("id")) ) return notify_fail("你既然知道了我的身分，今日休想活命！\n");
 		else {
 			kill_ob(who);
 			who->fight_ob(this_object());

libs/hymud/work/d/ny/npc/guard.lpc

@@ -56,7 +56,7 @@ string ask_me(object who)
 	object *ob;
 
 	if( query("revealed") ) {
-		if( is_killing(who) ) return "你既然知道了我的秘密，今日休想活命！\n";
+		if( is_killing(who->query("id")) ) return "你既然知道了我的秘密，今日休想活命！\n";
 		else {
 			kill_ob(who);
 			who->fight_ob(this_object());

libs/hymud/work/d/xiangyang/npc/xiaosong.lpc

@@ -49,7 +49,7 @@ string ask_me(object who)
 	object *ob;
 
 	if( query("revealed") ) {
-		if( is_killing(who) ) return "你既然知道了我的身分，今日休想活命！\n";
+		if( is_killing(who->query("id")) ) return "你既然知道了我的身分，今日休想活命！\n";
 		else {
 			kill_ob(who);
 			who->fight_ob(this_object());

libs/hymud/work/d/xueting/npc/liuanlu.lpc

@@ -20,7 +20,11 @@ if ( this_object()->query("maze") ) return 1;
 
 	inv = all_inventory();
 	for(i=sizeof(inv)-1; i>=0; i--)
-		if(interactive(inv[i])) return 1;
+		// AGENTS.md §7.36: interactive() alone is false for a net-dead
+		// player (socket gone, body/save state still real and
+		// reconnectable) -- also check userp() so a room holding only a
+		// net-dead player isn't swept out from under them.
+		if(interactive(inv[i]) || userp(inv[i])) return 1;
 
 	destruct(this_object());
 	return 0;