Fix 6 bug classes + repair corrupted save data found in fy2's deep functional test

- adm/simul_efun/message.lpc: §7.12 tell_room() exclude-arg fix.
- d/death/inn1.lpc, d/death/npc/{bgargoyle,wgargoyle}.lpc: §7.24 fix,
  same shape as sibling zzfy's already-fixed instance.
- std/room.lpc: §7.25 fix -- make_inventory() now catch()es new()
  throwing (reproduced live: a skill file gap crashed a room's entire
  first population), plus an objectp() guard at its call site.
- feature/command.lpc: §7.28 fix -- enable_player()'s add_action
  stacking; revive() fires on every ordinary combat knockout, not just
  death.
- std/bboard.lpc, std/jboard.lpc: new instances of catch()-guarding
  restore()/move() (§7.7-adjacent) so one corrupted/stale board can't
  take out the room or object that loads it.
- adm/daemons/emoted.lpc: same restore()-throws-uncaught shape,
  disabling the entire emote-command system mudlib-wide.
- New bug class: d/waterfog/{hall1,jobroom}.lpc, obj/board/{wizard_b,
  wizard_j}.lpc, feature/alias.lpc hardcoded stale "/d/wiz/" paths left
  over from a zone rename to "/d/waterfog/" -- broken exits, a board
  that couldn't load into its room, and an anti-bot teleport that
  silently dropped the accused player into environment 0.
- Repaired 3 corrupted save-data files (data/emoted.o, data/board/
  {fysquare_b,poem_b}.o): raw un-transcoded GBK bytes (conversion-
  pipeline gap) and, in poem_b.o, literal embedded newlines inside a
  string value -- verified against the driver's actual restore_object()
  parser (std::getline() splits strictly on '\n', so an embedded raw
  newline breaks that record) that this was genuinely unparseable, not
  just cosmetically odd.
- Removed data/emoted.lpc (a stray, unreferenced 2170-line duplicate
  of the same data misnamed with an .lpc extension -- an lpcc-sweep
  false-positive source) and two stale .o.new/.o.old debris files.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VyQCUoTo1Z93Py9aVFHQi1

Author: thefallentree

libs/fy2/NOTES.md

@@ -33,8 +33,19 @@ mapping emote;
 //	Original by Annihilator@ESII (11/09/94)
 
 void create() {
-  if (!restore() && !mapp(emote))
-    emote = ([]);
+  // BUG FIX (deep functional test, AGENTS.md §7.7): restore() on
+  // corrupted save data (confirmed live: data/emoted.o had raw
+  // un-transcoded GBK bytes plus one genuinely malformed byte pair --
+  // a conversion-pipeline gap, since fixed) used to throw uncaught
+  // here, aborting the REST of create() -- leaving BOTH "emote"
+  // unset (int 0, not even the "([])" fallback on the same line) AND
+  // "channel_id" never set at all, silently disabling the ENTIRE
+  // emote-command system (smile/nod/bow/... all became unrecognized
+  // commands) for the whole boot with zero visible error to any
+  // player. catch() so corrupt seed data degrades to an empty emote
+  // table instead of skipping the rest of create().
+  catch(restore());
+  if (!mapp(emote)) emote = ([]);
   set("channel_id", "动作精灵");
 }
 

libs/fy2/work/adm/daemons/emoted.lpc

@@ -32,7 +32,7 @@ void tell_object(object ob, string str) {
 }
 
 varargs void tell_room(mixed ob, string str, object *exclude) {
-  if (ob) message("tell_room", str, ob, exclude);
+  if (ob) message("tell_room", str, ob, exclude || ({ }));
 }
 
 void shout(string str) {

libs/fy2/work/adm/simul_efun/message.lpc

@@ -60,7 +60,11 @@ int do_stuff(object ob) {
   if (ob->is_ghost())
     ob->reincarnate();
   ob->move("/d/fy/church");
-  ob->set("startroom", base_name(environment(ob)));
+  // BUG FIX (deep functional test, AGENTS.md §7.24) -- see
+  // d/death/npc/bgargoyle.lpc for the full writeup; don't overwrite the
+  // permanent startroom field from this brief death/limbo waypoint --
+  // "/d/fy/church" doesn't carry the "valid_startroom" flag that
+  // cmds/usr/save.lpc requires before legitimately updating this field.
   message("vision",
     "你忽然发现前面多了一个人影，不过那人影又好像已经在那里\n" +
     "很久了，只是你一直没发觉。\n", environment(ob), ob);

libs/fy2/work/d/death/inn1.lpc

@@ -68,7 +68,18 @@ void death_stage(object ob, int stage) {
     ob->reincarnate();
 
   ob->move(revive_loc[random(sizeof(revive_loc))]);
-  ob->set("startroom", base_name(environment(ob)));
+  // BUG FIX (deep functional test, AGENTS.md §7.24): this used to
+  // unconditionally set the player's permanent login/respawn location
+  // (query("startroom"), read by adm/daemons/logind.lpc's enter_world()
+  // on every FUTURE full login) to whichever revive_loc waypoint the
+  // player randomly landed in here. Neither "/d/fy/church" nor
+  // "/u/guanwai/tower" carries the "valid_startroom" flag that
+  // cmds/usr/save.lpc (the only other place that legitimately updates
+  // this field) requires before doing the same thing -- this room is
+  // meant to be a brief death/limbo waypoint, not a permanent home. Fix:
+  // don't touch startroom here at all -- leave the player's real,
+  // previously-chosen (valid_startroom-flagged) login location intact;
+  // the move() above already handles the immediate post-death placement.
   message("vision",
     "你忽然发现前面多了一个人影，不过那人影又好像已经在那里\n"
     "很久了，只是你一直没发觉。\n", environment(ob), ob);

libs/fy2/work/d/death/npc/bgargoyle.lpc

@@ -58,7 +58,9 @@ void death_stage(object ob, int stage) {
     ob->reincarnate();
 
   ob->move(revive_loc[random(sizeof(revive_loc))]);
-  ob->set("startroom", base_name(environment(ob)));
+  // BUG FIX (deep functional test, AGENTS.md §7.24) -- see bgargoyle.lpc
+  // for the full writeup; don't overwrite the permanent startroom field
+  // from this brief death/limbo waypoint.
   message("vision",
     "你忽然发现前面多了一个人影，不过那人影又好像已经在那里\n"
     "很久了，只是你一直没发觉。\n", environment(ob), ob);

libs/fy2/work/d/death/npc/wgargoyle.lpc

@@ -9,9 +9,18 @@ void create() {
 选在这里举行，往东是巫师会客室。
 LONG
   );
+  // BUG FIX (deep functional test, AGENTS.md §7.18): these exits
+  // hardcoded the stale "/d/wiz/" path (visible in this file's own
+  // header comment) left over from before this zone was renamed to
+  // "/d/waterfog/" -- see d/waterfog/entrance.lpc, which already uses
+  // the correct __DIR__-relative form for this same zone. The stale
+  // paths made every exit here throw "call_other() couldn't find
+  // object" (confirmed via lpcc), and the same stale "/d/wiz/hall1"
+  // path in obj/board/wizard_b.lpc's "location" made this room's own
+  // force-loaded message board fail to move() into it.
   set("exits", ([ /* sizeof() == 2 */
-    "north": "/d/wiz/jobroom",
-    "east": "/d/wiz/entrance",
+    "north": __DIR__ "jobroom",
+    "east": __DIR__ "entrance",
   ]));
   set("no_clean_up", 0);
 

libs/fy2/work/d/waterfog/hall1.lpc

@@ -12,8 +12,11 @@ void create() {
 而降回玩家身分。
 LONG
   );
+  // BUG FIX (deep functional test, AGENTS.md §7.18) -- see
+  // d/waterfog/hall1.lpc for the full writeup; stale "/d/wiz/" path
+  // from before this zone was renamed to "/d/waterfog/".
   set("exits", ([ /* sizeof() == 1 */
-    "south": "/d/wiz/hall1",
+    "south": __DIR__ "hall1",
   ]));
   set("no_clean_up", 0);
 

libs/fy2/work/d/waterfog/jobroom.lpc

@@ -1,2 +1,2 @@
 #/std/bboard.c
-dbase (["capacity":30,"notes":({(["time":892909751,"msg":"����Ҳ.","author":"��ȸ��","title":"����Ҳ",]),(["time":892931695,"msg":"w,w,w,w,w,nǮ�ɲ����������Ҹ�ÿ������10gold","author":"����è","title":"������ҩ��",]),(["time":892983041,"msg":"���Ҳ���ʦ�����Ķ������ҿ��������8 [A","author":"���","title":"���ˣ�",]),(["time":893018069,"msg":"������ս����̫����,�����ϸ�������û����.","author":"���ξ�","title":"̫����",]),(["time":893103075,"msg":"distribute�ɷ��������","author":"��è","title":"distribute",]),(["time":893344053,"msg":"������ûǮ,������Ҳϴ����,��עλ��������,��ָм�..l;l [Dquit [D [D [D [B [B [A.","author":"����","title":"ûǮ",]),(["time":893416812,"msg":"hi,sbaa.sz fy �þò������ˣ�ԭ������������������*admire sbaa!ֻ��ϧ�ٶ�̫���ˣ�* cry","author":"��Ӧ��","title":"to sbaa",]),(["time":893435629,"msg":"��һֱ��Ϊ�����Դ����davis�ģ���ϸһ��ԭ�����ҵģ�sighsbaa����һ����ʦ��ô��","author":"ξ��ʮһ","title":"��֣�",]),(["time":894542088,"msg":" skills��Ŀǰ��ѧ�����ּ��ܣ���feixian-sword (feixian-sword)            - ��������  23/    0  force (force)                            - ��ͨƤë  18/    0��jingyiforce (jingyiforce)                - ��������  23/  254  leadership (leadership)                  - ��֪һ��  21/   81  literate (literate)                      - ��ѧէ��   9/   94  parry (parry)                            - ��ѧէ��   9/   12  strategy (strategy)                      - �����ž�  15/  165  sword (sword)                            - ��������  30/  107��ôȫ��E��?","author":"����","title":"��ô����Ӣ��",]),(["time":885977031,"msg":"eI have no money.","author":"С���","title":"10",]),(["time":885977089,"msg":"I have no money.","author":"С���","title":"10",]),(["time":896431444,"msg":"where are you ?","author":"����","title":"only me here",]),(["msg":"����û��˼!!!!!!!!!.","time":898596271,"author":"������","title":"û��˼",]),}),"location":"/d/fy/fysquare","long":"����һ���������Լ��µ����԰塣","id":"board","name":"���ƹ㳡���԰�","no_get":1,"board_id":"fysquare_b",])
+dbase (["capacity":30,"notes":({(["time":892909751,"msg":"我来也.","author":"风雀儿","title":"我来也",]),(["time":892931695,"msg":"w,w,w,w,w,n钱可不好挣啊，我给每个新人10gold","author":"机器猫","title":"现在有药了",]),(["time":892983041,"msg":"我找不到师父在哪儿，而且快俄死了。8 [A","author":"风儿","title":"完了！",]),(["time":893018069,"msg":"练功和战斗都太慢了,老是上个动作还没结束.","author":"公治九","title":"太慢了",]),(["time":893103075,"msg":"distribute可分配参数点","author":"老猫","title":"distribute",]),(["time":893344053,"msg":"我由于没钱,所以澡也洗不起,请注位大侠资助,万分感激..l;l [Dquit [D [D [D [B [B [A.","author":"天龙","title":"没钱",]),(["time":893416812,"msg":"hi,sbaa.sz fy 好久不见你了，原来在这里潇洒！！！*admire sbaa!只可惜速度太慢了！* cry","author":"方应看","title":"to sbaa",]),(["time":893435629,"msg":"我一直以为这里的源码是davis的，仔细一看原来是我的，sighsbaa给我一个巫师好么？","author":"尉迟十一","title":"奇怪？",]),(["time":894542088,"msg":" skills你目前共学过九种技能：＊feixian-sword (feixian-sword)            - 半生不熟  23/    0  force (force)                            - 粗通皮毛  18/    0＊jingyiforce (jingyiforce)                - 半生不熟  23/  254  leadership (leadership)                  - 略知一二  21/   81  literate (literate)                      - 新学乍用   9/   94  parry (parry)                            - 初学乍练   9/   12  strategy (strategy)                      - 初窥门径  15/  165  sword (sword)                            - 马马虎虎  30/  107怎么全是E文?","author":"阿福","title":"怎么成了英文",]),(["time":885977031,"msg":"eI have no money.","author":"小蝌蚪","title":"10",]),(["time":885977089,"msg":"I have no money.","author":"小蝌蚪","title":"10",]),(["time":896431444,"msg":"where are you ?","author":"明儿","title":"only me here",]),(["msg":"风云没意思!!!!!!!!!.","time":898596271,"author":"冷如玉","title":"没意思",]),}),"location":"/d/fy/fysquare","long":"这是一个供人留言记事的留言板。","id":"board","name":"风云广场留言版","no_get":1,"board_id":"fysquare_b",])

libs/fy2/work/data/board/fysquare_b.o

@@ -1,84 +1,2 @@
 #/std/bboard.c
-dbase (["location":"/d/fy/poemp","board_id":"poem_b","capacity":30,"id":"tai","long":"你可以在这里留下你的千古名句。
-","notes":({(["title":"雀儿到此一游","msg":"我自横刀向天笑,去留肝胆两昆仑.
-","time":892910849,"author":"风雀儿",]),(["title":"杰到此一游","msg":"
-save
-save
-
-
-save
-q
-'.'
-dsbr
-save
-save
-save
-save
-asv
-l
-l
-
-save
-
-
-save
-'.'
-'.'
-'.'
-q
-l
-post
-l board
-
-
-'.'
-
-
-
-
-
-
-
-
- 
- 
- 
- 
-	
-	
-
-QUITY
-
-/
- [B
-
-
-
-
-
-
-quit
-
-
-
-
-
-save
-q
-'.'
-'.'
-'.
-;
-'.'
-'.'
-'.;'
-`'`
-`/'
-'/`
-`/'
-/`
-/`
-`.'
-","time":893171478,"author":"杰",]),(["title":"啊","msg":"再上高处,望尽天涯路
-","time":893282037,"author":"风雀儿",]),(["title":"每日一诗1","msg":"锄禾日当午,汗滴禾下土.      谁知盘中餐,粒粒皆辛苦..
-","time":893591498,"author":"风雀儿",]),}),"no_get":1,"name":"探花诗台",])
+dbase (["location":"/d/fy/poemp","board_id":"poem_b","capacity":30,"id":"tai","long":"你可以在这里留下你的千古名句。","notes":({(["title":"雀儿到此一游","msg":"我自横刀向天笑,去留肝胆两昆仑.","time":892910849,"author":"风雀儿",]),(["title":"杰到此一游","msg":"savesavesaveq'.'dsbrsavesavesavesaveasvllsavesave'.''.''.'qlpostl board'.'    		QUITY/ [Bquitsaveq'.''.''.;'.''.''.;'`'``/''/``/'/`/``.'","time":893171478,"author":"杰",]),(["title":"啊","msg":"再上高处,望尽天涯路","time":893282037,"author":"风雀儿",]),(["title":"每日一诗1","msg":"锄禾日当午,汗滴禾下土.      谁知盘中餐,粒粒皆辛苦..","time":893591498,"author":"风雀儿",]),}),"no_get":1,"name":"探花诗台",])