Skip to content

Commit 07e566f

Browse files
xliuqqCopilot
andcommitted
Apply suggestions from code review
Signed-off-by: xliuqq <xlzq1992@gmail.com> Co-Authored-By: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent c89d18f commit 07e566f

3 files changed

Lines changed: 2 additions & 6 deletions

File tree

charts/fluid/fluid/templates/csi/validatingadmissionpolicy.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ spec:
2525
object.?metadata.name.orValue('')
2626
validations:
2727
- expression: "variables.userNodeName != ''"
28-
message: "userNodeName is empty, user token does not container node name."
28+
message: "userNodeName is empty, user token does not contain node name."
2929
- expression: "variables.objectNodeName == variables.userNodeName"
3030
messageExpression: >-
3131
"objectNodeName '" + variables.objectNodeName + "' is not equal to userNodeName '" + variables.userNodeName + "'"

pkg/csi/plugins/nodeserver.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -475,10 +475,6 @@ func (ns *nodeServer) getNode() (node *corev1.Node, err error) {
475475
return nil, err
476476
}
477477

478-
// if node, err = kubeclient.Get(ns.apiReader, ns.nodeId); err != nil {
479-
// return nil, err
480-
// }
481-
482478
glog.V(1).Infof("Got node %s from api server", node.Name)
483479
ns.node = node
484480
return ns.node, nil

pkg/utils/compatibility/node_restrict.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ func discoverNodeBindingTokenCompatibility() {
4343

4444
serverVersion, err := discoveryClient.ServerVersion()
4545
if err != nil && !errors.IsNotFound(err) {
46-
nativeLog.Fatalf("failed to discover batch/v1 group version: %v", err)
46+
nativeLog.Fatalf("failed to discover Kubernetes server version: %v", err)
4747
}
4848
// transform to semver.Version and compare
4949
currentVersion, err := semver.ParseTolerant(serverVersion.GitVersion)

0 commit comments

Comments
 (0)