fix unit tests

TrafalgarZZZ · TrafalgarZZZ · commit 47e92ede5f7c · 2025-07-23T00:14:39.000+08:00
Signed-off-by: trafalgarzzz &lt;trafalgarz@outlook.com&gt;
diff --git a/pkg/ddc/alluxio/create_volume_test.go b/pkg/ddc/alluxio/create_volume_test.go
@@ -39,6 +39,7 @@ import (
 // and one PVC are created after the function execution
 func TestCreateVolume(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", "alluxio")
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
@@ -134,6 +135,7 @@ func TestCreateVolume(t *testing.T) {
 // is created in the fake client.
 func TestCreateFusePersistentVolume(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", "alluxio")
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
@@ -186,6 +188,7 @@ func TestCreateFusePersistentVolume(t *testing.T) {
 func TestCreateFusePersistentVolumeClaim(t *testing.T) {
 	// Prepare runtime information for the AlluxioEngine.
 	runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", "alluxio")
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
diff --git a/pkg/ddc/alluxio/delete_volume_test.go b/pkg/ddc/alluxio/delete_volume_test.go
@@ -54,6 +54,7 @@ type TestCase struct {
 func newTestAlluxioEngine(client client.Client, name string, namespace string, withRunTime bool) *AlluxioEngine {
 	runTime := &datav1alpha1.AlluxioRuntime{}
 	runTimeInfo, _ := base.BuildRuntimeInfo(name, namespace, "alluxio")
+	runTimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if !withRunTime {
 		runTimeInfo = nil
 		runTime = nil
diff --git a/pkg/ddc/alluxio/runtime_info.go b/pkg/ddc/alluxio/runtime_info.go
@@ -65,6 +65,10 @@ func (e *AlluxioEngine) getRuntimeInfo() (base.RuntimeInfoInterface, error) {
 		}
 	}
 
+	if e.UnitTest {
+		return e.runtimeInfo, nil
+	}
+
 	// Handling information of bound dataset. XXXEngine.getRuntimeInfo() might be called before the runtime is bound to a dataset,
 	// so here we must lazily set dataset-related information once we found there's one bound dataset.
 	if len(e.runtimeInfo.GetOwnerDatasetUID()) == 0 {
diff --git a/pkg/ddc/goosefs/create_volume_test.go b/pkg/ddc/goosefs/create_volume_test.go
@@ -33,6 +33,7 @@ import (
 
 func TestCreateVolume(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", common.GooseFSRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
@@ -120,6 +121,7 @@ func TestCreateVolume(t *testing.T) {
 
 func TestCreateFusePersistentVolume(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", common.GooseFSRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
@@ -166,6 +168,7 @@ func TestCreateFusePersistentVolume(t *testing.T) {
 
 func TestCreateFusePersistentVolumeClaim(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", common.GooseFSRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
diff --git a/pkg/ddc/goosefs/delete_volume_test.go b/pkg/ddc/goosefs/delete_volume_test.go
@@ -41,6 +41,7 @@ type TestCase struct {
 func newTestGooseFSEngine(client client.Client, name string, namespace string, withRunTime bool) *GooseFSEngine {
 	runTime := &datav1alpha1.GooseFSRuntime{}
 	runTimeInfo, _ := base.BuildRuntimeInfo(name, namespace, common.GooseFSRuntime)
+	runTimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if !withRunTime {
 		runTimeInfo = nil
 		runTime = nil
diff --git a/pkg/ddc/jindo/create_volume_test.go b/pkg/ddc/jindo/create_volume_test.go
@@ -41,6 +41,7 @@ import (
 // 4. Proper setting of the fuse generation label on the created PVC.
 func TestCreateVolume(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", common.JindoRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
@@ -134,6 +135,7 @@ func TestCreateVolume(t *testing.T) {
 // - Checking that exactly one PersistentVolume has been created
 func TestCreateFusePersistentVolume(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", common.JindoRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
@@ -179,6 +181,7 @@ func TestCreateFusePersistentVolume(t *testing.T) {
 
 func TestCreateFusePersistentVolumeClaim(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", common.JindoRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
diff --git a/pkg/ddc/jindo/delete_volume_test.go b/pkg/ddc/jindo/delete_volume_test.go
@@ -41,6 +41,7 @@ type TestCase struct {
 func newTestJindoEngine(client client.Client, name string, namespace string, withRunTime bool) *JindoEngine {
 	runTime := &datav1alpha1.JindoRuntime{}
 	runTimeInfo, _ := base.BuildRuntimeInfo(name, namespace, common.JindoRuntime)
+	runTimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if !withRunTime {
 		runTimeInfo = nil
 		runTime = nil
diff --git a/pkg/ddc/jindocache/create_volume_test.go b/pkg/ddc/jindocache/create_volume_test.go
@@ -33,6 +33,7 @@ import (
 
 func TestCreateVolume(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", common.JindoRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
@@ -119,6 +120,7 @@ func TestCreateVolume(t *testing.T) {
 
 func TestCreateFusePersistentVolume(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", common.JindoRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
@@ -165,6 +167,7 @@ func TestCreateFusePersistentVolume(t *testing.T) {
 
 func TestCreateFusePersistentVolumeClaim(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", common.JindoRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
diff --git a/pkg/ddc/jindocache/delete_volume_test.go b/pkg/ddc/jindocache/delete_volume_test.go
@@ -41,6 +41,7 @@ type TestCase struct {
 func newTestJindoCacheEngine(client client.Client, name string, namespace string, withRunTime bool) *JindoCacheEngine {
 	runTime := &datav1alpha1.JindoRuntime{}
 	runTimeInfo, _ := base.BuildRuntimeInfo(name, namespace, common.JindoRuntime)
+	runTimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if !withRunTime {
 		runTimeInfo = nil
 		runTime = nil
diff --git a/pkg/ddc/jindofsx/create_volume_test.go b/pkg/ddc/jindofsx/create_volume_test.go
@@ -33,6 +33,7 @@ import (
 
 func TestCreateVolume(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", common.JindoRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
@@ -119,6 +120,7 @@ func TestCreateVolume(t *testing.T) {
 
 func TestCreateFusePersistentVolume(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", common.JindoRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
@@ -165,6 +167,7 @@ func TestCreateFusePersistentVolume(t *testing.T) {
 
 func TestCreateFusePersistentVolumeClaim(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", common.JindoRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
diff --git a/pkg/ddc/jindofsx/delete_volume_test.go b/pkg/ddc/jindofsx/delete_volume_test.go
@@ -41,6 +41,7 @@ type TestCase struct {
 func newTestJindoFSxEngine(client client.Client, name string, namespace string, withRunTime bool) *JindoFSxEngine {
 	runTime := &datav1alpha1.JindoRuntime{}
 	runTimeInfo, _ := base.BuildRuntimeInfo(name, namespace, common.JindoRuntime)
+	runTimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if !withRunTime {
 		runTimeInfo = nil
 		runTime = nil
diff --git a/pkg/ddc/juicefs/create_volume_test.go b/pkg/ddc/juicefs/create_volume_test.go
@@ -49,6 +49,7 @@ import (
 //   - No return value. If the test fails, errors will be reported via t.Errorf.
 func TestJuiceFSEngine_CreateVolume(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("juicefs", "fluid", common.JuiceFSRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
@@ -139,6 +140,7 @@ func TestJuiceFSEngine_CreateVolume(t *testing.T) {
 
 func TestJuiceFSEngine_createFusePersistentVolume(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("juicefs", "fluid", common.JuiceFSRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
@@ -185,6 +187,7 @@ func TestJuiceFSEngine_createFusePersistentVolume(t *testing.T) {
 
 func TestJuiceFSEngine_createFusePersistentVolumeClaim(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("juicefs", "fluid", common.JuiceFSRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
diff --git a/pkg/ddc/juicefs/delete_volume_test.go b/pkg/ddc/juicefs/delete_volume_test.go
@@ -52,6 +52,7 @@ func newTestJuiceEngine(client client.Client, name string, namespace string, wit
 	// 1. Create a JuiceFSRuntime and RuntimeInfo
 	runTime := &datav1alpha1.JuiceFSRuntime{}
 	runTimeInfo, _ := base.BuildRuntimeInfo(name, namespace, common.JuiceFSRuntime)
+	runTimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	// 2. If the JuiceFS engine does not have runtime, set the runtime and runtimeInfo to nil
 	if !withRunTime {
 		runTimeInfo = nil
diff --git a/pkg/ddc/thin/create_volume_test.go b/pkg/ddc/thin/create_volume_test.go
@@ -33,6 +33,7 @@ import (
 
 func TestThinEngine_CreateVolume(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("test", "fluid", common.ThinRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
@@ -123,6 +124,7 @@ func TestThinEngine_CreateVolume(t *testing.T) {
 
 func TestThinEngine_createFusePersistentVolume(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("thin", "fluid", common.ThinRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
@@ -175,6 +177,7 @@ func TestThinEngine_createFusePersistentVolume(t *testing.T) {
 
 func TestThinEngine_createFusePersistentVolumeClaim(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("test", "fluid", common.ThinRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
diff --git a/pkg/ddc/thin/delete_volume_test.go b/pkg/ddc/thin/delete_volume_test.go
@@ -41,6 +41,7 @@ type TestCase struct {
 func newTestThinEngine(client client.Client, name string, namespace string, withRunTime bool) *ThinEngine {
 	runTime := &datav1alpha1.ThinRuntime{}
 	runTimeInfo, _ := base.BuildRuntimeInfo(name, namespace, common.ThinRuntime)
+	runTimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if !withRunTime {
 		runTimeInfo = nil
 		runTime = nil
diff --git a/pkg/ddc/vineyard/create_volume_test.go b/pkg/ddc/vineyard/create_volume_test.go
@@ -30,6 +30,7 @@ import (
 
 func TestCreateVolume(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", common.VineyardRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
@@ -116,6 +117,7 @@ func TestCreateVolume(t *testing.T) {
 
 func TestCreateFusePersistentVolume(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", common.VineyardRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
@@ -162,6 +164,7 @@ func TestCreateFusePersistentVolume(t *testing.T) {
 
 func TestCreateFusePersistentVolumeClaim(t *testing.T) {
 	runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", common.VineyardRuntime)
+	runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if err != nil {
 		t.Errorf("fail to create the runtimeInfo with error %v", err)
 	}
diff --git a/pkg/ddc/vineyard/delete_volume_test.go b/pkg/ddc/vineyard/delete_volume_test.go
@@ -38,6 +38,7 @@ type TestCase struct {
 func newTestVineyardEngine(client client.Client, name string, namespace string, withRunTime bool) *VineyardEngine {
 	runTime := &datav1alpha1.VineyardRuntime{}
 	runTimeInfo, _ := base.BuildRuntimeInfo(name, namespace, common.VineyardRuntime)
+	runTimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")
 	if !withRunTime {
 		runTimeInfo = nil
 		runTime = nil

Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,10 @@ func (e *AlluxioEngine) getRuntimeInfo() (base.RuntimeInfoInterface, error) {`
`65`	`65`	`}`
`66`	`66`	`}`
`67`	`67`
	`68`	`+ if e.UnitTest {`
	`69`	`+ return e.runtimeInfo, nil`
	`70`	`+ }`
	`71`	`+`
`68`	`72`	`// Handling information of bound dataset. XXXEngine.getRuntimeInfo() might be called before the runtime is bound to a dataset,`
`69`	`73`	`// so here we must lazily set dataset-related information once we found there's one bound dataset.`
`70`	`74`	`if len(e.runtimeInfo.GetOwnerDatasetUID()) == 0 {`
Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ import (`
`33`	`33`
`34`	`34`	`func TestCreateVolume(t *testing.T) {`
`35`	`35`	`runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", common.GooseFSRuntime)`
	`36`	`+ runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")`
`36`	`37`	`if err != nil {`
`37`	`38`	`t.Errorf("fail to create the runtimeInfo with error %v", err)`
`38`	`39`	`}`
`@@ -120,6 +121,7 @@ func TestCreateVolume(t *testing.T) {`
`120`	`121`
`121`	`122`	`func TestCreateFusePersistentVolume(t *testing.T) {`
`122`	`123`	`runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", common.GooseFSRuntime)`
	`124`	`+ runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")`
`123`	`125`	`if err != nil {`
`124`	`126`	`t.Errorf("fail to create the runtimeInfo with error %v", err)`
`125`	`127`	`}`
`@@ -166,6 +168,7 @@ func TestCreateFusePersistentVolume(t *testing.T) {`
`166`	`168`
`167`	`169`	`func TestCreateFusePersistentVolumeClaim(t *testing.T) {`
`168`	`170`	`runtimeInfo, err := base.BuildRuntimeInfo("hbase", "fluid", common.GooseFSRuntime)`
	`171`	`+ runtimeInfo.SetOwnerDatasetUID("dummy-dataset-uid")`
`169`	`172`	`if err != nil {`
`170`	`173`	`t.Errorf("fail to create the runtimeInfo with error %v", err)`
`171`	`174`	`}`