Skip to content

Commit bcc3798

Browse files
committed
test(dataprocess): check scheme setup errors
Signed-off-by: Harsh <harshmastic@gmail.com>
1 parent 6856704 commit bcc3798

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

pkg/controllers/v1alpha1/dataprocess/controller_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import (
3737
func newTestDataProcessReconciler(s *runtime.Scheme, objs ...runtime.Object) *DataProcessReconciler {
3838
if s == nil {
3939
s = runtime.NewScheme()
40-
_ = datav1alpha1.AddToScheme(s)
40+
Expect(datav1alpha1.AddToScheme(s)).To(Succeed())
4141
}
4242
fakeClient := fake.NewFakeClientWithScheme(s, objs...)
4343
log := logf.Log.WithName("dataprocess-test")
@@ -57,7 +57,7 @@ var _ = Describe("DataProcessReconciler", func() {
5757
Describe("NewDataProcessReconciler", func() {
5858
It("should create a non-nil reconciler with a Scheme", func() {
5959
s := runtime.NewScheme()
60-
_ = datav1alpha1.AddToScheme(s)
60+
Expect(datav1alpha1.AddToScheme(s)).To(Succeed())
6161
r := newTestDataProcessReconciler(s)
6262
Expect(r).NotTo(BeNil())
6363
Expect(r.Scheme).NotTo(BeNil())
@@ -89,7 +89,7 @@ var _ = Describe("DataProcessReconciler", func() {
8989
Describe("Reconcile", func() {
9090
It("should return no error when the DataProcess is not found", func() {
9191
s := runtime.NewScheme()
92-
_ = datav1alpha1.AddToScheme(s)
92+
Expect(datav1alpha1.AddToScheme(s)).To(Succeed())
9393
r := newTestDataProcessReconciler(s)
9494
// No DataProcess objects registered — should get NotFound and return cleanly.
9595
req := ctrl.Request{
@@ -102,7 +102,7 @@ var _ = Describe("DataProcessReconciler", func() {
102102

103103
It("should reconcile successfully when DataProcess exists", func() {
104104
s := runtime.NewScheme()
105-
_ = datav1alpha1.AddToScheme(s)
105+
Expect(datav1alpha1.AddToScheme(s)).To(Succeed())
106106
dp := &datav1alpha1.DataProcess{
107107
ObjectMeta: v1.ObjectMeta{Name: "test", Namespace: "default"},
108108
Spec: datav1alpha1.DataProcessSpec{

pkg/controllers/v1alpha1/dataprocess/implement_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import (
3737
func newTestDataProcessOperation(s *runtime.Scheme, dp *datav1alpha1.DataProcess) *dataProcessOperation {
3838
if s == nil {
3939
s = runtime.NewScheme()
40-
_ = datav1alpha1.AddToScheme(s)
40+
Expect(datav1alpha1.AddToScheme(s)).To(Succeed())
4141
}
4242
fakeClient := fake.NewFakeClientWithScheme(s, dp)
4343
recorder := record.NewFakeRecorder(32)
@@ -232,7 +232,7 @@ var _ = Describe("dataProcessOperation", func() {
232232

233233
BeforeEach(func() {
234234
testScheme = runtime.NewScheme()
235-
_ = datav1alpha1.AddToScheme(testScheme)
235+
Expect(datav1alpha1.AddToScheme(testScheme)).To(Succeed())
236236
ctx = cruntime.ReconcileRequestContext{
237237
Log: fake.NullLogger(),
238238
}

0 commit comments

Comments
 (0)