Skip to content

Commit c0c8c17

Browse files
committed
test(efc): use background context in implement tests
Signed-off-by: Harsh <harshmastic@gmail.com>
1 parent bddbc98 commit c0c8c17

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

pkg/controllers/v1alpha1/efc/implement_test.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ var _ = Describe("RuntimeReconciler (EFC) Implement", func() {
8888

8989
It("should return the runtime when it exists in the cluster", func() {
9090
ctx := cruntime.ReconcileRequestContext{
91-
Context: context.TODO(),
91+
Context: context.Background(),
9292
NamespacedName: types.NamespacedName{Name: "test", Namespace: "default"},
9393
}
9494
result, err := r.getRuntime(ctx)
@@ -100,7 +100,7 @@ var _ = Describe("RuntimeReconciler (EFC) Implement", func() {
100100

101101
It("should return an error when the runtime does not exist", func() {
102102
ctx := cruntime.ReconcileRequestContext{
103-
Context: context.TODO(),
103+
Context: context.Background(),
104104
NamespacedName: types.NamespacedName{Name: "nonexistent", Namespace: "default"},
105105
}
106106
result, err := r.getRuntime(ctx)
@@ -124,7 +124,7 @@ var _ = Describe("RuntimeReconciler (EFC) Implement", func() {
124124
defer patches.Reset()
125125

126126
ctx := cruntime.ReconcileRequestContext{
127-
Context: context.TODO(),
127+
Context: context.Background(),
128128
NamespacedName: types.NamespacedName{Name: "fail", Namespace: "default"},
129129
}
130130
engine, err := r.GetOrCreateEngine(ctx)
@@ -144,7 +144,7 @@ var _ = Describe("RuntimeReconciler (EFC) Implement", func() {
144144
defer patches.Reset()
145145

146146
ctx := cruntime.ReconcileRequestContext{
147-
Context: context.TODO(),
147+
Context: context.Background(),
148148
NamespacedName: types.NamespacedName{Name: "cached", Namespace: "default"},
149149
}
150150

@@ -174,7 +174,7 @@ var _ = Describe("RuntimeReconciler (EFC) Implement", func() {
174174
r.engines[id] = &mockEngine{}
175175

176176
ctx := cruntime.ReconcileRequestContext{
177-
Context: context.TODO(),
177+
Context: context.Background(),
178178
NamespacedName: types.NamespacedName{Name: "test", Namespace: "default"},
179179
}
180180
r.RemoveEngine(ctx)
@@ -185,7 +185,7 @@ var _ = Describe("RuntimeReconciler (EFC) Implement", func() {
185185

186186
It("should not panic when removing a non-existent engine", func() {
187187
ctx := cruntime.ReconcileRequestContext{
188-
Context: context.TODO(),
188+
Context: context.Background(),
189189
NamespacedName: types.NamespacedName{Name: "ghost", Namespace: "default"},
190190
}
191191
Expect(func() { r.RemoveEngine(ctx) }).NotTo(Panic())
@@ -203,7 +203,7 @@ var _ = Describe("RuntimeReconciler (EFC) Implement", func() {
203203
req := ctrl.Request{
204204
NamespacedName: types.NamespacedName{Name: "missing", Namespace: "default"},
205205
}
206-
result, err := r.Reconcile(context.TODO(), req)
206+
result, err := r.Reconcile(context.Background(), req)
207207
Expect(err).NotTo(HaveOccurred())
208208
Expect(result).To(Equal(ctrl.Result{}))
209209
})

0 commit comments

Comments
 (0)