Use replace all instead (#4831)

* Fix not checking result issue

Signed-off-by: cheyang <cheyang@163.com>

* Use ReplaceAll to replace Replace

Signed-off-by: cheyang <cheyang@163.com>

---------

Signed-off-by: cheyang <cheyang@163.com>

Author: cheyang

hack/sdk/main.go

@@ -66,14 +66,14 @@ func main() {
 }
 
 func swaggify(name string) string {
-	name = strings.Replace(name, "github.com/fluid-cloudnative/fluid/api/v1alpha1", "", -1)
-	name = strings.Replace(name, "github.com/kubernetes-sigs/kube-batch/pkg/client/clientset/", "", -1)
-	name = strings.Replace(name, "k8s.io/api/core/", "", -1)
-	name = strings.Replace(name, "k8s.io/apimachinery/pkg/apis/meta/", "", -1)
-	name = strings.Replace(name, "k8s.io/kubernetes/pkg/controller/", "", -1)
-	name = strings.Replace(name, "k8s.io/client-go/listers/core/", "", -1)
-	name = strings.Replace(name, "k8s.io/client-go/util/workqueue", "", -1)
-	name = strings.Replace(name, "k8s.io/apimachinery/pkg/api/resource", "", -1)
-	name = strings.Replace(name, "/", ".", -1)
+	name = strings.ReplaceAll(name, "github.com/fluid-cloudnative/fluid/api/v1alpha1", "")
+	name = strings.ReplaceAll(name, "github.com/kubernetes-sigs/kube-batch/pkg/client/clientset/", "")
+	name = strings.ReplaceAll(name, "k8s.io/api/core/", "")
+	name = strings.ReplaceAll(name, "k8s.io/apimachinery/pkg/apis/meta/", "")
+	name = strings.ReplaceAll(name, "k8s.io/kubernetes/pkg/controller/", "")
+	name = strings.ReplaceAll(name, "k8s.io/client-go/listers/core/", "")
+	name = strings.ReplaceAll(name, "k8s.io/client-go/util/workqueue", "")
+	name = strings.ReplaceAll(name, "k8s.io/apimachinery/pkg/api/resource", "")
+	name = strings.ReplaceAll(name, "/", ".")
 	return name
 }

pkg/utils/crtl_utils_test.go

@@ -441,10 +441,10 @@ func TestGenerateRandomRequeueDurationFromEnv(t *testing.T) {
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			if test.runtimeReconcileDuration != "" {
-				os.Setenv(RuntimeReconcileDurationEnv, test.runtimeReconcileDuration)
+				_ = os.Setenv(RuntimeReconcileDurationEnv, test.runtimeReconcileDuration)
 			}
 			if test.runtimeReconcileOffset != "" {
-				os.Setenv(RuntimeReconcileDurationOffsetEnv, test.runtimeReconcileOffset)
+				_ = os.Setenv(RuntimeReconcileDurationOffsetEnv, test.runtimeReconcileOffset)
 			}
 			defer func() {
 				_ = os.Unsetenv(RuntimeReconcileDurationEnv)