Skip to content

This PR is to add comments to transformTolerations in pkg/ddc/alluxio/transform_resources.go. #4523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fluid-e2e-bot merged 2 commits into from
Mar 13, 2025
Merged

This PR is to add comments to transformTolerations in pkg/ddc/alluxio/transform_resources.go. #4523

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
356e459
Add Notation to transformTolerations in pkg/ddc/alluxio/transform_res…
kennySDing Mar 4, 2025
d6833b0
Gofmt pkg/ddc/alluxio/transform_resources.go
cheyang Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/ddc/alluxio/transform_resources.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,10 @@ func (e *AlluxioEngine) transformResourcesForFuse(runtime *datav1alpha1.AlluxioR

}

// transformTolerations updates the Alluxio configuration with tolerations specified in the dataset.
Copy link
Copy Markdown
Collaborator

@cheyang cheyang Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please insert a blank line between the two functions. Thanks.

// It iterates over each toleration in dataset.Spec.Tolerations, clears the TolerationSeconds field,
// and appends the modified toleration to value.Tolerations. This ensures that only the necessary toleration
// settings (without expiration) are transferred to the Alluxio value.
func (e *AlluxioEngine) transformTolerations(dataset *datav1alpha1.Dataset, value *Alluxio) {
if len(dataset.Spec.Tolerations) > 0 {
// value.Tolerations = dataset.Spec.Tolerations
Expand Down
Loading