Skip to content

This PR is to add comments to patchDatasetStatus in pkg\ddc\alluxio\cache.go. #4578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fluid-e2e-bot merged 2 commits into from
Mar 14, 2025
Merged

This PR is to add comments to patchDatasetStatus in pkg\ddc\alluxio\cache.go. #4578

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4e7aba
Add Notation to patchDatasetStatus in pkg\ddc\alluxio\cache.go
Volta233 Mar 8, 2025
aea0d3e
Add Notation to patchDatasetStatus in pkg\ddc\alluxio\cache.go
Volta233 Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions pkg/ddc/alluxio/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,21 @@ func (e *AlluxioEngine) queryCacheStatus() (states cacheStates, err error) {

}

// PatchDatasetStatus updates the Dataset status with cached percentage based on the provided cache states.
// It skips updating under the following conditions:
// - When the Dataset's UfsTotal field is empty
// - When the Dataset's UfsTotal field contains the metadata sync pending message
// The cached percentage is calculated as (cached bytes / UfsTotal bytes) * 100.
//
// Parameters:
// - dataset (v1alpha1.Dataset): Pointer to the Dataset object containing UFS metadata.
// The Status.UfsTotal field must be a valid human-readable size string (e.g. "10GiB")
// - states (cacheStates): Pointer to the cache state structure that will be modified in-place.
// The cached field must be a valid human-readable size string (e.g. "5GiB")
//
// Returns:
// - None: Modifies the states.cachedPercentage field directly with formatted percentage string.
// The percentage is stored as a string using cachedPercentageFormat (e.g. "45.60%")
func (e AlluxioEngine) patchDatasetStatus(dataset *v1alpha1.Dataset, states *cacheStates) {
// skip when `dataset.Status.UfsTotal` is empty
if dataset.Status.UfsTotal == "" {
Expand Down
Loading