This PR is to add comments to newJindoEngineRT in pkg/ddc/jindo/runtime_info_test.go#4614
Conversation
|
Hi @baoheipojis. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hello @baoheipojis, please fix the DCO Issue by following https://github.com/fluid-cloudnative/fluid/pull/4614/checks?check_run_id=38535318391. |
Done |
| // When withRuntimeInfo is true, it also builds and assigns the runtimeInfo using the | ||
| // provided name, namespace, and common.JindoRuntime type. This helper is used in tests to | ||
| // simulate different runtime configurations. | ||
|
|
There was a problem hiding this comment.
No blank line between comments and method. Leave one blank line between comments and import.
Signed-off-by: Pojis <baoheipojis@gmail.com>
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Ⅰ. Describe what this PR does
Add comments to newJindoEngineRT in pkg/ddc/jindo/runtime_info_test.go
Ⅱ. Does this pull request fix one issue?
fixes #4613
III. Special notes for reviews