Skip to content

This PR is to add comments to newJindoEngineRT in pkg/ddc/jindo/runtime_info_test.go #4614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cheyang merged 1 commit into from
Mar 18, 2025
Merged

This PR is to add comments to newJindoEngineRT in pkg/ddc/jindo/runtime_info_test.go #4614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/ddc/jindo/runtime_info_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ import (
"sigs.k8s.io/controller-runtime/pkg/client"
)

Copy link
Copy Markdown
Collaborator

@cheyang cheyang Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blank line between comments and method. Leave one blank line between comments and import.

// newJindoEngineRT creates a new JindoEngine instance for testing.
// It initializes the engine with a default JindoRuntime and a null logger.
// When withRuntimeInfo is true, it also builds and assigns the runtimeInfo using the
// provided name, namespace, and common.JindoRuntime type. This helper is used in tests to
// simulate different runtime configurations.
func newJindoEngineRT(client client.Client, name string, namespace string, withRuntimeInfo bool) *JindoEngine {
runTimeInfo, _ := base.BuildRuntimeInfo(name, namespace, common.JindoRuntime)
engine := &JindoEngine{
Expand Down
Loading