This PR is to add comments to newJuiceFSEngineRT in "pkg\ddc\juicefs\runtime_info_test.go".#4628
This PR is to add comments to newJuiceFSEngineRT in "pkg\ddc\juicefs\runtime_info_test.go".#4628waloc123 wants to merge 5 commits intofluid-cloudnative:masterfrom
Conversation
…est.go. Signed-off-by: waloc123 <1994807287@qq.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @waloc123. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hello @waloc123, please ensure that the comments are in English, and note that you have mistakenly added comments to two functions. Please verify the corresponding function you are addressing. Thanks. |
…e_info_test.go Signed-off-by: waloc123 <1994807287@qq.com>
|
|
I make a second commit on this branch which fits the request. Is this ok or maybe I should create another branch and a new pull request? |
I make a second commit on this branch which fits the request. Is this ok or maybe I should create another branch and a new pull request? |
| } | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Please keep a return line after the method TestJuiceFSEngine_getRuntimeInfo as beflore.
There was a problem hiding this comment.
@waloc123 Please add a return line in the end of file: [pkg/ddc/juicefs/runtime_info_test.go]
…st.go Signed-off-by: waloc123 <1994807287@qq.com>
|
And please fix the lint checking issue by running |
cheyang
left a comment
cheyang
left a comment
There was a problem hiding this comment.
Please fix the lint check issue.
…est.go. Signed-off-by: waloc123 <1994807287@qq.com>
…est.go. Signed-off-by: waloc123 <1994807287@qq.com>
|
|
I suggest you should submit new PR for this change. Make sure you only add method comments. |
3 participants
Ⅰ. Describe what this PR does
make description for newJuiceFSEngineRT in "pkg\ddc\juicefs\runtime_info_test.go"
Ⅱ. Does this pull request fix one issue?
fixes #4627
Ⅲ. Special notes for reviews
none