Skip to content

This PR is to add comments to newJuiceFSEngineRT in "pkg\ddc\juicefs\runtime_info_test.go". #4628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
waloc123 wants to merge 5 commits into from
Closed

This PR is to add comments to newJuiceFSEngineRT in "pkg\ddc\juicefs\runtime_info_test.go". #4628

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4cda716
Add Notation to UpdateDatasetStatus in pkg/ddc/juicefs/runtime_info_t…
waloc123 Mar 11, 2025
a6d7231
Add comments/notation to newJuiceFSEngineRT in pkg\ddc\juicefs\runtim…
waloc123 Mar 14, 2025
47c1813
Add Notation to newJuiceFSEngineRT in pkg/ddc/juicefs/runtime_info_te…
waloc123 May 30, 2025
f4770ca
Add Notation to UpdateDatasetStatus in pkg/ddc/juicefs/runtime_info_t…
waloc123 Jun 3, 2025
89070ad
Add Notation to UpdateDatasetStatus in pkg/ddc/juicefs/runtime_info_t…
waloc123 Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pkg/ddc/juicefs/runtime_info_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@ import (
"github.com/fluid-cloudnative/fluid/pkg/ddc/base"
)

// newJuiceFSEngineRT creates a new instance of JuiceFSEngine
// client: Kubernetes client
// name: Name of the engine
// namespace: Namespace where the engine resides
// withRuntimeInfo: Whether to include runtime information
// unittest: Whether it is for unit testing
// Returns: A new instance of JuiceFSEngine
func newJuiceFSEngineRT(client client.Client, name string, namespace string, withRuntimeInfo bool, unittest bool) *JuiceFSEngine {
runTimeInfo, _ := base.BuildRuntimeInfo(name, namespace, common.JuiceFSRuntime)
engine := &JuiceFSEngine{
Expand All @@ -49,6 +56,7 @@ func newJuiceFSEngineRT(client client.Client, name string, namespace string, wit
return engine
}


func TestJuiceFSEngine_getRuntimeInfo(t *testing.T) {
runtimeInputs := []*datav1alpha1.JuiceFSRuntime{
{
Expand Down Expand Up @@ -169,4 +177,4 @@ func TestJuiceFSEngine_getRuntimeInfo(t *testing.T) {
t.Errorf(" want %t, got %t", testCase.isErr, isErr)
}
}
}
}
Copy link
Copy Markdown
Collaborator

@cheyang cheyang Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep a return line after the method TestJuiceFSEngine_getRuntimeInfo as beflore.

Copy link
Copy Markdown
Collaborator

@cheyang cheyang Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waloc123 Please add a return line in the end of file: [pkg/ddc/juicefs/runtime_info_test.go]